💬 furszy commented on pull request "http: limit RPC server threads to available cores":
(https://github.com/bitcoin/bitcoin/pull/33678#issuecomment-3432680524)
> Not sure. This seems to be partially reverting [e56fc7c](https://github.com/bitcoin/bitcoin/commit/e56fc7ce6a92eae7e80657d9f57a148cc002358d). See also [#31215 (comment)](https://github.com/bitcoin/bitcoin/pull/31215#discussion_r1828025349)

The default value is kept unless the system has fewer cores. I think it makes sense to not exceed that number, as having more threads than cores doesn’t really help.

💬 achow101 commented on pull request "Improve user dialog when signing multisig psbts":
(https://github.com/bitcoin-core/gui/pull/832#issuecomment-3432685420)
Closing this as it has not had any activity in a while. If you are interested in continuing work on this, please leave a comment so that it can be reopened.

Marking as up for grabs.

✅ achow101 closed a pull request: "Improve user dialog when signing multisig psbts"
(https://github.com/bitcoin-core/gui/pull/832)

💬 achow101 commented on pull request "Dialog for allowing the user to choose the change output when bumping a tx":
(https://github.com/bitcoin-core/gui/pull/700#issuecomment-3432687630)
Are you still working on this?

📝 achow101 converted_to_draft a pull request: "Bugfix - don't allow multiple dialogs for same tx in TransactionView"
(https://github.com/bitcoin-core/gui/pull/817)
Limit to one the transaction details dialogs that a user can open. If a transaction details dialog is already open, bring it to the foreground when a user clicks on its row again - as [suggested](https://github.com/bitcoin-core/gui/pull/817#issuecomment-2051671919..) by flack.

<details>
<summary>Currently a user can open unlimited tx details dialogs for the same tx id.</summary>

![Peek 2024-04-12 00-50](https://github.com/bitcoin-core/gui/assets/110166421/ba5a261b-9234-437f-b496-2f01320f1
...

💬 achow101 commented on pull request "gui: Add a menu action to restore then migrate a legacy wallet":
(https://github.com/bitcoin-core/gui/pull/877#issuecomment-3432697596)
Are you still working on this?

💬 furszy commented on pull request "http: limit RPC server threads to available cores":
(https://github.com/bitcoin/bitcoin/pull/33678#issuecomment-3432697958)
Answered without reading https://github.com/bitcoin/bitcoin/pull/31215#discussion_r1828025349, interesting. Maybe having a bit more is good but maybe not 16 fixed? Like a factor of 2 of the number of cores.

✅ achow101 closed a pull request: "Including exception what() in Runaway dialog box"
(https://github.com/bitcoin-core/gui/pull/876)

💬 achow101 commented on pull request "Including exception what() in Runaway dialog box":
(https://github.com/bitcoin-core/gui/pull/876#issuecomment-3432701682)
This PR does not seem to have attracted much attention from reviewers. As such, it does not seem important enough right now to keep it sitting idle in the list of open PRs.

Closing due to lack of interest.

💬 darosior commented on pull request "miniscript: fixes #29098 by only use first k valid signatures":
(https://github.com/bitcoin/bitcoin/pull/31719#issuecomment-3432713975)
While it may be desirable, i don't think this is a priority (as demonstrated by the lack of reviewer interest). Concept NACK.

👍 theuni approved a pull request: "depends: Avoid `warning: "_FORTIFY_SOURCE" redefined` for `libevent`"
(https://github.com/bitcoin/bitcoin/pull/32266#pullrequestreview-3366133624)
utACK fe71a4b139f3a142468c2e931775813bc8f9d2ad

✅ achow101 closed a pull request: "tests: Added progress tracker when running fuzz test_runner.py"
(https://github.com/bitcoin/bitcoin/pull/32354)

💬 achow101 commented on pull request "tests: Added progress tracker when running fuzz test_runner.py":
(https://github.com/bitcoin/bitcoin/pull/32354#issuecomment-3432732029)
This PR does not seem to have attracted much attention from reviewers. As such, it does not seem important enough right now to keep it sitting idle in the list of open PRs.

Closing due to lack of interest.

💬 maflcko commented on pull request "depends: Avoid `warning: "_FORTIFY_SOURCE" redefined` for `libevent`":
(https://github.com/bitcoin/bitcoin/pull/32266#issuecomment-3432734644)
lgtm ACK fe71a4b139f3a142468c2e931775813bc8f9d2ad

ref: https://github.com/bitcoin/bitcoin/blob/7d27af98c7cf858b5ab5a02e64f89a857cc53172/CMakeLists.txt#L508

💬 l0rinc commented on pull request "Add option dbfilesize to control LevelDB target ("max") file size":
(https://github.com/bitcoin/bitcoin/pull/30059#issuecomment-3432739650)
Since the merge of the original PR changing this value from 2MB to 32MB, based on surfaced user feedback and secondary effects, it seems obvious to me this isn't something we should make configurable (it just makes it harder for us to reason about behavior).

https://github.com/bitcoin/bitcoin/issues/32455#issuecomment-2925382555 revealed that while this change does support dynamically changing file sizes (we've documented this in the original PR), it is understandably surprising to the users
...

💬 pablomartin4btc commented on pull request "Bugfix - don't allow multiple dialogs for same tx in TransactionView":
(https://github.com/bitcoin-core/gui/pull/817#issuecomment-3432742271)
Temporarily drafting it since I've found some issues on Qt 6 while reviewing #904. WIP.

💬 achow101 commented on pull request "Extend signetchallenge to set target block spacing":
(https://github.com/bitcoin/bitcoin/pull/29365#issuecomment-3432744483)
Are you still working on this?

Are any of the Concept ACKers interested in actually reviewing this?

📝 l0rinc opened a pull request: "validation: do not wipe utxo cache for stats/scans/snapshots"
(https://github.com/bitcoin/bitcoin/pull/33680)
Revival of https://github.com/bitcoin/bitcoin/pull/30610#issuecomment-3432564955

> Since #28280, the cost of a non-wiping sync of the UTXO cache is only proportional to the number of dirty entries, rather than proportional to the size of the entire cache. Because of that, there is no reason to perform a wiping flush in case the contents of the cache is still useful.
>
> Split the `FlushStateMode::ALWAYS` mode into a `FORCE_SYNC` (non-wiping) and a `FORCE_FLUSH` (wiping), and then use the f
...

💬 l0rinc commented on pull request "validation: do not wipe utxo cache for stats/scans/snapshots":
(https://github.com/bitcoin/bitcoin/pull/30610#issuecomment-3432754607)
Revived in https://github.com/bitcoin/bitcoin/pull/33680, let's continue review there

💬 achow101 commented on pull request "miner: don't needlessly append dummy OP_0 to bip34":
(https://github.com/bitcoin/bitcoin/pull/32420#issuecomment-3432756742)
Are you still working on this?