💬 achow101 commented on pull request "doc: external-signer, example 'createwallet' RPC call requires eight argument":
(https://github.com/bitcoin/bitcoin/pull/30354#issuecomment-3432602049)
cc @Sjors

💬 achow101 commented on pull request "kernel: Avoid duplicating symbols in the kernel and downstream users":
(https://github.com/bitcoin/bitcoin/pull/31807#issuecomment-3432609753)
Are you still working on this?

✅ achow101 closed a pull request: "Wallet: (Refactor) GetBalance to calculate used balance"
(https://github.com/bitcoin/bitcoin/pull/29062)

💬 achow101 commented on pull request "Wallet: (Refactor) GetBalance to calculate used balance":
(https://github.com/bitcoin/bitcoin/pull/29062#issuecomment-3432615176)
Closing this as it has not had any activity in a while. If you are interested in continuing work on this, please leave a comment so that it can be reopened.

💬 achow101 commented on pull request "test: autogenerate bash completion":
(https://github.com/bitcoin/bitcoin/pull/30860#issuecomment-3432620265)
Closing this as it has not had any activity in a while. If you are interested in continuing work on this, please leave a comment so that it can be reopened.

✅ achow101 closed a pull request: "test: autogenerate bash completion"
(https://github.com/bitcoin/bitcoin/pull/30860)

💬 ryanofsky commented on pull request "multiprocess: Fix high overhead from message logging":
(https://github.com/bitcoin/bitcoin/pull/33517#issuecomment-3432628830)
Just to follow up, I think it was unclear if this change was compatible with the [logging RPC](https://github.com/bitcoin/bitcoin/blob/7d27af98c7cf858b5ab5a02e64f89a857cc53172/src/rpc/node.cpp#L215) that allows log levels to be changed at runtime.

I think it actually is compatible because the current RPC method only allows enabling/disabling categories without adjusting levels. If a way to adjust log levels is added though, a special case like the one added for [libevent](https://github.com/b
...

💬 achow101 commented on pull request "rpc: Add support to populate PSBT input utxos via rpc":
(https://github.com/bitcoin/bitcoin/pull/30886#issuecomment-3432657646)
Closing this as it has not had any activity in a while. If you are interested in continuing work on this, please leave a comment so that it can be reopened.

✅ achow101 closed a pull request: "rpc: Add support to populate PSBT input utxos via rpc"
(https://github.com/bitcoin/bitcoin/pull/30886)

✅ achow101 closed a pull request: "Bugfix: Address broken things around Peers detail view"
(https://github.com/bitcoin-core/gui/pull/677)

💬 achow101 commented on pull request "Bugfix: Address broken things around Peers detail view":
(https://github.com/bitcoin-core/gui/pull/677#issuecomment-3432666946)
Closing this as it has not had any activity in a while. If you are interested in continuing work on this, please leave a comment so that it can be reopened.

💬 achow101 commented on pull request "Enable customisation of QR Code font":
(https://github.com/bitcoin-core/gui/pull/820#issuecomment-3432668230)
Closing this as it has not had any activity in a while. If you are interested in continuing work on this, please leave a comment so that it can be reopened.

✅ achow101 closed a pull request: "Enable customisation of QR Code font"
(https://github.com/bitcoin-core/gui/pull/820)

💬 achow101 commented on pull request "refactor: interfaces, make 'createTransaction' less error-prone ":
(https://github.com/bitcoin-core/gui/pull/807#issuecomment-3432672483)
Are you still working on this?

💬 furszy commented on pull request "http: limit RPC server threads to available cores":
(https://github.com/bitcoin/bitcoin/pull/33678#issuecomment-3432680524)
> Not sure. This seems to be partially reverting [e56fc7c](https://github.com/bitcoin/bitcoin/commit/e56fc7ce6a92eae7e80657d9f57a148cc002358d). See also [#31215 (comment)](https://github.com/bitcoin/bitcoin/pull/31215#discussion_r1828025349)

The default value is kept unless the system has fewer cores. I think it makes sense to not exceed that number, as having more threads than cores doesn’t really help.

💬 achow101 commented on pull request "Improve user dialog when signing multisig psbts":
(https://github.com/bitcoin-core/gui/pull/832#issuecomment-3432685420)
Closing this as it has not had any activity in a while. If you are interested in continuing work on this, please leave a comment so that it can be reopened.

Marking as up for grabs.

✅ achow101 closed a pull request: "Improve user dialog when signing multisig psbts"
(https://github.com/bitcoin-core/gui/pull/832)

💬 achow101 commented on pull request "Dialog for allowing the user to choose the change output when bumping a tx":
(https://github.com/bitcoin-core/gui/pull/700#issuecomment-3432687630)
Are you still working on this?

📝 achow101 converted_to_draft a pull request: "Bugfix - don't allow multiple dialogs for same tx in TransactionView"
(https://github.com/bitcoin-core/gui/pull/817)
Limit to one the transaction details dialogs that a user can open. If a transaction details dialog is already open, bring it to the foreground when a user clicks on its row again - as [suggested](https://github.com/bitcoin-core/gui/pull/817#issuecomment-2051671919..) by flack.

<details>
<summary>Currently a user can open unlimited tx details dialogs for the same tx id.</summary>

![Peek 2024-04-12 00-50](https://github.com/bitcoin-core/gui/assets/110166421/ba5a261b-9234-437f-b496-2f01320f1
...

💬 achow101 commented on pull request "gui: Add a menu action to restore then migrate a legacy wallet":
(https://github.com/bitcoin-core/gui/pull/877#issuecomment-3432697596)
Are you still working on this?