💬 achow101 commented on pull request "validation: do not wipe utxo cache for stats/scans/snapshots":
(https://github.com/bitcoin/bitcoin/pull/30610#issuecomment-3432564955)
Closing this as it has not had any activity in a while. If you are interested in continuing work on this, please leave a comment so that it can be reopened.

✅ achow101 closed a pull request: "validation: do not wipe utxo cache for stats/scans/snapshots"
(https://github.com/bitcoin/bitcoin/pull/30610)

💬 Raimo33 commented on pull request "refactor: optimize: reuse containers in transaction policy verification":
(https://github.com/bitcoin/bitcoin/pull/33645#issuecomment-3432572647)
> * In AreInputsStandard(...): Don't move the stack outside the for loop

Agreed: it is not in the hot path (or the most likely path).

> * In IsWitnessStandard(...): Don't move stack and witnessprogram outside the for loop

Agreed for `stack`: it is only needed for P2SH which is unlikely
Disagree for `witnessprogram`: it is used in the hot path (P2WPKH is the most likely)

> * In `SpendsNonAnchorWitnessProg(...)`: Don't move `stack` outside the for loop.

Agreed: it is not in the hot
...

💬 l0rinc commented on pull request "refactor: optimize: reuse containers in transaction policy verification":
(https://github.com/bitcoin/bitcoin/pull/33645#issuecomment-3432572935)
> Since std::vector only allocates on first use

Actually it can reallocate on every size exhaustion, i.e. every resize.
I don't like the new reuse, that can actually be slower than before because now the code paths depend on each other.
Wouldn't reserving the vectors help here instead?

✅ achow101 closed a pull request: "RPC/Wallet: Convert walletprocesspsbt to use options parameter"
(https://github.com/bitcoin/bitcoin/pull/24963)

💬 achow101 commented on pull request "RPC/Wallet: Convert walletprocesspsbt to use options parameter":
(https://github.com/bitcoin/bitcoin/pull/24963#issuecomment-3432582603)
Closing this as it has not had any activity in a while. If you are interested in continuing work on this, please leave a comment so that it can be reopened.

Marking as up for grabs.

💬 achow101 commented on pull request "doc: external-signer, example 'createwallet' RPC call requires eight argument":
(https://github.com/bitcoin/bitcoin/pull/30354#issuecomment-3432602049)
cc @Sjors

💬 achow101 commented on pull request "kernel: Avoid duplicating symbols in the kernel and downstream users":
(https://github.com/bitcoin/bitcoin/pull/31807#issuecomment-3432609753)
Are you still working on this?

✅ achow101 closed a pull request: "Wallet: (Refactor) GetBalance to calculate used balance"
(https://github.com/bitcoin/bitcoin/pull/29062)

💬 achow101 commented on pull request "Wallet: (Refactor) GetBalance to calculate used balance":
(https://github.com/bitcoin/bitcoin/pull/29062#issuecomment-3432615176)
Closing this as it has not had any activity in a while. If you are interested in continuing work on this, please leave a comment so that it can be reopened.

💬 achow101 commented on pull request "test: autogenerate bash completion":
(https://github.com/bitcoin/bitcoin/pull/30860#issuecomment-3432620265)
Closing this as it has not had any activity in a while. If you are interested in continuing work on this, please leave a comment so that it can be reopened.

✅ achow101 closed a pull request: "test: autogenerate bash completion"
(https://github.com/bitcoin/bitcoin/pull/30860)

💬 ryanofsky commented on pull request "multiprocess: Fix high overhead from message logging":
(https://github.com/bitcoin/bitcoin/pull/33517#issuecomment-3432628830)
Just to follow up, I think it was unclear if this change was compatible with the [logging RPC](https://github.com/bitcoin/bitcoin/blob/7d27af98c7cf858b5ab5a02e64f89a857cc53172/src/rpc/node.cpp#L215) that allows log levels to be changed at runtime.

I think it actually is compatible because the current RPC method only allows enabling/disabling categories without adjusting levels. If a way to adjust log levels is added though, a special case like the one added for [libevent](https://github.com/b
...

💬 achow101 commented on pull request "rpc: Add support to populate PSBT input utxos via rpc":
(https://github.com/bitcoin/bitcoin/pull/30886#issuecomment-3432657646)
Closing this as it has not had any activity in a while. If you are interested in continuing work on this, please leave a comment so that it can be reopened.

✅ achow101 closed a pull request: "rpc: Add support to populate PSBT input utxos via rpc"
(https://github.com/bitcoin/bitcoin/pull/30886)

✅ achow101 closed a pull request: "Bugfix: Address broken things around Peers detail view"
(https://github.com/bitcoin-core/gui/pull/677)

💬 achow101 commented on pull request "Bugfix: Address broken things around Peers detail view":
(https://github.com/bitcoin-core/gui/pull/677#issuecomment-3432666946)
Closing this as it has not had any activity in a while. If you are interested in continuing work on this, please leave a comment so that it can be reopened.

💬 achow101 commented on pull request "Enable customisation of QR Code font":
(https://github.com/bitcoin-core/gui/pull/820#issuecomment-3432668230)
Closing this as it has not had any activity in a while. If you are interested in continuing work on this, please leave a comment so that it can be reopened.

✅ achow101 closed a pull request: "Enable customisation of QR Code font"
(https://github.com/bitcoin-core/gui/pull/820)

💬 achow101 commented on pull request "refactor: interfaces, make 'createTransaction' less error-prone ":
(https://github.com/bitcoin-core/gui/pull/807#issuecomment-3432672483)
Are you still working on this?