💬 laanwj commented on pull request "randomenv: drop self define of 'environ'":
(https://github.com/bitcoin/bitcoin/pull/33675#issuecomment-3431220853)
Concept ACK
(https://github.com/bitcoin/bitcoin/pull/33675#issuecomment-3431220853)
Concept ACK
💬 maflcko commented on pull request "randomenv: drop self define of 'environ'":
(https://github.com/bitcoin/bitcoin/pull/33675#issuecomment-3431240789)
(mimicking drahtbot, bleeb blop)
https://github.com/bitcoin/bitcoin/actions/runs/18710961104/job/53359113198?pr=33675#step:9:1582:
```
[ 13%] Building CXX object src/util/CMakeFiles/bitcoin_util.dir/__/randomenv.cpp.o
cd /home/admin/actions-runner/_work/_temp/build/src/util && /bin/ccache /usr/bin/clang++ --target=arm64-apple-darwin -isysroot/home/admin/actions-runner/_work/_temp/depends/SDKs/Xcode-15.0-15A240d-extracted-SDK-with-libcxx-headers -nostdlibinc -iwithsysroot/usr/include/c++
...
(https://github.com/bitcoin/bitcoin/pull/33675#issuecomment-3431240789)
(mimicking drahtbot, bleeb blop)
https://github.com/bitcoin/bitcoin/actions/runs/18710961104/job/53359113198?pr=33675#step:9:1582:
```
[ 13%] Building CXX object src/util/CMakeFiles/bitcoin_util.dir/__/randomenv.cpp.o
cd /home/admin/actions-runner/_work/_temp/build/src/util && /bin/ccache /usr/bin/clang++ --target=arm64-apple-darwin -isysroot/home/admin/actions-runner/_work/_temp/depends/SDKs/Xcode-15.0-15A240d-extracted-SDK-with-libcxx-headers -nostdlibinc -iwithsysroot/usr/include/c++
...
💬 pablomartin4btc commented on pull request "wallettool, test: Remove BDB/ legacy wallets dump feature":
(https://github.com/bitcoin/bitcoin/pull/33161#issuecomment-3431249637)
> being able to dump a BDB wallet is the only way to migrate a bdb-descriptor wallet (these could only be created for a few months in 2020).
Should we document this? Perhaps in the "migrating" [section](https://github.com/bitcoin/bitcoin/blob/master/doc/managing-wallets.md#migrating-legacy-wallets-to-descriptor-wallets) on `managing-wallets.md`...
(https://github.com/bitcoin/bitcoin/pull/33161#issuecomment-3431249637)
> being able to dump a BDB wallet is the only way to migrate a bdb-descriptor wallet (these could only be created for a few months in 2020).
Should we document this? Perhaps in the "migrating" [section](https://github.com/bitcoin/bitcoin/blob/master/doc/managing-wallets.md#migrating-legacy-wallets-to-descriptor-wallets) on `managing-wallets.md`...
✅ sipa closed a pull request: "randomenv: drop self define of 'environ'"
(https://github.com/bitcoin/bitcoin/pull/33675)
(https://github.com/bitcoin/bitcoin/pull/33675)
💬 sipa commented on pull request "randomenv: drop self define of 'environ'":
(https://github.com/bitcoin/bitcoin/pull/33675#issuecomment-3431269051)
It appears that mac OS actually requires defining it manually.
(https://github.com/bitcoin/bitcoin/pull/33675#issuecomment-3431269051)
It appears that mac OS actually requires defining it manually.
💬 comassky commented on issue "Hidden service created by `--torcontrol` does not accept connections (General SOCKS server failure)":
(https://github.com/bitcoin/bitcoin/issues/25094#issuecomment-3431281507)
Hi, same issue here with 29.2
```
listen=1
discover=0
onion=tor:9050
onlynet=onion
torcontrol=tor:9051
torpassword=<PASSWORD<
debug=tor
bind=0.0.0.0:8334=onion
```
```
2025-10-22T09:09:19Z [tor] Reading cached private key from /home/bitcoin/.bitcoin/onion_v3_private_key
2025-10-22T09:09:19Z [tor] Successfully connected!
2025-10-22T09:09:19Z msghand thread start
2025-10-22T09:09:19Z [tor] Connected to Tor version 0.4.8.19
2025-10-22T09:09:19Z [tor] Supported authentication method: HASHEDPASS
...
(https://github.com/bitcoin/bitcoin/issues/25094#issuecomment-3431281507)
Hi, same issue here with 29.2
```
listen=1
discover=0
onion=tor:9050
onlynet=onion
torcontrol=tor:9051
torpassword=<PASSWORD<
debug=tor
bind=0.0.0.0:8334=onion
```
```
2025-10-22T09:09:19Z [tor] Reading cached private key from /home/bitcoin/.bitcoin/onion_v3_private_key
2025-10-22T09:09:19Z [tor] Successfully connected!
2025-10-22T09:09:19Z msghand thread start
2025-10-22T09:09:19Z [tor] Connected to Tor version 0.4.8.19
2025-10-22T09:09:19Z [tor] Supported authentication method: HASHEDPASS
...
💬 laanwj commented on pull request "randomenv: Fix MinGW dllimport warning for `environ`":
(https://github.com/bitcoin/bitcoin/pull/33570#issuecomment-3431298433)
After discussion i'm convinced that this is the right solution. According to man pages, on POSIX (non-windows) platforms, including MacOS, you are supposed to define this variable yourself. So it can't be removed entirely.
On Windows (irrespective of compiler or toolchain) it's provided by the headers, and defined in a different way, so if we want to use environ therel, we shouldn't define it ourselves.
Note that it's [deprecated](https://learn.microsoft.com/en-us/cpp/c-runtime-library/env
...
(https://github.com/bitcoin/bitcoin/pull/33570#issuecomment-3431298433)
After discussion i'm convinced that this is the right solution. According to man pages, on POSIX (non-windows) platforms, including MacOS, you are supposed to define this variable yourself. So it can't be removed entirely.
On Windows (irrespective of compiler or toolchain) it's provided by the headers, and defined in a different way, so if we want to use environ therel, we shouldn't define it ourselves.
Note that it's [deprecated](https://learn.microsoft.com/en-us/cpp/c-runtime-library/env
...
💬 achow101 commented on pull request "wallettool, test: Remove BDB/ legacy wallets dump feature":
(https://github.com/bitcoin/bitcoin/pull/33161#issuecomment-3431305009)
> Should we document this?
No, bdb-descriptor was never a officially supported configuration.
(https://github.com/bitcoin/bitcoin/pull/33161#issuecomment-3431305009)
> Should we document this?
No, bdb-descriptor was never a officially supported configuration.
💬 maflcko commented on pull request "ci: add Valgrind fuzz":
(https://github.com/bitcoin/bitcoin/pull/33461#discussion_r2451180232)
Hmm, looks like it was faster, which seems odd
(https://github.com/bitcoin/bitcoin/pull/33461#discussion_r2451180232)
Hmm, looks like it was faster, which seems odd
💬 glozow commented on pull request "doc: add AGENTS.md":
(https://github.com/bitcoin/bitcoin/pull/33662#issuecomment-3431424348)
If this is/becomes an established convention, I think it's fine to have an agents.md. I'm interested to see what other ways this can help - my cursory reading suggests this can aid agents in understanding dos and donts of the repo, codebase organization, documentation hints, etc. But I'm not really interested in encouraging more contributions that are authored this way.
My current reaction is that this will "catch" very few people who don't want to disclose. In my experience, you'd really nee
...
(https://github.com/bitcoin/bitcoin/pull/33662#issuecomment-3431424348)
If this is/becomes an established convention, I think it's fine to have an agents.md. I'm interested to see what other ways this can help - my cursory reading suggests this can aid agents in understanding dos and donts of the repo, codebase organization, documentation hints, etc. But I'm not really interested in encouraging more contributions that are authored this way.
My current reaction is that this will "catch" very few people who don't want to disclose. In my experience, you'd really nee
...
👍 hebasto approved a pull request: "randomenv: Fix MinGW dllimport warning for `environ`"
(https://github.com/bitcoin/bitcoin/pull/33570#pullrequestreview-3364800231)
My Guix build:
```
917a1df9f8f548b0c6d99bce8bb4774e7095480f7a5a14d4a0d724db78204e98 guix-build-9610b0d1e28a/output/dist-archive/bitcoin-9610b0d1e28a.tar.gz
3372aedd6ed25924fc6e22596114ad8d9a994fb4c1342e1308b4fdbb7a38bdf7 guix-build-9610b0d1e28a/output/x86_64-w64-mingw32/SHA256SUMS.part
8e2bd977f7b6ef6993361d3b49fec11e5d92e6ed72142d9b25896cc4412e2655 guix-build-9610b0d1e28a/output/x86_64-w64-mingw32/bitcoin-9610b0d1e28a-win64-codesigning.tar.gz
fd160165f6e496f0f498b56a467dea67af2c4f341326ea56e
...
(https://github.com/bitcoin/bitcoin/pull/33570#pullrequestreview-3364800231)
My Guix build:
```
917a1df9f8f548b0c6d99bce8bb4774e7095480f7a5a14d4a0d724db78204e98 guix-build-9610b0d1e28a/output/dist-archive/bitcoin-9610b0d1e28a.tar.gz
3372aedd6ed25924fc6e22596114ad8d9a994fb4c1342e1308b4fdbb7a38bdf7 guix-build-9610b0d1e28a/output/x86_64-w64-mingw32/SHA256SUMS.part
8e2bd977f7b6ef6993361d3b49fec11e5d92e6ed72142d9b25896cc4412e2655 guix-build-9610b0d1e28a/output/x86_64-w64-mingw32/bitcoin-9610b0d1e28a-win64-codesigning.tar.gz
fd160165f6e496f0f498b56a467dea67af2c4f341326ea56e
...
🚀 hebasto merged a pull request: "randomenv: Fix MinGW dllimport warning for `environ`"
(https://github.com/bitcoin/bitcoin/pull/33570)
(https://github.com/bitcoin/bitcoin/pull/33570)
👍 dergoegge approved a pull request: "ci: add Valgrind fuzz"
(https://github.com/bitcoin/bitcoin/pull/33461#pullrequestreview-3364823891)
ACK e4b04630bcf59ea03c1373777a0167af699f92a4
(https://github.com/bitcoin/bitcoin/pull/33461#pullrequestreview-3364823891)
ACK e4b04630bcf59ea03c1373777a0167af699f92a4
💬 cedwies commented on pull request "ci: Only write docker build images to Cirrus cache":
(https://github.com/bitcoin/bitcoin/pull/33639#issuecomment-3431476175)
reACK fabe0e0
(https://github.com/bitcoin/bitcoin/pull/33639#issuecomment-3431476175)
reACK fabe0e0
🤔 brunoerg reviewed a pull request: "Cluster mempool"
(https://github.com/bitcoin/bitcoin/pull/33629#pullrequestreview-3363955723)
I ran a mutation testing analysis on this PR. The mutants were generated incrementally. Unit and functional tests look great overall - over 80% of mutation score. I've dropped some unkilled mutants here, feel free to address them (write tests to kill) or ignore if unproductive.
(https://github.com/bitcoin/bitcoin/pull/33629#pullrequestreview-3363955723)
I ran a mutation testing analysis on this PR. The mutants were generated incrementally. Unit and functional tests look great overall - over 80% of mutation score. I've dropped some unkilled mutants here, feel free to address them (write tests to kill) or ignore if unproductive.
💬 brunoerg commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2450631707)
Unkilled mutant:
```diff
diff --git a/src/txmempool.cpp b/src/txmempool.cpp
index b0c9ab043c..8d7e4d2bb9 100644
--- a/src/txmempool.cpp
+++ b/src/txmempool.cpp
@@ -994,7 +994,7 @@ void CTxMemPool::ChangeSet::ProcessDependencies()
}
}
}
- m_dependencies_processed = true;
+ m_dependencies_processed = false;
return;
}
```
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2450631707)
Unkilled mutant:
```diff
diff --git a/src/txmempool.cpp b/src/txmempool.cpp
index b0c9ab043c..8d7e4d2bb9 100644
--- a/src/txmempool.cpp
+++ b/src/txmempool.cpp
@@ -994,7 +994,7 @@ void CTxMemPool::ChangeSet::ProcessDependencies()
}
}
}
- m_dependencies_processed = true;
+ m_dependencies_processed = false;
return;
}
```
💬 brunoerg commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2450756366)
Removing this doesn't make the test to fail:
```diff
diff --git a/src/test/rbf_tests.cpp b/src/test/rbf_tests.cpp
index 45dd8bcb12..8ef8f0618c 100644
--- a/src/test/rbf_tests.cpp
+++ b/src/test/rbf_tests.cpp
@@ -225,7 +225,7 @@ BOOST_FIXTURE_TEST_CASE(rbf_conflicts_calculator, TestChain100Setup)
// Add some descendants now to each of the direct children (we can do this now that the clusters have split).
for (const auto& child : direct_children) {
- add_descendants(c
...
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2450756366)
Removing this doesn't make the test to fail:
```diff
diff --git a/src/test/rbf_tests.cpp b/src/test/rbf_tests.cpp
index 45dd8bcb12..8ef8f0618c 100644
--- a/src/test/rbf_tests.cpp
+++ b/src/test/rbf_tests.cpp
@@ -225,7 +225,7 @@ BOOST_FIXTURE_TEST_CASE(rbf_conflicts_calculator, TestChain100Setup)
// Add some descendants now to each of the direct children (we can do this now that the clusters have split).
for (const auto& child : direct_children) {
- add_descendants(c
...
💬 brunoerg commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2450650949)
Unkilled mutant:
```diff
diff --git a/src/txmempool.cpp b/src/txmempool.cpp
index b0c9ab043c..bdbbc8325d 100644
--- a/src/txmempool.cpp
+++ b/src/txmempool.cpp
@@ -121,7 +121,7 @@ bool CTxMemPool::HasDescendants(const Txid& txid) const
{
LOCK(cs);
auto entry = GetEntry(txid);
- if (!entry) return false;
+ if (1==0) return false;
return m_txgraph->GetDescendants(*entry, TxGraph::Level::MAIN).size() > 1;
}
```
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2450650949)
Unkilled mutant:
```diff
diff --git a/src/txmempool.cpp b/src/txmempool.cpp
index b0c9ab043c..bdbbc8325d 100644
--- a/src/txmempool.cpp
+++ b/src/txmempool.cpp
@@ -121,7 +121,7 @@ bool CTxMemPool::HasDescendants(const Txid& txid) const
{
LOCK(cs);
auto entry = GetEntry(txid);
- if (!entry) return false;
+ if (1==0) return false;
return m_txgraph->GetDescendants(*entry, TxGraph::Level::MAIN).size() > 1;
}
```
💬 brunoerg commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2450642965)
Unkilled mutant:
```diff
diff --git a/src/txmempool.cpp b/src/txmempool.cpp
index b0c9ab043c..aef4fdde8d 100644
--- a/src/txmempool.cpp
+++ b/src/txmempool.cpp
@@ -129,7 +129,7 @@ CTxMemPool::setEntries CTxMemPool::CalculateMemPoolAncestors(const CTxMemPoolEnt
{
auto ancestors = m_txgraph->GetAncestors(entry, TxGraph::Level::MAIN);
setEntries ret;
- if (ancestors.size() > 0) {
+ if (ancestors.size() < 0) {
for (auto ancestor : ancestors) {
if
...
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2450642965)
Unkilled mutant:
```diff
diff --git a/src/txmempool.cpp b/src/txmempool.cpp
index b0c9ab043c..aef4fdde8d 100644
--- a/src/txmempool.cpp
+++ b/src/txmempool.cpp
@@ -129,7 +129,7 @@ CTxMemPool::setEntries CTxMemPool::CalculateMemPoolAncestors(const CTxMemPoolEnt
{
auto ancestors = m_txgraph->GetAncestors(entry, TxGraph::Level::MAIN);
setEntries ret;
- if (ancestors.size() > 0) {
+ if (ancestors.size() < 0) {
for (auto ancestor : ancestors) {
if
...
💬 brunoerg commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2450722652)
Unkilled mutant:
```diff
diff --git a/src/txmempool.cpp b/src/txmempool.cpp
index b0c9ab043c..9142d8d2c6 100644
--- a/src/txmempool.cpp
+++ b/src/txmempool.cpp
@@ -947,7 +947,7 @@ CTxMemPool::ChangeSet::TxHandle CTxMemPool::ChangeSet::StageAddition(const CTran
TxGraph::Ref ref(m_pool->m_txgraph->AddTransaction(FeePerWeight(fee+delta, GetSigOpsAdjustedWeight(GetTransactionWeight(*tx), sigops_cost, ::nBytesPerSigOp))));
auto newit = m_to_add.emplace(std::move(ref), tx, fee, t
...
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2450722652)
Unkilled mutant:
```diff
diff --git a/src/txmempool.cpp b/src/txmempool.cpp
index b0c9ab043c..9142d8d2c6 100644
--- a/src/txmempool.cpp
+++ b/src/txmempool.cpp
@@ -947,7 +947,7 @@ CTxMemPool::ChangeSet::TxHandle CTxMemPool::ChangeSet::StageAddition(const CTran
TxGraph::Ref ref(m_pool->m_txgraph->AddTransaction(FeePerWeight(fee+delta, GetSigOpsAdjustedWeight(GetTransactionWeight(*tx), sigops_cost, ::nBytesPerSigOp))));
auto newit = m_to_add.emplace(std::move(ref), tx, fee, t
...