💬 andrewtoth commented on pull request "validation: fetch block inputs on parallel threads >10% faster IBD":
(https://github.com/bitcoin/bitcoin/pull/31132#issuecomment-3427748120)
Thank you for your review @l0rinc!

> I love the new structure, it's a lot easier to track the progress compared to previous versions. It's also measurably faster than previous versions, we seem to be nearing ~20% - sweeeet!

:rocket:

> we can make this as simple and useful as possible

What else do you have in mind for this being useful? It has a very focused purpose in my view. I would love to make it as simple as possible.

> using barriers

Done :)

> filtering and sorting bef
...

📝 ajtowns opened a pull request: "[wip] wallet: Add separate balance info for non-mempool wallet txs"
(https://github.com/bitcoin/bitcoin/pull/33671)
Changes `getbalances` to report the balance of outputs for transactions that aren't confirmed nor in the mempool (eg due to being part of too long a mempool chain, or spending non-standard outputs, or having a datacarrier output that exceeds `-datacarriersize`, etc)

```
$ bitcoin-cli -regtest getbalances
{
"mine": {
"trusted": 5764.96604310,
"untrusted_pending": 0.00000000,
"immature": 3325.00009446,
"nonmempool": 19.99995580
},
"lastprocessedblock": {
"has
...

💬 rkrux commented on pull request "wallet: refactor to remove redundant sighash calculation":
(https://github.com/bitcoin/bitcoin/pull/33665#issuecomment-3427816798)
Pushed the second commit to fix the fuzz test failures.

👋 rkrux's pull request is ready for review: "wallet: refactor to remove redundant sighash calculation"
(https://github.com/bitcoin/bitcoin/pull/33665)

💬 ajtowns commented on pull request "[wip] wallet: Add separate balance info for non-mempool wallet txs":
(https://github.com/bitcoin/bitcoin/pull/33671#issuecomment-3427837874)
Relevant for #29415 -- private relay of our wallet transactions would create spends that weren't in the mempool and would thus disappear mysteriously from the wallet balance which seems unacceptable. I think I've seen similar behaviour when doing lots of consolidations of my signet wallet, which has also been disturbing.

Perhaps see #11020 for a similar previous attempt.

This PR currently doesn't include tests that this works sensibly for nonzero nonmempool balances, hence wip/draft.

💬 hebasto commented on pull request "CMake: Add dynamic test discovery":
(https://github.com/bitcoin/bitcoin/pull/33483#issuecomment-3428571662)
Concept ACK.

💬 hebasto commented on pull request "CMake: Add dynamic test discovery":
(https://github.com/bitcoin/bitcoin/pull/33483#discussion_r2449351716)
Why is this needed?

📝 ilkinsufi opened a pull request: "qt: Increase tooltip wrap threshold from 80 to 100 characters"
(https://github.com/bitcoin/bitcoin/pull/33672)
## Summary
This PR increases the tooltip wrap threshold from 80 to 100 characters to improve user experience.

## Changes
- Modified `TOOLTIP_WRAP_THRESHOLD` constant in `src/qt/guiconstants.h`
- Changed value from 80 to 100 characters

## Rationale
The previous threshold of 80 characters was too restrictive for modern displays and longer descriptive tooltips. This change allows more content to be displayed before tooltips are converted to rich text format.

## Testing
- No linter err
...

💬 hebasto commented on pull request "qt: Increase tooltip wrap threshold from 80 to 100 characters":
(https://github.com/bitcoin/bitcoin/pull/33672#issuecomment-3428797618)
Please move this PR to the GUI repo: https://github.com/bitcoin-core/gui/pulls.

✅ ilkinsufi closed a pull request: "qt: Increase tooltip wrap threshold from 80 to 100 characters"
(https://github.com/bitcoin/bitcoin/pull/33672)

📝 ilkinsufi opened a pull request: "qt: Increase tooltip wrap threshold from 80 to 100 characters"
(https://github.com/bitcoin-core/gui/pull/905)
## Summary
This PR increases the tooltip wrap threshold from 80 to 100 characters to improve user experience.

## Changes
- Modified `TOOLTIP_WRAP_THRESHOLD` constant in `src/qt/guiconstants.h`
- Changed value from 80 to 100 characters

## Rationale
The previous threshold of 80 characters was too restrictive for modern displays and longer descriptive tooltips. This change allows more content to be displayed before tooltips are converted to rich text format.

## Testing
- No linter err
...

🤔 hebasto reviewed a pull request: "CMake: Add dynamic test discovery"
(https://github.com/bitcoin/bitcoin/pull/33483#pullrequestreview-3362343633)
The following comments no longer seem needed:https://github.com/bitcoin/bitcoin/blob/2bedad455934c9b407329d0bf58521cf24510465/src/test/CMakeLists.txt#L7-L8 https://github.com/bitcoin/bitcoin/blob/2bedad455934c9b407329d0bf58521cf24510465/src/wallet/test/CMakeLists.txt#L5-L6

💬 trevarj commented on pull request "guix: Use UCRT runtime for Windows release binaries":
(https://github.com/bitcoin/bitcoin/pull/33593#issuecomment-3429226876)
I could submit an upstream Guix patch for this. It will help with build times since the package with ucrt will be in the main substitute servers.

💬 romanz commented on pull request "rest: allow reading partial block data from storage":
(https://github.com/bitcoin/bitcoin/pull/33657#discussion_r2449615816)
Added in [c9bfd298be..301116e855](https://github.com/bitcoin/bitcoin/compare/c9bfd298be422de7e989fe244fb4281c507068a3..301116e85540e49c27473f450fc210b702db4cf5).

💬 trevarj commented on pull request "guix: Use UCRT runtime for Windows release binaries":
(https://github.com/bitcoin/bitcoin/pull/33593#issuecomment-3429494296)
https://codeberg.org/guix/guix/pulls/3727

🤔 cedwies reviewed a pull request: "refactor: optimize: reuse containers in transaction policy verification"
(https://github.com/bitcoin/bitcoin/pull/33645#pullrequestreview-3362906716)
Concept ACK

- reusing vector capacity across loop iterations is makes sense
- no functional or policy logic changes introduced
- Code refactoring (range-based loops, variable renames) improves readability

Here is my bench on MacOS M2 MAX:

**Before:**
| ns/op | op/s | err% | total | benchmark
|--------------------:|--------------------:|--------:|----------:|:----------
| 134,805.18 | 7,418.11 | 0.7% | 3.30 | `AssembleBlock`
|
...

💬 cedwies commented on pull request "refactor: optimize: reuse containers in transaction policy verification":
(https://github.com/bitcoin/bitcoin/pull/33645#discussion_r2449841418)
Just double checking: `vSolutions.clear();` is intentional despite `Solver(...)` already clearing `vSolutions`? For me, I think it's good to keep.

⚠️ carlyluminattinetprise-code opened an issue: "Bitcoin"
(https://github.com/bitcoin/bitcoin/issues/33673)
### Please describe the feature you'd like to see added.

Bitcoin Core

### Is your feature related to a problem, if so please describe it.

_No response_

### Describe the solution you'd like

_No response_

### Describe any alternatives you've considered

_No response_

### Please leave any additional context

_No response_

✅ pinheadmz closed an issue: "Bitcoin"
(https://github.com/bitcoin/bitcoin/issues/33673)

💬 instagibbs commented on pull request "p2p: Drop unsolicited CMPCTBLOCK from non-HB peer":
(https://github.com/bitcoin/bitcoin/pull/32606#issuecomment-3430679733)
concept ACK