💬 stringintech commented on pull request "kernel: Introduce C header API":
(https://github.com/bitcoin/bitcoin/pull/30595#discussion_r2448844008)
nit
```suggestion
Logger logger{std::make_unique<TestLog>(), logging_options};
Logger logger_2{std::make_unique<TestLog>(), logging_options};
}
Logger logger{std::make_unique<TestLog>(), logging_options};
```

💬 stringintech commented on pull request "kernel: Introduce C header API":
(https://github.com/bitcoin/bitcoin/pull/30595#discussion_r2447873419)
Seems options are set globally. Wouldn't it be better to have a separate `btck_logging_set_options()` function? Keeping it as a param in `btck_logging_connection_create()` suggests it is set for the connection instance.

💬 maflcko commented on issue "fuzz: Fix stability, determinism issues":
(https://github.com/bitcoin/bitcoin/issues/29018#issuecomment-3427502588)
> edit: oss-fuzz link https://oss-fuzz.com/fuzzer-stats?group_by=by-fuzzer&fuzzer=afl&job=afl_asan_bitcoin-core&project=bitcoin-core

Currently the link just returns a stability of 100 for all fuzz targets, so something is probably off at the oss-fuzz side.

💬 kevkevinpal commented on pull request "ci: add Valgrind fuzz":
(https://github.com/bitcoin/bitcoin/pull/33461#issuecomment-3427528357)
ACK [c020ae0](https://github.com/bitcoin/bitcoin/pull/33461/commits/c020ae082664438cf340cb196fc5bd0d31ed810f)

I agree with @dergoegge. Given the fact that it did find an issue, I think it's worth running.

📝 maflcko opened a pull request: "test: Use unassigned p2p_port instead of hardcoded 60000 in p2p_i2p_ports.py"
(https://github.com/bitcoin/bitcoin/pull/33670)
The goal is to fix https://github.com/bitcoin/bitcoin/issues/30030.

The root cause it unclear. However, hard-coding the port to 60000 does not seem ideal anyway. This could break in an unlikely setting where so many functional tests are run, such that the port is occupied. Also, it could fail when `TEST_RUNNER_PORT_MIN` is set sufficiently high.

So fix those issues (and hopefully also 30030) by using an unoccupied p2p_port.

The logic is similar to the `extra_port()` logic in the `featur
...

👍 laanwj approved a pull request: "[IBD] precalculate SipHash constant salt XORs"
(https://github.com/bitcoin/bitcoin/pull/30442#pullrequestreview-3361685613)
Code review ACK 89bbbbd257063118e6968c409e52632835b76ce8

💬 andrewtoth commented on pull request "validation: fetch block inputs on parallel threads >10% faster IBD":
(https://github.com/bitcoin/bitcoin/pull/31132#issuecomment-3427748120)
Thank you for your review @l0rinc!

> I love the new structure, it's a lot easier to track the progress compared to previous versions. It's also measurably faster than previous versions, we seem to be nearing ~20% - sweeeet!

:rocket:

> we can make this as simple and useful as possible

What else do you have in mind for this being useful? It has a very focused purpose in my view. I would love to make it as simple as possible.

> using barriers

Done :)

> filtering and sorting bef
...

📝 ajtowns opened a pull request: "[wip] wallet: Add separate balance info for non-mempool wallet txs"
(https://github.com/bitcoin/bitcoin/pull/33671)
Changes `getbalances` to report the balance of outputs for transactions that aren't confirmed nor in the mempool (eg due to being part of too long a mempool chain, or spending non-standard outputs, or having a datacarrier output that exceeds `-datacarriersize`, etc)

```
$ bitcoin-cli -regtest getbalances
{
"mine": {
"trusted": 5764.96604310,
"untrusted_pending": 0.00000000,
"immature": 3325.00009446,
"nonmempool": 19.99995580
},
"lastprocessedblock": {
"has
...

💬 rkrux commented on pull request "wallet: refactor to remove redundant sighash calculation":
(https://github.com/bitcoin/bitcoin/pull/33665#issuecomment-3427816798)
Pushed the second commit to fix the fuzz test failures.

👋 rkrux's pull request is ready for review: "wallet: refactor to remove redundant sighash calculation"
(https://github.com/bitcoin/bitcoin/pull/33665)

💬 ajtowns commented on pull request "[wip] wallet: Add separate balance info for non-mempool wallet txs":
(https://github.com/bitcoin/bitcoin/pull/33671#issuecomment-3427837874)
Relevant for #29415 -- private relay of our wallet transactions would create spends that weren't in the mempool and would thus disappear mysteriously from the wallet balance which seems unacceptable. I think I've seen similar behaviour when doing lots of consolidations of my signet wallet, which has also been disturbing.

Perhaps see #11020 for a similar previous attempt.

This PR currently doesn't include tests that this works sensibly for nonzero nonmempool balances, hence wip/draft.

💬 hebasto commented on pull request "CMake: Add dynamic test discovery":
(https://github.com/bitcoin/bitcoin/pull/33483#issuecomment-3428571662)
Concept ACK.

💬 hebasto commented on pull request "CMake: Add dynamic test discovery":
(https://github.com/bitcoin/bitcoin/pull/33483#discussion_r2449351716)
Why is this needed?

📝 ilkinsufi opened a pull request: "qt: Increase tooltip wrap threshold from 80 to 100 characters"
(https://github.com/bitcoin/bitcoin/pull/33672)
## Summary
This PR increases the tooltip wrap threshold from 80 to 100 characters to improve user experience.

## Changes
- Modified `TOOLTIP_WRAP_THRESHOLD` constant in `src/qt/guiconstants.h`
- Changed value from 80 to 100 characters

## Rationale
The previous threshold of 80 characters was too restrictive for modern displays and longer descriptive tooltips. This change allows more content to be displayed before tooltips are converted to rich text format.

## Testing
- No linter err
...

💬 hebasto commented on pull request "qt: Increase tooltip wrap threshold from 80 to 100 characters":
(https://github.com/bitcoin/bitcoin/pull/33672#issuecomment-3428797618)
Please move this PR to the GUI repo: https://github.com/bitcoin-core/gui/pulls.

✅ ilkinsufi closed a pull request: "qt: Increase tooltip wrap threshold from 80 to 100 characters"
(https://github.com/bitcoin/bitcoin/pull/33672)

📝 ilkinsufi opened a pull request: "qt: Increase tooltip wrap threshold from 80 to 100 characters"
(https://github.com/bitcoin-core/gui/pull/905)
## Summary
This PR increases the tooltip wrap threshold from 80 to 100 characters to improve user experience.

## Changes
- Modified `TOOLTIP_WRAP_THRESHOLD` constant in `src/qt/guiconstants.h`
- Changed value from 80 to 100 characters

## Rationale
The previous threshold of 80 characters was too restrictive for modern displays and longer descriptive tooltips. This change allows more content to be displayed before tooltips are converted to rich text format.

## Testing
- No linter err
...

🤔 hebasto reviewed a pull request: "CMake: Add dynamic test discovery"
(https://github.com/bitcoin/bitcoin/pull/33483#pullrequestreview-3362343633)
The following comments no longer seem needed:https://github.com/bitcoin/bitcoin/blob/2bedad455934c9b407329d0bf58521cf24510465/src/test/CMakeLists.txt#L7-L8 https://github.com/bitcoin/bitcoin/blob/2bedad455934c9b407329d0bf58521cf24510465/src/wallet/test/CMakeLists.txt#L5-L6

💬 trevarj commented on pull request "guix: Use UCRT runtime for Windows release binaries":
(https://github.com/bitcoin/bitcoin/pull/33593#issuecomment-3429226876)
I could submit an upstream Guix patch for this. It will help with build times since the package with ucrt will be in the main substitute servers.

💬 romanz commented on pull request "rest: allow reading partial block data from storage":
(https://github.com/bitcoin/bitcoin/pull/33657#discussion_r2449615816)
Added in [c9bfd298be..301116e855](https://github.com/bitcoin/bitcoin/compare/c9bfd298be422de7e989fe244fb4281c507068a3..301116e85540e49c27473f450fc210b702db4cf5).