✅ willcl-ark closed an issue: "Allow creating and injecting a custom coinbase into a block template"
(https://github.com/bitcoin/bitcoin/issues/28475)

💬 willcl-ark commented on issue "Allow creating and injecting a custom coinbase into a block template":
(https://github.com/bitcoin/bitcoin/issues/28475#issuecomment-3427198007)
This issue hasn’t attracted much interest from other contributors in quite some time.

Given that, it doesn’t seem important enough to keep open indefinitely. I’m going to close it for now due to lack of activity, but pull requests or renewed discussion are always welcome.

Comment here if you think this should be re-opened.

💬 maflcko commented on issue "ci: Where to run heavy and fragile CI tasks?":
(https://github.com/bitcoin/bitcoin/issues/33668#issuecomment-3427202876)
Good point that if the only issue is the CPU usage, it could be fixed by more CPU. Though, stuff like msan on -O0 is so heavy that it doesn't pass at all on the GHA provided VM after 6 hours, so it will likely be slow enough to not make sense on pull requests at all.

✅ willcl-ark closed an issue: "Bitcoin OpenRPC Specification"
(https://github.com/bitcoin/bitcoin/issues/29477)

💬 willcl-ark commented on issue "Bitcoin OpenRPC Specification":
(https://github.com/bitcoin/bitcoin/issues/29477#issuecomment-3427216236)
Closing this one in favour of #29912. Please continue discussion of this topic there.

✅ willcl-ark closed an issue: "Porting bcc tools to libbpf"
(https://github.com/bitcoin/bitcoin/issues/30298)

💬 willcl-ark commented on issue "Porting bcc tools to libbpf":
(https://github.com/bitcoin/bitcoin/issues/30298#issuecomment-3427237510)
This issue hasn’t attracted much interest from other contributors in some time.

Given that, it doesn’t seem important enough to keep open indefinitely. I’m going to close it for now due to lack of activity, but pull requests or renewed discussion are always welcome.

Comment here if you think this should be re-opened.

✅ maflcko closed an issue: "Test Framework - test_framework.test_node.FailedToStartError: No RPC credentials"
(https://github.com/bitcoin/bitcoin/issues/30818)

💬 maflcko commented on issue "Test Framework - test_framework.test_node.FailedToStartError: No RPC credentials":
(https://github.com/bitcoin/bitcoin/issues/30818#issuecomment-3427239821)
> I presume adding support for tests directly on Windows is easier (or adding documentation on how to do it).

This is done in the CI now. See:

https://github.com/bitcoin/bitcoin/blob/c862936d16a640690ef4c89456738fe4bb99be54/.github/workflows/ci.yml#L382-L443

The basic idea is that you re-write the `test/config.ini` file.

✅ willcl-ark closed an issue: "Doc: Consolidate documentation of functional test parameters."
(https://github.com/bitcoin/bitcoin/issues/17380)

💬 willcl-ark commented on issue "Doc: Consolidate documentation of functional test parameters.":
(https://github.com/bitcoin/bitcoin/issues/17380#issuecomment-3427241149)
This issue hasn’t attracted much interest from other contributors in quite some time.

Given that, it doesn’t seem important enough to keep open indefinitely. I’m going to close it for now due to lack of activity, but pull requests or renewed discussion are always welcome.

Comment here if you think this should be re-opened.

✅ willcl-ark closed an issue: "CI: Make failure message easier to spot"
(https://github.com/bitcoin/bitcoin/issues/31200)

💬 willcl-ark commented on issue "CI: Make failure message easier to spot":
(https://github.com/bitcoin/bitcoin/issues/31200#issuecomment-3427249269)
It looks like this issue has been resolved. If that’s not the case, please let us know by commenting here or opening a new issue.

✅ willcl-ark closed an issue: "qa: `PermissionError` in functional tests on Windows"
(https://github.com/bitcoin/bitcoin/issues/28529)

💬 willcl-ark commented on issue "qa: `PermissionError` in functional tests on Windows":
(https://github.com/bitcoin/bitcoin/issues/28529#issuecomment-3427255585)
Since the problem isn’t easily reproducible, I’m closing this for now. If it occurs again, please feel free to open a new issue or comment here so we can reopen it.

💬 TheCharlatan commented on pull request "Add libbitcoinkernel example files":
(https://github.com/bitcoin/bitcoin/pull/33669#issuecomment-3427265866)
Concept ACK

I have something similar over at http://thecharlatan.ch/kernel-docs/examples.html . Purplelkarrot also suggested to have code examples in the style of https://purplekarrot.github.io/btck/design/naming_conventions.html (at the bottom). The tabbed views between the languages look particularly nice imo. I am not sure if we should host this in this repo though. We discussed having a separate repo (under the bitcoin-core org) to host language bindings, examples, and docs in a coherent
...

💬 BenWestgate commented on pull request "doc: update multisig tutorial to use multipath descriptors":
(https://github.com/bitcoin/bitcoin/pull/33286#issuecomment-3427270530)
> This isn't quite true for multipath descriptors:
>
> > The checksum for a descriptor without one...**
>
> We have to take the `checksum` field and append it to the multipath input descriptor, similar to private key descriptors.
>
> Do we need to document this?

Resolved my own concerns with: https://github.com/bitcoin/bitcoin/pull/33286/commits/de7c3587cd4586bbed94a4ea6eae4a252301daee

✅ willcl-ark closed an issue: "RFC: hosting utxo snapshot on bitcoincore.org and linking to it"
(https://github.com/bitcoin/bitcoin/issues/31972)

💬 willcl-ark commented on issue "RFC: hosting utxo snapshot on bitcoincore.org and linking to it":
(https://github.com/bitcoin/bitcoin/issues/31972#issuecomment-3427285688)
This is being discussed on the website repo.

💬 l0rinc commented on pull request "validation: fetch block inputs on parallel threads >10% faster IBD":
(https://github.com/bitcoin/bitcoin/pull/31132#issuecomment-3427287178)
I love the new structure, it's a lot easier to track the progress compared to previous versions. It's also measurably faster than previous versions, we seem to be nearing ~20% - sweeeet! It also pairs well with other `Siphash` related changes that are in the pipeline.

I have reimplemented most of it locally to make sure I can do a meaningful review, see https://github.com/l0rinc/bitcoin/pull/47 for my attempt. It's not finished, I'm still experimenting with different alternatives to make sure
...