💬 ajtowns commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#issuecomment-3427086681)
Concept ACK as per https://github.com/bitcoin/bitcoin/pull/27509#issuecomment-1523087063
Not sure the internal implementation around `BroadcastTransaction()` fully makes sense -- I could see `BroadcastTransaction()` having the knowledge of how transactions should be broadcast being better than having every caller of it specify it. If that means we need to prioritise fixing #11887 so that we can do this for wallet transactions straight away, that doesn't seem like a bad thing. Not doing this f
...
(https://github.com/bitcoin/bitcoin/pull/29415#issuecomment-3427086681)
Concept ACK as per https://github.com/bitcoin/bitcoin/pull/27509#issuecomment-1523087063
Not sure the internal implementation around `BroadcastTransaction()` fully makes sense -- I could see `BroadcastTransaction()` having the knowledge of how transactions should be broadcast being better than having every caller of it specify it. If that means we need to prioritise fixing #11887 so that we can do this for wallet transactions straight away, that doesn't seem like a bad thing. Not doing this f
...
✅ willcl-ark closed an issue: "Improve deadlock detection"
(https://github.com/bitcoin/bitcoin/issues/19157)
(https://github.com/bitcoin/bitcoin/issues/19157)
💬 willcl-ark commented on issue "Improve deadlock detection":
(https://github.com/bitcoin/bitcoin/issues/19157#issuecomment-3427107551)
This issue hasn’t attracted much interest from other contributors in quite some time.
Given that, it doesn’t seem important enough to keep open indefinitely. I’m going to close it for now due to lack of activity, but pull requests or renewed discussion are always welcome.
Comment here if you think this should be re-opened.
(https://github.com/bitcoin/bitcoin/issues/19157#issuecomment-3427107551)
This issue hasn’t attracted much interest from other contributors in quite some time.
Given that, it doesn’t seem important enough to keep open indefinitely. I’m going to close it for now due to lack of activity, but pull requests or renewed discussion are always welcome.
Comment here if you think this should be re-opened.
💬 kevkevinpal commented on pull request "ci: Drop libFuzzer from msan fuzz task":
(https://github.com/bitcoin/bitcoin/pull/33666#issuecomment-3427109226)
ACK [fa70e23](https://github.com/bitcoin/bitcoin/pull/33666/commits/fa70e23de75baaf8c1ef6836ffe8ca73562c8937)
I've seen false positives before from the msan fuzz task before it makes sense to disable it for now till we find the root cause of the false positives.
---
In this doc it mentions that the maintainers moved on to another project "centipede". Is there any motivation to try and support this in Bitcoin Core?
> libFuzzer is mostly unmaintained (https://llvm.org/docs/LibFuzzer.ht
...
(https://github.com/bitcoin/bitcoin/pull/33666#issuecomment-3427109226)
ACK [fa70e23](https://github.com/bitcoin/bitcoin/pull/33666/commits/fa70e23de75baaf8c1ef6836ffe8ca73562c8937)
I've seen false positives before from the msan fuzz task before it makes sense to disable it for now till we find the root cause of the false positives.
---
In this doc it mentions that the maintainers moved on to another project "centipede". Is there any motivation to try and support this in Bitcoin Core?
> libFuzzer is mostly unmaintained (https://llvm.org/docs/LibFuzzer.ht
...
✅ willcl-ark closed an issue: "listreceivedbyaddress incorrectly shows watchonly addresses as empty"
(https://github.com/bitcoin/bitcoin/issues/10468)
(https://github.com/bitcoin/bitcoin/issues/10468)
💬 willcl-ark commented on issue "listreceivedbyaddress incorrectly shows watchonly addresses as empty":
(https://github.com/bitcoin/bitcoin/issues/10468#issuecomment-3427116127)
It looks like this issue has been resolved by the descriptor wallet. If that’s not the case, please let us know by commenting here or opening a new issue.
(https://github.com/bitcoin/bitcoin/issues/10468#issuecomment-3427116127)
It looks like this issue has been resolved by the descriptor wallet. If that’s not the case, please let us know by commenting here or opening a new issue.
💬 willcl-ark commented on issue "wallet: don't back-date locktime when spending unconfirmed UTXOs":
(https://github.com/bitcoin/bitcoin/issues/26527#issuecomment-3427140546)
@danielabrozzoni you might like to take a look here and #26526?
(https://github.com/bitcoin/bitcoin/issues/26527#issuecomment-3427140546)
@danielabrozzoni you might like to take a look here and #26526?
💬 maflcko commented on pull request "ci: Drop libFuzzer from msan fuzz task":
(https://github.com/bitcoin/bitcoin/pull/33666#issuecomment-3427142600)
> centipede
Yes, it would be nice to support it, but at least I couldn't get it running. At least inside oss-fuzz, see also https://github.com/google/oss-fuzz/issues/10434
(https://github.com/bitcoin/bitcoin/pull/33666#issuecomment-3427142600)
> centipede
Yes, it would be nice to support it, but at least I couldn't get it running. At least inside oss-fuzz, see also https://github.com/google/oss-fuzz/issues/10434
✅ willcl-ark closed an issue: "Simpler settings interpretation"
(https://github.com/bitcoin/bitcoin/issues/17508)
(https://github.com/bitcoin/bitcoin/issues/17508)
💬 willcl-ark commented on issue "Simpler settings interpretation":
(https://github.com/bitcoin/bitcoin/issues/17508#issuecomment-3427148415)
Closing this as it hasn’t seen any activity for a while. If you’d like to continue the discussion or feel the topic is still important, please leave a comment and we can reopen it.
(https://github.com/bitcoin/bitcoin/issues/17508#issuecomment-3427148415)
Closing this as it hasn’t seen any activity for a while. If you’d like to continue the discussion or feel the topic is still important, please leave a comment and we can reopen it.
✅ willcl-ark closed an issue: "contrib: add symbol-check test for non-existence of `vmova` instructions in Windows build"
(https://github.com/bitcoin/bitcoin/issues/28413)
(https://github.com/bitcoin/bitcoin/issues/28413)
💬 willcl-ark commented on issue "contrib: add symbol-check test for non-existence of `vmova` instructions in Windows build":
(https://github.com/bitcoin/bitcoin/issues/28413#issuecomment-3427183919)
It looks like this issue has been resolved. If that’s not the case, please let us know by commenting here or opening a new issue.
(https://github.com/bitcoin/bitcoin/issues/28413#issuecomment-3427183919)
It looks like this issue has been resolved. If that’s not the case, please let us know by commenting here or opening a new issue.
✅ willcl-ark closed an issue: "Allow creating and injecting a custom coinbase into a block template"
(https://github.com/bitcoin/bitcoin/issues/28475)
(https://github.com/bitcoin/bitcoin/issues/28475)
💬 willcl-ark commented on issue "Allow creating and injecting a custom coinbase into a block template":
(https://github.com/bitcoin/bitcoin/issues/28475#issuecomment-3427198007)
This issue hasn’t attracted much interest from other contributors in quite some time.
Given that, it doesn’t seem important enough to keep open indefinitely. I’m going to close it for now due to lack of activity, but pull requests or renewed discussion are always welcome.
Comment here if you think this should be re-opened.
(https://github.com/bitcoin/bitcoin/issues/28475#issuecomment-3427198007)
This issue hasn’t attracted much interest from other contributors in quite some time.
Given that, it doesn’t seem important enough to keep open indefinitely. I’m going to close it for now due to lack of activity, but pull requests or renewed discussion are always welcome.
Comment here if you think this should be re-opened.
💬 maflcko commented on issue "ci: Where to run heavy and fragile CI tasks?":
(https://github.com/bitcoin/bitcoin/issues/33668#issuecomment-3427202876)
Good point that if the only issue is the CPU usage, it could be fixed by more CPU. Though, stuff like msan on -O0 is so heavy that it doesn't pass at all on the GHA provided VM after 6 hours, so it will likely be slow enough to not make sense on pull requests at all.
(https://github.com/bitcoin/bitcoin/issues/33668#issuecomment-3427202876)
Good point that if the only issue is the CPU usage, it could be fixed by more CPU. Though, stuff like msan on -O0 is so heavy that it doesn't pass at all on the GHA provided VM after 6 hours, so it will likely be slow enough to not make sense on pull requests at all.
✅ willcl-ark closed an issue: "Bitcoin OpenRPC Specification"
(https://github.com/bitcoin/bitcoin/issues/29477)
(https://github.com/bitcoin/bitcoin/issues/29477)
💬 willcl-ark commented on issue "Bitcoin OpenRPC Specification":
(https://github.com/bitcoin/bitcoin/issues/29477#issuecomment-3427216236)
Closing this one in favour of #29912. Please continue discussion of this topic there.
(https://github.com/bitcoin/bitcoin/issues/29477#issuecomment-3427216236)
Closing this one in favour of #29912. Please continue discussion of this topic there.
✅ willcl-ark closed an issue: "Porting bcc tools to libbpf"
(https://github.com/bitcoin/bitcoin/issues/30298)
(https://github.com/bitcoin/bitcoin/issues/30298)
💬 willcl-ark commented on issue "Porting bcc tools to libbpf":
(https://github.com/bitcoin/bitcoin/issues/30298#issuecomment-3427237510)
This issue hasn’t attracted much interest from other contributors in some time.
Given that, it doesn’t seem important enough to keep open indefinitely. I’m going to close it for now due to lack of activity, but pull requests or renewed discussion are always welcome.
Comment here if you think this should be re-opened.
(https://github.com/bitcoin/bitcoin/issues/30298#issuecomment-3427237510)
This issue hasn’t attracted much interest from other contributors in some time.
Given that, it doesn’t seem important enough to keep open indefinitely. I’m going to close it for now due to lack of activity, but pull requests or renewed discussion are always welcome.
Comment here if you think this should be re-opened.
✅ maflcko closed an issue: "Test Framework - test_framework.test_node.FailedToStartError: No RPC credentials"
(https://github.com/bitcoin/bitcoin/issues/30818)
(https://github.com/bitcoin/bitcoin/issues/30818)