💬 maflcko commented on pull request "ci: re-add Valgrind job to the CI":
(https://github.com/bitcoin/bitcoin/pull/33411#issuecomment-3427032925)
Maybe we can add it to just run under the default branch (master) on merges? Brought up in the context of https://github.com/bitcoin/bitcoin/pull/33509#issuecomment-3381737041, but i guess the same approach could be used for several tasks? Maybe a brainstorming issue?
(https://github.com/bitcoin/bitcoin/pull/33411#issuecomment-3427032925)
Maybe we can add it to just run under the default branch (master) on merges? Brought up in the context of https://github.com/bitcoin/bitcoin/pull/33509#issuecomment-3381737041, but i guess the same approach could be used for several tasks? Maybe a brainstorming issue?
💬 willcl-ark commented on issue "possible corruption: missing undo file":
(https://github.com/bitcoin/bitcoin/issues/25539#issuecomment-3427036224)
Would you like to have a look here @l0rinc?
(https://github.com/bitcoin/bitcoin/issues/25539#issuecomment-3427036224)
Would you like to have a look here @l0rinc?
💬 fanquake commented on pull request "doc: add AGENTS.md":
(https://github.com/bitcoin/bitcoin/pull/33662#issuecomment-3427046486)
~0 doesn't seem like something we need to do. Would conflict with anyone using a .gitignored `agents.md` locally?
(https://github.com/bitcoin/bitcoin/pull/33662#issuecomment-3427046486)
~0 doesn't seem like something we need to do. Would conflict with anyone using a .gitignored `agents.md` locally?
✅ willcl-ark closed an issue: "FILES section for man pages"
(https://github.com/bitcoin/bitcoin/issues/29557)
(https://github.com/bitcoin/bitcoin/issues/29557)
💬 willcl-ark commented on issue "FILES section for man pages":
(https://github.com/bitcoin/bitcoin/issues/29557#issuecomment-3427047377)
This issue hasn’t attracted much interest from other contributors in quite some time.
Given that, it doesn’t seem important enough to keep open indefinitely. I’m going to close it for now due to lack of activity, but pull requests or renewed discussion are always welcome.
Comment here if you think this shoudl be re-opened.
(https://github.com/bitcoin/bitcoin/issues/29557#issuecomment-3427047377)
This issue hasn’t attracted much interest from other contributors in quite some time.
Given that, it doesn’t seem important enough to keep open indefinitely. I’m going to close it for now due to lack of activity, but pull requests or renewed discussion are always welcome.
Comment here if you think this shoudl be re-opened.
💬 glozow commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2448612169)
I prefer a squash but up to you.
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2448612169)
I prefer a squash but up to you.
✅ willcl-ark closed an issue: "listsinceblock incorrectly showing some conflicted transactions"
(https://github.com/bitcoin/bitcoin/issues/10656)
(https://github.com/bitcoin/bitcoin/issues/10656)
💬 willcl-ark commented on issue "listsinceblock incorrectly showing some conflicted transactions":
(https://github.com/bitcoin/bitcoin/issues/10656#issuecomment-3427053627)
This issue hasn’t attracted much interest from other contributors in quite some time.
Given that, it doesn’t seem important enough to keep open indefinitely. I’m going to close it for now due to lack of activity, but pull requests or renewed discussion are always welcome.
Comment here if you think this should be re-opened.
(https://github.com/bitcoin/bitcoin/issues/10656#issuecomment-3427053627)
This issue hasn’t attracted much interest from other contributors in quite some time.
Given that, it doesn’t seem important enough to keep open indefinitely. I’m going to close it for now due to lack of activity, but pull requests or renewed discussion are always welcome.
Comment here if you think this should be re-opened.
⚠️ maflcko opened an issue: "ci: Where to run heavy and fragile CI tasks?"
(https://github.com/bitcoin/bitcoin/issues/33668)
There are some heavy, and some possibly fragile CI configs, which may not be productive to run on every pull request. They could be run on just the master branch for every merge?
Come up in the context of:
* https://github.com/bitcoin/bitcoin/pull/33509#issuecomment-3381737041
* https://github.com/bitcoin/bitcoin/issues/33411#issuecomment-3427032925
And possibly useful for https://github.com/bitcoin/bitcoin/issues/22064#issuecomment-2607120689
(https://github.com/bitcoin/bitcoin/issues/33668)
There are some heavy, and some possibly fragile CI configs, which may not be productive to run on every pull request. They could be run on just the master branch for every merge?
Come up in the context of:
* https://github.com/bitcoin/bitcoin/pull/33509#issuecomment-3381737041
* https://github.com/bitcoin/bitcoin/issues/33411#issuecomment-3427032925
And possibly useful for https://github.com/bitcoin/bitcoin/issues/22064#issuecomment-2607120689
📝 w0xlt opened a pull request: "Add libbitcoinkernel example files"
(https://github.com/bitcoin/bitcoin/pull/33669)
Many Bitcoin-related libraries (like secp256k1 itself and other Bitcoin Rust crates) have a folder with example files as reference on how to properly use the library,
They are particularly useful since it instructs the user and reduces the necessity to look for external documentation.
This PR proposes same approach for libbitcoinkernel.
For now, I've just added 2 examples for the C library (not C++ wrapper) to gather feedback. In positive case, more examples can be added in this PR.
...
(https://github.com/bitcoin/bitcoin/pull/33669)
Many Bitcoin-related libraries (like secp256k1 itself and other Bitcoin Rust crates) have a folder with example files as reference on how to properly use the library,
They are particularly useful since it instructs the user and reduces the necessity to look for external documentation.
This PR proposes same approach for libbitcoinkernel.
For now, I've just added 2 examples for the C library (not C++ wrapper) to gather feedback. In positive case, more examples can be added in this PR.
...
📝 w0xlt converted_to_draft a pull request: "Add libbitcoinkernel example files"
(https://github.com/bitcoin/bitcoin/pull/33669)
Many Bitcoin-related libraries (like secp256k1 itself and other Bitcoin Rust crates) have a folder with example files as reference on how to properly use the library,
They are particularly useful since it instructs the user and reduces the necessity to look for external documentation.
This PR proposes same approach for libbitcoinkernel.
For now, I've just added 2 examples for the C library (not C++ wrapper) to gather feedback. In positive case, more examples can be added in this PR.
...
(https://github.com/bitcoin/bitcoin/pull/33669)
Many Bitcoin-related libraries (like secp256k1 itself and other Bitcoin Rust crates) have a folder with example files as reference on how to properly use the library,
They are particularly useful since it instructs the user and reduces the necessity to look for external documentation.
This PR proposes same approach for libbitcoinkernel.
For now, I've just added 2 examples for the C library (not C++ wrapper) to gather feedback. In positive case, more examples can be added in this PR.
...
✅ willcl-ark closed an issue: "Comply with the XDG Base Directory Specification"
(https://github.com/bitcoin/bitcoin/issues/16733)
(https://github.com/bitcoin/bitcoin/issues/16733)
💬 willcl-ark commented on issue "Comply with the XDG Base Directory Specification":
(https://github.com/bitcoin/bitcoin/issues/16733#issuecomment-3427078481)
This issue hasn’t attracted much interest from other contributors in quite some time.
Given that, it doesn’t seem important enough to keep open indefinitely. I’m going to close it for now due to lack of activity, but pull requests or renewed discussion are always welcome.
Comment here if you think this should be re-opened.
(https://github.com/bitcoin/bitcoin/issues/16733#issuecomment-3427078481)
This issue hasn’t attracted much interest from other contributors in quite some time.
Given that, it doesn’t seem important enough to keep open indefinitely. I’m going to close it for now due to lack of activity, but pull requests or renewed discussion are always welcome.
Comment here if you think this should be re-opened.
✅ willcl-ark closed an issue: "Use sigstore software transparency for releases"
(https://github.com/bitcoin/bitcoin/issues/21524)
(https://github.com/bitcoin/bitcoin/issues/21524)
💬 willcl-ark commented on issue "Use sigstore software transparency for releases":
(https://github.com/bitcoin/bitcoin/issues/21524#issuecomment-3427082843)
This issue hasn’t attracted much interest from other contributors in quite some time.
Given that, it doesn’t seem important enough to keep open indefinitely. I’m going to close it for now due to lack of activity, but pull requests or renewed discussion are always welcome.
Comment here if you think this should be re-opened.
(https://github.com/bitcoin/bitcoin/issues/21524#issuecomment-3427082843)
This issue hasn’t attracted much interest from other contributors in quite some time.
Given that, it doesn’t seem important enough to keep open indefinitely. I’m going to close it for now due to lack of activity, but pull requests or renewed discussion are always welcome.
Comment here if you think this should be re-opened.
💬 fanquake commented on issue "ci: Where to run heavy and fragile CI tasks?":
(https://github.com/bitcoin/bitcoin/issues/33668#issuecomment-3427083457)
I don't really think "heavy" should be as much of a blocker as fragile here. There should be scope to expand the amount of CPU dedicated to the CI.
(https://github.com/bitcoin/bitcoin/issues/33668#issuecomment-3427083457)
I don't really think "heavy" should be as much of a blocker as fragile here. There should be scope to expand the amount of CPU dedicated to the CI.
💬 ajtowns commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#issuecomment-3427086681)
Concept ACK as per https://github.com/bitcoin/bitcoin/pull/27509#issuecomment-1523087063
Not sure the internal implementation around `BroadcastTransaction()` fully makes sense -- I could see `BroadcastTransaction()` having the knowledge of how transactions should be broadcast being better than having every caller of it specify it. If that means we need to prioritise fixing #11887 so that we can do this for wallet transactions straight away, that doesn't seem like a bad thing. Not doing this f
...
(https://github.com/bitcoin/bitcoin/pull/29415#issuecomment-3427086681)
Concept ACK as per https://github.com/bitcoin/bitcoin/pull/27509#issuecomment-1523087063
Not sure the internal implementation around `BroadcastTransaction()` fully makes sense -- I could see `BroadcastTransaction()` having the knowledge of how transactions should be broadcast being better than having every caller of it specify it. If that means we need to prioritise fixing #11887 so that we can do this for wallet transactions straight away, that doesn't seem like a bad thing. Not doing this f
...
✅ willcl-ark closed an issue: "Improve deadlock detection"
(https://github.com/bitcoin/bitcoin/issues/19157)
(https://github.com/bitcoin/bitcoin/issues/19157)
💬 willcl-ark commented on issue "Improve deadlock detection":
(https://github.com/bitcoin/bitcoin/issues/19157#issuecomment-3427107551)
This issue hasn’t attracted much interest from other contributors in quite some time.
Given that, it doesn’t seem important enough to keep open indefinitely. I’m going to close it for now due to lack of activity, but pull requests or renewed discussion are always welcome.
Comment here if you think this should be re-opened.
(https://github.com/bitcoin/bitcoin/issues/19157#issuecomment-3427107551)
This issue hasn’t attracted much interest from other contributors in quite some time.
Given that, it doesn’t seem important enough to keep open indefinitely. I’m going to close it for now due to lack of activity, but pull requests or renewed discussion are always welcome.
Comment here if you think this should be re-opened.
💬 kevkevinpal commented on pull request "ci: Drop libFuzzer from msan fuzz task":
(https://github.com/bitcoin/bitcoin/pull/33666#issuecomment-3427109226)
ACK [fa70e23](https://github.com/bitcoin/bitcoin/pull/33666/commits/fa70e23de75baaf8c1ef6836ffe8ca73562c8937)
I've seen false positives before from the msan fuzz task before it makes sense to disable it for now till we find the root cause of the false positives.
---
In this doc it mentions that the maintainers moved on to another project "centipede". Is there any motivation to try and support this in Bitcoin Core?
> libFuzzer is mostly unmaintained (https://llvm.org/docs/LibFuzzer.ht
...
(https://github.com/bitcoin/bitcoin/pull/33666#issuecomment-3427109226)
ACK [fa70e23](https://github.com/bitcoin/bitcoin/pull/33666/commits/fa70e23de75baaf8c1ef6836ffe8ca73562c8937)
I've seen false positives before from the msan fuzz task before it makes sense to disable it for now till we find the root cause of the false positives.
---
In this doc it mentions that the maintainers moved on to another project "centipede". Is there any motivation to try and support this in Bitcoin Core?
> libFuzzer is mostly unmaintained (https://llvm.org/docs/LibFuzzer.ht
...