Bitcoin Core Github
43 subscribers
123K links
Download Telegram
πŸ’¬ sdaftuar commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2448565249)
Done.
πŸ’¬ sdaftuar commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2448566519)
Done.
βœ… willcl-ark closed an issue: "Add Labels/Groups to Output Descriptors"
(https://github.com/bitcoin/bitcoin/issues/21197)
πŸ’¬ willcl-ark commented on issue "Add Labels/Groups to Output Descriptors":
(https://github.com/bitcoin/bitcoin/issues/21197#issuecomment-3426969335)
Given that there are BIPS (38x) for this now, I think this is best discussed on the mailing list if it's still relevant.
βœ… willcl-ark closed an issue: "Call interfaces::Wallet::getWalletTxs asynchronous"
(https://github.com/bitcoin/bitcoin/issues/20241)
πŸ’¬ willcl-ark commented on issue "Call interfaces::Wallet::getWalletTxs asynchronous":
(https://github.com/bitcoin/bitcoin/issues/20241#issuecomment-3426975295)
This issue hasn’t attracted much interest from other contributors in quite some time.

Given that, it doesn’t seem important enough to keep open indefinitely. I’m going to close it for now due to lack of activity, but pull requests or renewed discussion are always welcome.

Comment here if you think this should be re-opened.
πŸ’¬ sdaftuar commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2448573573)
I took this change but I just realized that this is redundant with the first test that appears earlier in this function, right?
πŸ’¬ fanquake commented on pull request "randomenv: remove some `/proc/` accesses":
(https://github.com/bitcoin/bitcoin/pull/32450#issuecomment-3427007466)
Not going to continue working on this.
βœ… fanquake closed a pull request: "randomenv: remove some `/proc/` accesses"
(https://github.com/bitcoin/bitcoin/pull/32450)
βœ… willcl-ark closed an issue: "Use muhash for assumeUTXO snapshot "
(https://github.com/bitcoin/bitcoin/issues/27669)
πŸ’¬ willcl-ark commented on issue "Use muhash for assumeUTXO snapshot ":
(https://github.com/bitcoin/bitcoin/issues/27669#issuecomment-3427008540)
This issue hasn’t attracted much interest from other contributors in quite some time.

Given that, it doesn’t seem important enough to keep open indefinitely. I’m going to close it for now due to lack of activity, but pull requests or renewed discussion are always welcome.

Comment here if you think this should be re-opened.
βœ… fanquake closed a pull request: "ASAN: turn on more not-enabled-by-default options"
(https://github.com/bitcoin/bitcoin/pull/33180)
βœ… fanquake closed a pull request: "ci: re-add Valgrind job to the CI"
(https://github.com/bitcoin/bitcoin/pull/33411)
πŸ’¬ fanquake commented on pull request "ci: re-add Valgrind job to the CI":
(https://github.com/bitcoin/bitcoin/pull/33411#issuecomment-3427016325)
Can leave it to *san for now.
βœ… fanquake closed a pull request: "ci: add Valgrind fuzz"
(https://github.com/bitcoin/bitcoin/pull/33461)
πŸ‘‹ fanquake's pull request is ready for review: "guix: Pointer Authentication and Branch Target Identification for aarch64 Linux"
(https://github.com/bitcoin/bitcoin/pull/24123)
πŸ’¬ willcl-ark commented on issue "Witness-Only Option for fundrawtransaction":
(https://github.com/bitcoin/bitcoin/issues/25181#issuecomment-3427028015)
@TheBlueMatt is this still relevant for your use-case?
πŸš€ fanquake merged a pull request: "ci: use Mold linker for asan-lsan-ubsan-integer-no-depends-usdt workflow"
(https://github.com/bitcoin/bitcoin/pull/33370)
πŸ’¬ maflcko commented on pull request "ci: re-add Valgrind job to the CI":
(https://github.com/bitcoin/bitcoin/pull/33411#issuecomment-3427032925)
Maybe we can add it to just run under the default branch (master) on merges? Brought up in the context of https://github.com/bitcoin/bitcoin/pull/33509#issuecomment-3381737041, but i guess the same approach could be used for several tasks? Maybe a brainstorming issue?
πŸ’¬ willcl-ark commented on issue "possible corruption: missing undo file":
(https://github.com/bitcoin/bitcoin/issues/25539#issuecomment-3427036224)
Would you like to have a look here @l0rinc?