π¬ maflcko commented on pull request "ci: Only write docker build images to Cirrus cache":
(https://github.com/bitcoin/bitcoin/pull/33639#issuecomment-3426948663)
> Let's see how much slowdown this would cause without caching.
I don't think this has any measurable effect on the runtime. The only benefit could be avoiding intermittent network errors.
(https://github.com/bitcoin/bitcoin/pull/33639#issuecomment-3426948663)
> Let's see how much slowdown this would cause without caching.
I don't think this has any measurable effect on the runtime. The only benefit could be avoiding intermittent network errors.
π¬ sdaftuar commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2448553286)
Updated the commit message.
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2448553286)
Updated the commit message.
π¬ storopoli commented on pull request "doc: add AGENTS.md":
(https://github.com/bitcoin/bitcoin/pull/33662#discussion_r2448553552)
I think that the reason why Claude Sonnet 4.5 dropped the second line can be fixed with something like this (backticks broke the GH suggestion so I changed to quotes)
```suggestion
Include the following trailers on commits substantially generated with automated assistance adapting to whatever agent you are.
For example for GitHub Copilot:
> Assisted-by: GitHub Copilot
For example for Claude Code:
> Assisted-by: Claude Code
```
(https://github.com/bitcoin/bitcoin/pull/33662#discussion_r2448553552)
I think that the reason why Claude Sonnet 4.5 dropped the second line can be fixed with something like this (backticks broke the GH suggestion so I changed to quotes)
```suggestion
Include the following trailers on commits substantially generated with automated assistance adapting to whatever agent you are.
For example for GitHub Copilot:
> Assisted-by: GitHub Copilot
For example for Claude Code:
> Assisted-by: Claude Code
```
π¬ sdaftuar commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2448557208)
Done in 845ec3a3f806dee6c9ad053655fb466bd599a73d
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2448557208)
Done in 845ec3a3f806dee6c9ad053655fb466bd599a73d
π¬ sdaftuar commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2448557622)
Done.
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2448557622)
Done.
π¬ sdaftuar commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2448561421)
Implemented this change in 1ae9fd3f7a4fddc786e9921e7fc2af41ab96bf9a. Should I try to squash this into place or is this fine as its own commit?
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2448561421)
Implemented this change in 1ae9fd3f7a4fddc786e9921e7fc2af41ab96bf9a. Should I try to squash this into place or is this fine as its own commit?
π¬ sdaftuar commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2448565249)
Done.
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2448565249)
Done.
π¬ sdaftuar commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2448566519)
Done.
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2448566519)
Done.
β
willcl-ark closed an issue: "Add Labels/Groups to Output Descriptors"
(https://github.com/bitcoin/bitcoin/issues/21197)
(https://github.com/bitcoin/bitcoin/issues/21197)
π¬ willcl-ark commented on issue "Add Labels/Groups to Output Descriptors":
(https://github.com/bitcoin/bitcoin/issues/21197#issuecomment-3426969335)
Given that there are BIPS (38x) for this now, I think this is best discussed on the mailing list if it's still relevant.
(https://github.com/bitcoin/bitcoin/issues/21197#issuecomment-3426969335)
Given that there are BIPS (38x) for this now, I think this is best discussed on the mailing list if it's still relevant.
β
willcl-ark closed an issue: "Call interfaces::Wallet::getWalletTxs asynchronous"
(https://github.com/bitcoin/bitcoin/issues/20241)
(https://github.com/bitcoin/bitcoin/issues/20241)
π¬ willcl-ark commented on issue "Call interfaces::Wallet::getWalletTxs asynchronous":
(https://github.com/bitcoin/bitcoin/issues/20241#issuecomment-3426975295)
This issue hasnβt attracted much interest from other contributors in quite some time.
Given that, it doesnβt seem important enough to keep open indefinitely. Iβm going to close it for now due to lack of activity, but pull requests or renewed discussion are always welcome.
Comment here if you think this should be re-opened.
(https://github.com/bitcoin/bitcoin/issues/20241#issuecomment-3426975295)
This issue hasnβt attracted much interest from other contributors in quite some time.
Given that, it doesnβt seem important enough to keep open indefinitely. Iβm going to close it for now due to lack of activity, but pull requests or renewed discussion are always welcome.
Comment here if you think this should be re-opened.
π¬ sdaftuar commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2448573573)
I took this change but I just realized that this is redundant with the first test that appears earlier in this function, right?
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2448573573)
I took this change but I just realized that this is redundant with the first test that appears earlier in this function, right?
π¬ fanquake commented on pull request "randomenv: remove some `/proc/` accesses":
(https://github.com/bitcoin/bitcoin/pull/32450#issuecomment-3427007466)
Not going to continue working on this.
(https://github.com/bitcoin/bitcoin/pull/32450#issuecomment-3427007466)
Not going to continue working on this.
β
fanquake closed a pull request: "randomenv: remove some `/proc/` accesses"
(https://github.com/bitcoin/bitcoin/pull/32450)
(https://github.com/bitcoin/bitcoin/pull/32450)
β
willcl-ark closed an issue: "Use muhash for assumeUTXO snapshot "
(https://github.com/bitcoin/bitcoin/issues/27669)
(https://github.com/bitcoin/bitcoin/issues/27669)
π¬ willcl-ark commented on issue "Use muhash for assumeUTXO snapshot ":
(https://github.com/bitcoin/bitcoin/issues/27669#issuecomment-3427008540)
This issue hasnβt attracted much interest from other contributors in quite some time.
Given that, it doesnβt seem important enough to keep open indefinitely. Iβm going to close it for now due to lack of activity, but pull requests or renewed discussion are always welcome.
Comment here if you think this should be re-opened.
(https://github.com/bitcoin/bitcoin/issues/27669#issuecomment-3427008540)
This issue hasnβt attracted much interest from other contributors in quite some time.
Given that, it doesnβt seem important enough to keep open indefinitely. Iβm going to close it for now due to lack of activity, but pull requests or renewed discussion are always welcome.
Comment here if you think this should be re-opened.
β
fanquake closed a pull request: "ASAN: turn on more not-enabled-by-default options"
(https://github.com/bitcoin/bitcoin/pull/33180)
(https://github.com/bitcoin/bitcoin/pull/33180)
β
fanquake closed a pull request: "ci: re-add Valgrind job to the CI"
(https://github.com/bitcoin/bitcoin/pull/33411)
(https://github.com/bitcoin/bitcoin/pull/33411)
π¬ fanquake commented on pull request "ci: re-add Valgrind job to the CI":
(https://github.com/bitcoin/bitcoin/pull/33411#issuecomment-3427016325)
Can leave it to *san for now.
(https://github.com/bitcoin/bitcoin/pull/33411#issuecomment-3427016325)
Can leave it to *san for now.