Bitcoin Core Github
43 subscribers
123K links
Download Telegram
💬 willcl-ark commented on issue "untrust vs unsafe ?":
(https://github.com/bitcoin/bitcoin/issues/18625#issuecomment-3426915794)
This issue hasn’t attracted much interest from other contributors in quite some time.

Given that, it doesn’t seem important enough to keep open indefinitely. I’m going to close it for now due to lack of activity, but pull requests or renewed discussion are always welcome.

Comment here if you think this should be re-opened.
dergoegge closed an issue: "meta: Isolated fuzzing of net processing"
(https://github.com/bitcoin/bitcoin/issues/27502)
💬 dergoegge commented on issue "meta: Isolated fuzzing of net processing":
(https://github.com/bitcoin/bitcoin/issues/27502#issuecomment-3426935931)
This is still worth exploring but I'm not working on any PRs in this direction at the moment. Might pick it up again later.
willcl-ark closed an issue: "Internal bug detected: Fee needed > fee paid"
(https://github.com/bitcoin/bitcoin/issues/29398)
💬 willcl-ark commented on issue "Internal bug detected: Fee needed > fee paid":
(https://github.com/bitcoin/bitcoin/issues/29398#issuecomment-3426940674)
Since the problem isn’t easily reproducible, I’m closing this for now. If it occurs again, please feel free to open a new issue or comment here so we can reopen it.
💬 sdaftuar commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2448551580)
Fixed this in a couple of places, should be good now I think.
willcl-ark closed an issue: "Optimize CheckMultiSig by using public key recovery."
(https://github.com/bitcoin/bitcoin/issues/15621)
💬 willcl-ark commented on issue "Optimize CheckMultiSig by using public key recovery.":
(https://github.com/bitcoin/bitcoin/issues/15621#issuecomment-3426948707)
This issue hasn’t attracted much interest from other contributors in quite some time.

Given that, it doesn’t seem important enough to keep open indefinitely. I’m going to close it for now due to lack of activity, but pull requests or renewed discussion are always welcome.

Comment here if you think this should be re-opened.
💬 maflcko commented on pull request "ci: Only write docker build images to Cirrus cache":
(https://github.com/bitcoin/bitcoin/pull/33639#issuecomment-3426948663)
> Let's see how much slowdown this would cause without caching.

I don't think this has any measurable effect on the runtime. The only benefit could be avoiding intermittent network errors.
💬 sdaftuar commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2448553286)
Updated the commit message.
💬 storopoli commented on pull request "doc: add AGENTS.md":
(https://github.com/bitcoin/bitcoin/pull/33662#discussion_r2448553552)
I think that the reason why Claude Sonnet 4.5 dropped the second line can be fixed with something like this (backticks broke the GH suggestion so I changed to quotes)

```suggestion
Include the following trailers on commits substantially generated with automated assistance adapting to whatever agent you are.

For example for GitHub Copilot:

> Assisted-by: GitHub Copilot

For example for Claude Code:

> Assisted-by: Claude Code

```
💬 sdaftuar commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2448557208)
Done in 845ec3a3f806dee6c9ad053655fb466bd599a73d
💬 sdaftuar commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2448557622)
Done.
💬 sdaftuar commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2448561421)
Implemented this change in 1ae9fd3f7a4fddc786e9921e7fc2af41ab96bf9a. Should I try to squash this into place or is this fine as its own commit?
💬 sdaftuar commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2448565249)
Done.
💬 sdaftuar commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2448566519)
Done.
willcl-ark closed an issue: "Add Labels/Groups to Output Descriptors"
(https://github.com/bitcoin/bitcoin/issues/21197)
💬 willcl-ark commented on issue "Add Labels/Groups to Output Descriptors":
(https://github.com/bitcoin/bitcoin/issues/21197#issuecomment-3426969335)
Given that there are BIPS (38x) for this now, I think this is best discussed on the mailing list if it's still relevant.
willcl-ark closed an issue: "Call interfaces::Wallet::getWalletTxs asynchronous"
(https://github.com/bitcoin/bitcoin/issues/20241)
💬 willcl-ark commented on issue "Call interfaces::Wallet::getWalletTxs asynchronous":
(https://github.com/bitcoin/bitcoin/issues/20241#issuecomment-3426975295)
This issue hasn’t attracted much interest from other contributors in quite some time.

Given that, it doesn’t seem important enough to keep open indefinitely. I’m going to close it for now due to lack of activity, but pull requests or renewed discussion are always welcome.

Comment here if you think this should be re-opened.