💬 sdaftuar commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2448515450)
Done.
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2448515450)
Done.
✅ willcl-ark closed an issue: "Add `not_null<T>` from the Guidelines Support Library"
(https://github.com/bitcoin/bitcoin/issues/24423)
(https://github.com/bitcoin/bitcoin/issues/24423)
💬 willcl-ark commented on issue "Add `not_null<T>` from the Guidelines Support Library":
(https://github.com/bitcoin/bitcoin/issues/24423#issuecomment-3426906780)
This issue hasn’t attracted much interest from other contributors in quite some time.
Given that, it doesn’t seem important enough to keep open indefinitely. I’m going to close it for now due to lack of activity, but pull requests or renewed discussion are always welcome.
Comment here if you think this shoudl be re-opened.
(https://github.com/bitcoin/bitcoin/issues/24423#issuecomment-3426906780)
This issue hasn’t attracted much interest from other contributors in quite some time.
Given that, it doesn’t seem important enough to keep open indefinitely. I’m going to close it for now due to lack of activity, but pull requests or renewed discussion are always welcome.
Comment here if you think this shoudl be re-opened.
💬 maflcko commented on issue "Use of C++ undefined behavior in various `IteratorComparators`":
(https://github.com/bitcoin/bitcoin/issues/19496#issuecomment-3426907085)
This was fixed in e009bf681c0e38a6451afa594ba3c7c8861f61c3 , no?
(https://github.com/bitcoin/bitcoin/issues/19496#issuecomment-3426907085)
This was fixed in e009bf681c0e38a6451afa594ba3c7c8861f61c3 , no?
💬 sdaftuar commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2448518145)
Done.
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2448518145)
Done.
✅ willcl-ark closed an issue: "linter to check omitted fields when constructing aggregate types?"
(https://github.com/bitcoin/bitcoin/issues/25631)
(https://github.com/bitcoin/bitcoin/issues/25631)
💬 willcl-ark commented on issue "linter to check omitted fields when constructing aggregate types?":
(https://github.com/bitcoin/bitcoin/issues/25631#issuecomment-3426911817)
It looks like this issue has been resolved. If that’s not the case, please let us know by commenting here or opening a new issue.
(https://github.com/bitcoin/bitcoin/issues/25631#issuecomment-3426911817)
It looks like this issue has been resolved. If that’s not the case, please let us know by commenting here or opening a new issue.
✅ willcl-ark closed an issue: "untrust vs unsafe ?"
(https://github.com/bitcoin/bitcoin/issues/18625)
(https://github.com/bitcoin/bitcoin/issues/18625)
💬 willcl-ark commented on issue "untrust vs unsafe ?":
(https://github.com/bitcoin/bitcoin/issues/18625#issuecomment-3426915794)
This issue hasn’t attracted much interest from other contributors in quite some time.
Given that, it doesn’t seem important enough to keep open indefinitely. I’m going to close it for now due to lack of activity, but pull requests or renewed discussion are always welcome.
Comment here if you think this should be re-opened.
(https://github.com/bitcoin/bitcoin/issues/18625#issuecomment-3426915794)
This issue hasn’t attracted much interest from other contributors in quite some time.
Given that, it doesn’t seem important enough to keep open indefinitely. I’m going to close it for now due to lack of activity, but pull requests or renewed discussion are always welcome.
Comment here if you think this should be re-opened.
✅ dergoegge closed an issue: "meta: Isolated fuzzing of net processing"
(https://github.com/bitcoin/bitcoin/issues/27502)
(https://github.com/bitcoin/bitcoin/issues/27502)
💬 dergoegge commented on issue "meta: Isolated fuzzing of net processing":
(https://github.com/bitcoin/bitcoin/issues/27502#issuecomment-3426935931)
This is still worth exploring but I'm not working on any PRs in this direction at the moment. Might pick it up again later.
(https://github.com/bitcoin/bitcoin/issues/27502#issuecomment-3426935931)
This is still worth exploring but I'm not working on any PRs in this direction at the moment. Might pick it up again later.
✅ willcl-ark closed an issue: "Internal bug detected: Fee needed > fee paid"
(https://github.com/bitcoin/bitcoin/issues/29398)
(https://github.com/bitcoin/bitcoin/issues/29398)
💬 willcl-ark commented on issue "Internal bug detected: Fee needed > fee paid":
(https://github.com/bitcoin/bitcoin/issues/29398#issuecomment-3426940674)
Since the problem isn’t easily reproducible, I’m closing this for now. If it occurs again, please feel free to open a new issue or comment here so we can reopen it.
(https://github.com/bitcoin/bitcoin/issues/29398#issuecomment-3426940674)
Since the problem isn’t easily reproducible, I’m closing this for now. If it occurs again, please feel free to open a new issue or comment here so we can reopen it.
💬 sdaftuar commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2448551580)
Fixed this in a couple of places, should be good now I think.
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2448551580)
Fixed this in a couple of places, should be good now I think.
✅ willcl-ark closed an issue: "Optimize CheckMultiSig by using public key recovery."
(https://github.com/bitcoin/bitcoin/issues/15621)
(https://github.com/bitcoin/bitcoin/issues/15621)
💬 willcl-ark commented on issue "Optimize CheckMultiSig by using public key recovery.":
(https://github.com/bitcoin/bitcoin/issues/15621#issuecomment-3426948707)
This issue hasn’t attracted much interest from other contributors in quite some time.
Given that, it doesn’t seem important enough to keep open indefinitely. I’m going to close it for now due to lack of activity, but pull requests or renewed discussion are always welcome.
Comment here if you think this should be re-opened.
(https://github.com/bitcoin/bitcoin/issues/15621#issuecomment-3426948707)
This issue hasn’t attracted much interest from other contributors in quite some time.
Given that, it doesn’t seem important enough to keep open indefinitely. I’m going to close it for now due to lack of activity, but pull requests or renewed discussion are always welcome.
Comment here if you think this should be re-opened.
💬 maflcko commented on pull request "ci: Only write docker build images to Cirrus cache":
(https://github.com/bitcoin/bitcoin/pull/33639#issuecomment-3426948663)
> Let's see how much slowdown this would cause without caching.
I don't think this has any measurable effect on the runtime. The only benefit could be avoiding intermittent network errors.
(https://github.com/bitcoin/bitcoin/pull/33639#issuecomment-3426948663)
> Let's see how much slowdown this would cause without caching.
I don't think this has any measurable effect on the runtime. The only benefit could be avoiding intermittent network errors.
💬 sdaftuar commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2448553286)
Updated the commit message.
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2448553286)
Updated the commit message.
💬 storopoli commented on pull request "doc: add AGENTS.md":
(https://github.com/bitcoin/bitcoin/pull/33662#discussion_r2448553552)
I think that the reason why Claude Sonnet 4.5 dropped the second line can be fixed with something like this (backticks broke the GH suggestion so I changed to quotes)
```suggestion
Include the following trailers on commits substantially generated with automated assistance adapting to whatever agent you are.
For example for GitHub Copilot:
> Assisted-by: GitHub Copilot
For example for Claude Code:
> Assisted-by: Claude Code
```
(https://github.com/bitcoin/bitcoin/pull/33662#discussion_r2448553552)
I think that the reason why Claude Sonnet 4.5 dropped the second line can be fixed with something like this (backticks broke the GH suggestion so I changed to quotes)
```suggestion
Include the following trailers on commits substantially generated with automated assistance adapting to whatever agent you are.
For example for GitHub Copilot:
> Assisted-by: GitHub Copilot
For example for Claude Code:
> Assisted-by: Claude Code
```
💬 sdaftuar commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2448557208)
Done in 845ec3a3f806dee6c9ad053655fb466bd599a73d
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2448557208)
Done in 845ec3a3f806dee6c9ad053655fb466bd599a73d