💬 willcl-ark commented on issue "Use of C++ undefined behavior in various `IteratorComparators`":
(https://github.com/bitcoin/bitcoin/issues/19496#issuecomment-3426899495)
This issue hasn’t attracted much interest from other contributors in quite some time.
Given that, it doesn’t seem important enough to keep open indefinitely. I’m going to close it for now due to lack of activity, but pull requests or renewed discussion are always welcome.
Comment here if you think this shoudl be re-opened.
(https://github.com/bitcoin/bitcoin/issues/19496#issuecomment-3426899495)
This issue hasn’t attracted much interest from other contributors in quite some time.
Given that, it doesn’t seem important enough to keep open indefinitely. I’m going to close it for now due to lack of activity, but pull requests or renewed discussion are always welcome.
Comment here if you think this shoudl be re-opened.
👍 l0rinc approved a pull request: "ci: Only write docker build images to Cirrus cache"
(https://github.com/bitcoin/bitcoin/pull/33639#pullrequestreview-3361025213)
Code review ACK fabe0e07de1ad2f26da62f3ebe0e9be3f939b1f8
Let's see how much slowdown this would cause without caching.
(https://github.com/bitcoin/bitcoin/pull/33639#pullrequestreview-3361025213)
Code review ACK fabe0e07de1ad2f26da62f3ebe0e9be3f939b1f8
Let's see how much slowdown this would cause without caching.
💬 l0rinc commented on pull request "ci: Only write docker build images to Cirrus cache":
(https://github.com/bitcoin/bitcoin/pull/33639#discussion_r2448500461)
In the followup please consider avoiding concats (e.g. via `*list`), as shown above
(https://github.com/bitcoin/bitcoin/pull/33639#discussion_r2448500461)
In the followup please consider avoiding concats (e.g. via `*list`), as shown above
💬 sdaftuar commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2448512960)
Done.
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2448512960)
Done.
💬 sdaftuar commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2448515450)
Done.
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2448515450)
Done.
✅ willcl-ark closed an issue: "Add `not_null<T>` from the Guidelines Support Library"
(https://github.com/bitcoin/bitcoin/issues/24423)
(https://github.com/bitcoin/bitcoin/issues/24423)
💬 willcl-ark commented on issue "Add `not_null<T>` from the Guidelines Support Library":
(https://github.com/bitcoin/bitcoin/issues/24423#issuecomment-3426906780)
This issue hasn’t attracted much interest from other contributors in quite some time.
Given that, it doesn’t seem important enough to keep open indefinitely. I’m going to close it for now due to lack of activity, but pull requests or renewed discussion are always welcome.
Comment here if you think this shoudl be re-opened.
(https://github.com/bitcoin/bitcoin/issues/24423#issuecomment-3426906780)
This issue hasn’t attracted much interest from other contributors in quite some time.
Given that, it doesn’t seem important enough to keep open indefinitely. I’m going to close it for now due to lack of activity, but pull requests or renewed discussion are always welcome.
Comment here if you think this shoudl be re-opened.
💬 maflcko commented on issue "Use of C++ undefined behavior in various `IteratorComparators`":
(https://github.com/bitcoin/bitcoin/issues/19496#issuecomment-3426907085)
This was fixed in e009bf681c0e38a6451afa594ba3c7c8861f61c3 , no?
(https://github.com/bitcoin/bitcoin/issues/19496#issuecomment-3426907085)
This was fixed in e009bf681c0e38a6451afa594ba3c7c8861f61c3 , no?
💬 sdaftuar commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2448518145)
Done.
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2448518145)
Done.
✅ willcl-ark closed an issue: "linter to check omitted fields when constructing aggregate types?"
(https://github.com/bitcoin/bitcoin/issues/25631)
(https://github.com/bitcoin/bitcoin/issues/25631)
💬 willcl-ark commented on issue "linter to check omitted fields when constructing aggregate types?":
(https://github.com/bitcoin/bitcoin/issues/25631#issuecomment-3426911817)
It looks like this issue has been resolved. If that’s not the case, please let us know by commenting here or opening a new issue.
(https://github.com/bitcoin/bitcoin/issues/25631#issuecomment-3426911817)
It looks like this issue has been resolved. If that’s not the case, please let us know by commenting here or opening a new issue.
✅ willcl-ark closed an issue: "untrust vs unsafe ?"
(https://github.com/bitcoin/bitcoin/issues/18625)
(https://github.com/bitcoin/bitcoin/issues/18625)
💬 willcl-ark commented on issue "untrust vs unsafe ?":
(https://github.com/bitcoin/bitcoin/issues/18625#issuecomment-3426915794)
This issue hasn’t attracted much interest from other contributors in quite some time.
Given that, it doesn’t seem important enough to keep open indefinitely. I’m going to close it for now due to lack of activity, but pull requests or renewed discussion are always welcome.
Comment here if you think this should be re-opened.
(https://github.com/bitcoin/bitcoin/issues/18625#issuecomment-3426915794)
This issue hasn’t attracted much interest from other contributors in quite some time.
Given that, it doesn’t seem important enough to keep open indefinitely. I’m going to close it for now due to lack of activity, but pull requests or renewed discussion are always welcome.
Comment here if you think this should be re-opened.
✅ dergoegge closed an issue: "meta: Isolated fuzzing of net processing"
(https://github.com/bitcoin/bitcoin/issues/27502)
(https://github.com/bitcoin/bitcoin/issues/27502)
💬 dergoegge commented on issue "meta: Isolated fuzzing of net processing":
(https://github.com/bitcoin/bitcoin/issues/27502#issuecomment-3426935931)
This is still worth exploring but I'm not working on any PRs in this direction at the moment. Might pick it up again later.
(https://github.com/bitcoin/bitcoin/issues/27502#issuecomment-3426935931)
This is still worth exploring but I'm not working on any PRs in this direction at the moment. Might pick it up again later.
✅ willcl-ark closed an issue: "Internal bug detected: Fee needed > fee paid"
(https://github.com/bitcoin/bitcoin/issues/29398)
(https://github.com/bitcoin/bitcoin/issues/29398)
💬 willcl-ark commented on issue "Internal bug detected: Fee needed > fee paid":
(https://github.com/bitcoin/bitcoin/issues/29398#issuecomment-3426940674)
Since the problem isn’t easily reproducible, I’m closing this for now. If it occurs again, please feel free to open a new issue or comment here so we can reopen it.
(https://github.com/bitcoin/bitcoin/issues/29398#issuecomment-3426940674)
Since the problem isn’t easily reproducible, I’m closing this for now. If it occurs again, please feel free to open a new issue or comment here so we can reopen it.
💬 sdaftuar commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2448551580)
Fixed this in a couple of places, should be good now I think.
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2448551580)
Fixed this in a couple of places, should be good now I think.
✅ willcl-ark closed an issue: "Optimize CheckMultiSig by using public key recovery."
(https://github.com/bitcoin/bitcoin/issues/15621)
(https://github.com/bitcoin/bitcoin/issues/15621)
💬 willcl-ark commented on issue "Optimize CheckMultiSig by using public key recovery.":
(https://github.com/bitcoin/bitcoin/issues/15621#issuecomment-3426948707)
This issue hasn’t attracted much interest from other contributors in quite some time.
Given that, it doesn’t seem important enough to keep open indefinitely. I’m going to close it for now due to lack of activity, but pull requests or renewed discussion are always welcome.
Comment here if you think this should be re-opened.
(https://github.com/bitcoin/bitcoin/issues/15621#issuecomment-3426948707)
This issue hasn’t attracted much interest from other contributors in quite some time.
Given that, it doesn’t seem important enough to keep open indefinitely. I’m going to close it for now due to lack of activity, but pull requests or renewed discussion are always welcome.
Comment here if you think this should be re-opened.