💬 maflcko commented on pull request "ci: Only write docker build images to Cirrus cache":
(https://github.com/bitcoin/bitcoin/pull/33639#discussion_r2448347024)
Yes, `CI_IMAGE_NAME_TAG` is just a general `ubuntu:24.04`. I think logging the more specific name, like `ci_native_tidy` seems useful.

💬 maflcko commented on pull request "ci: Only write docker build images to Cirrus cache":
(https://github.com/bitcoin/bitcoin/pull/33639#discussion_r2448347492)
thx, inlined

💬 maflcko commented on pull request "ci: Only write docker build images to Cirrus cache":
(https://github.com/bitcoin/bitcoin/pull/33639#discussion_r2448348039)
(yes, it should be irrelevant, but removed)

💬 maflcko commented on pull request "ci: Only write docker build images to Cirrus cache":
(https://github.com/bitcoin/bitcoin/pull/33639#discussion_r2448348339)
(removed)

💬 maflcko commented on pull request "ci: Only write docker build images to Cirrus cache":
(https://github.com/bitcoin/bitcoin/pull/33639#discussion_r2448348724)
Yeah, it is a bit undocumented, and currently unused after the CI migration. Removed it for now. If there is ever need in the future to re-add it, it can be done properly. For future reference, the current state was:

```py
def maybe_cpuset():
# Env vars during the build can not be changed. For example, a modified
# $MAKEJOBS is ignored in the build process. Use --cpuset-cpus as an
# approximation to respect $MAKEJOBS somewhat, if cpuset is available.
if os.getenv("HAVE_CG
...

💬 laanwj commented on pull request "[IBD] coins: increase default UTXO flush batch size to 32 MiB":
(https://github.com/bitcoin/bitcoin/pull/31645#issuecomment-3426857292)
Concept and code review ACK b6f8c48946cbfceb066de660c485ae1bd2c27cc1

💬 willcl-ark commented on issue "Transactions in TCP FIN packets appear to be ignored":
(https://github.com/bitcoin/bitcoin/issues/4432#issuecomment-3426878553)
cc @vasild is this still an issue in current master?

💬 laanwj commented on issue "Transactions in TCP FIN packets appear to be ignored":
(https://github.com/bitcoin/bitcoin/issues/4432#issuecomment-3426888384)
Migbt be relevant again with #29415

✅ willcl-ark closed an issue: "Net code contains some UB -- violations of strict aliasing rules in C++"
(https://github.com/bitcoin/bitcoin/issues/22613)

💬 willcl-ark commented on issue "Net code contains some UB -- violations of strict aliasing rules in C++":
(https://github.com/bitcoin/bitcoin/issues/22613#issuecomment-3426894848)
This issue hasn’t attracted much interest from other contributors in quite some time.

Given that, it doesn’t seem important enough to keep open indefinitely. I’m going to close it for now due to lack of activity, but pull requests or renewed discussion are always welcome.

Comment here if you think this shoudl be re-opened.

✅ willcl-ark closed an issue: "Use of C++ undefined behavior in various `IteratorComparators`"
(https://github.com/bitcoin/bitcoin/issues/19496)

💬 willcl-ark commented on issue "Use of C++ undefined behavior in various `IteratorComparators`":
(https://github.com/bitcoin/bitcoin/issues/19496#issuecomment-3426899495)
This issue hasn’t attracted much interest from other contributors in quite some time.

Given that, it doesn’t seem important enough to keep open indefinitely. I’m going to close it for now due to lack of activity, but pull requests or renewed discussion are always welcome.

Comment here if you think this shoudl be re-opened.

👍 l0rinc approved a pull request: "ci: Only write docker build images to Cirrus cache"
(https://github.com/bitcoin/bitcoin/pull/33639#pullrequestreview-3361025213)
Code review ACK fabe0e07de1ad2f26da62f3ebe0e9be3f939b1f8

Let's see how much slowdown this would cause without caching.

💬 l0rinc commented on pull request "ci: Only write docker build images to Cirrus cache":
(https://github.com/bitcoin/bitcoin/pull/33639#discussion_r2448500461)
In the followup please consider avoiding concats (e.g. via `*list`), as shown above

💬 sdaftuar commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2448512960)
Done.

💬 sdaftuar commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2448515450)
Done.

✅ willcl-ark closed an issue: "Add `not_null<T>` from the Guidelines Support Library"
(https://github.com/bitcoin/bitcoin/issues/24423)

💬 willcl-ark commented on issue "Add `not_null<T>` from the Guidelines Support Library":
(https://github.com/bitcoin/bitcoin/issues/24423#issuecomment-3426906780)
This issue hasn’t attracted much interest from other contributors in quite some time.

Given that, it doesn’t seem important enough to keep open indefinitely. I’m going to close it for now due to lack of activity, but pull requests or renewed discussion are always welcome.

Comment here if you think this shoudl be re-opened.

💬 maflcko commented on issue "Use of C++ undefined behavior in various `IteratorComparators`":
(https://github.com/bitcoin/bitcoin/issues/19496#issuecomment-3426907085)
This was fixed in e009bf681c0e38a6451afa594ba3c7c8861f61c3 , no?

💬 sdaftuar commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2448518145)
Done.