💬 fanquake commented on issue "[`v30.0`] `createNewBlock` never returns":
(https://github.com/bitcoin/bitcoin/issues/33647#issuecomment-3418147325)
cc @Sjors

💬 Sjors commented on issue "[`v30.0`] `createNewBlock` never returns":
(https://github.com/bitcoin/bitcoin/issues/33647#issuecomment-3418203160)
And it was not syncing new blocks during `createNewBlock()`? That's the only thing it's expect to wait for, but only once at startup:

```h
/**
* Construct a new block template.
*
* During node initialization, this will wait until the tip is connected.
*
* @param[in] options options for creating the block
* @retval BlockTemplate a block template.
* @retval std::nullptr if the node is shut down.
*/
virtual std::unique_ptr<BlockTemplate> createNewBloc
...

📝 famouswizard opened a pull request: "fix: invalid plist format and update values to meet macOS 1.0 standard"
(https://github.com/bitcoin/bitcoin/pull/33654)
corrected the outdated and invalid parts of the plist file to comply with the current macOS property list 1.0 specification.

**changes:**

* replaced the old `SYSTEM` declaration and `version="0.9"` with the proper `PUBLIC` declaration and `version="1.0"`.
* updated `LSMinimumSystemVersion` from `14` to `10.14.0` (using the proper `X.Y.Z` format).
* changed `<string>True</string>` to `<true/>` to use a valid boolean value instead of a string.

now validates correctly with Apple’s DTD an
...

⚠️ pinheadmz opened an issue: "importdescriptors: check for errors before rescanning"
(https://github.com/bitcoin/bitcoin/issues/33655)
I tried to import two descriptors with labels but one was an internal descriptor. I didn't realize that was not allowed until the entire rescan (for the first descriptor) completed and the return object included success false with that error message, for the second descriptor.

🤔 janb84 reviewed a pull request: "build: Move CMAKE_SKIP_INSTALL_RPATH from CMake to Guix script"
(https://github.com/bitcoin/bitcoin/pull/33470#pullrequestreview-3353589314)
re ACK 4b41f99d57d822dfc258865d1dad03204fe0380f

Changes since last ack:
- pr and commit message change

💬 ryanofsky commented on issue "[`v30.0`] `createNewBlock` never returns":
(https://github.com/bitcoin/bitcoin/issues/33647#issuecomment-3418442416)
Thanks for the clear steps to reproduce. I was able to see the rust client make the bitcoin node IPC hang very quickly (after around a minute) following them.

It seems like rust client is able to trigger a deadlock bug that was fixed in https://github.com/bitcoin-core/libmultiprocess/pull/201, and was backported in https://github.com/bitcoin/bitcoin/pull/33519 in the [30.x](https://github.com/bitcoin/bitcoin/commits/30.x) branch that was made after the [v30.0](https://github.com/bitcoin/bitcoin
...

💬 waketraindev commented on issue "importdescriptors: check for errors before rescanning":
(https://github.com/bitcoin/bitcoin/issues/33655#issuecomment-3418640920)
Reference: #32376, #31514, #33614

✅ l0rinc closed a pull request: "refactor: throw `std::string_view` instead of `const char*` in constexpr/consteval functions"
(https://github.com/bitcoin/bitcoin/pull/33569)

💬 l0rinc commented on pull request "refactor: throw `std::string_view` instead of `const char*` in constexpr/consteval functions":
(https://github.com/bitcoin/bitcoin/pull/33569#issuecomment-3418646843)
Thanks @hebasto, if we need to support earlier versions of the LLVM MinGW toolchain we can resurrect this PR.

💬 diegoviola commented on pull request "Fix Wayland visual glitches":
(https://github.com/bitcoin-core/gui/pull/904#issuecomment-3418682105)
@pablomartin4btc can you please re-review?

👍 hodlinator approved a pull request: "net: make m_nodes_mutex non-recursive"
(https://github.com/bitcoin/bitcoin/pull/32394#pullrequestreview-3353773054)
ACK 4b3a2c23608e709a63b9d5bd69c3eb16cf08e462

Manually went through all functions using `CConnman::m_nodes_mutex` and only remaining issue I could find is now fixed (https://github.com/bitcoin/bitcoin/pull/32394/files#r2433600255).

Also checked out first commit and only cherrypicked mutex type change to re-confirm Clang spews warnings about missing annotations (and no warnings at HEAD of PR).

💬 hodlinator commented on pull request "net: make m_nodes_mutex non-recursive":
(https://github.com/bitcoin/bitcoin/pull/32394#discussion_r2442597625)
Agree that one cannot know unless one greps the entire codebase for insertions to `lNodesAnnouncingHeaderAndIDs`. Currently this is the only function.
But worst case, some parallel pull request could introduce another function that inserts more elements than 3. Using a dev-only `Assume` instead of `assert` as I suggested would make it less of a hazard.

Maybe it should be a precondition as well. Anyways, just a minor suggestion to attempt making existing tests against number 3 less magical.

💬 patrik090315-beep commented on issue "Release Schedule for 31.0":
(https://github.com/bitcoin/bitcoin/issues/33607#issuecomment-3418826895)
RTL online élő

💬 Christewart commented on pull request "refactor: optimize block index comparisons (1.4-6.8x faster)":
(https://github.com/bitcoin/bitcoin/pull/33637#issuecomment-3418835243)
I attempted to run the script, not really sure what these results indicate. Just pasting what the results were

```
Darwin Chriss-MacBook-Pro.local 24.6.0 Darwin Kernel Version 24.6.0: Mon Jul 14 11:30:55 PDT 2025; root:xnu-11417.140.69~1/RELEASE_ARM64_T6031 arm64
```

```
Apple clang version 17.0.0 (clang-1700.3.19.1)
Target: arm64-apple-darwin24.6.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin
```


```
| ns/cmp | cmp/s
...

✅ furszy closed a pull request: "p2p: avoid traversing blocks (twice) during IBD"
(https://github.com/bitcoin/bitcoin/pull/32730)

💬 l0rinc commented on pull request "refactor: optimize block index comparisons (1.4-6.8x faster)":
(https://github.com/bitcoin/bitcoin/pull/33637#issuecomment-3419090521)
Thanks for the measurements @Christewart, this is how your measurements compare to mine (but most importantly how it compares to `master`):
<img width="2385" height="883" alt="image" src="https://github.com/user-attachments/assets/96a59d25-292e-4e11-bd2c-3fb11a5b13cb" />

💬 lucifermmmenriquejr commented on pull request "p2p: avoid traversing blocks (twice) during IBD":
(https://github.com/bitcoin/bitcoin/pull/32730#issuecomment-3419147516)
Enrique Ramirez

On Sat, Oct 18, 2025, 5:29 PM Matias Furszyfer ***@***.***>
wrote:

> Closed #32730 <https://github.com/bitcoin/bitcoin/pull/32730>.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/bitcoin/bitcoin/pull/32730#event-20362922986>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/BSKJHMJLQ2ZPL3ELNRNAYOT3YLEPFAVCNFSM6AAAAAB7DDPV5SVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRQGM3DEOJSGI4TQNQ>
> .
> You are
...

⚠️ Braga17 opened an issue: "PR: Developer Experience & CI Enhancements (Devcontainer, CMake Presets, Docs)"
(https://github.com/bitcoin/bitcoin/issues/33656)
### Please describe the feature you'd like to see added.



Summary

This PR introduces small, additive improvements focused on developer experience (DX), CI clarity, and contributor onboarding for Bitcoin Core. It does not modify Guix, depends, or existing build/release workflows.


---

What’s included

1. Devcontainer

Adds a .devcontainer/ folder with:

devcontainer.json and post-create.sh for local or Codespaces builds.

Preconfigured environment with toolchains, Python deps, and ccache.

S
...

✅ fanquake closed an issue: "PR: Developer Experience & CI Enhancements (Devcontainer, CMake Presets, Docs)"
(https://github.com/bitcoin/bitcoin/issues/33656)

📝 romanz opened a pull request: "rest: allow reading partial block data from storage"
(https://github.com/bitcoin/bitcoin/pull/33657)
It will allow fetching specific transactions using an external index, following https://github.com/bitcoin/bitcoin/pull/32541#issuecomment-3267485313.

Currently, electrs and other indexers map between an address/scripthash to the list of the relevant transactions.

However, in order to fetch those transactions from bitcoind, electrs relies on reading the whole block and post-filtering for a specific transaction[^1]. Other indexers use a `txindex` to fetch a transaction using its txid [^2][^
...