💬 cedwies commented on pull request "net_processing: rename RelayTransaction to better describe what it does":
(https://github.com/bitcoin/bitcoin/pull/33565#discussion_r2436060116)
Thanks for the correction, that makes sense. I was focusing on the mechanism rather than the permission. I appreciate the clarification.

💬 zaidmstrr commented on pull request "miner: fix empty mempool case for waitNext()":
(https://github.com/bitcoin/bitcoin/pull/33566#discussion_r2436063318)
Thanks for the benchmarking. But I think to simulate the actual mempool behaviour is complicated. The order of transactions inside mempool is not very deterministic based on fee. So we can't predict that our threshold always will be hit at the last stages of search, even though it searches till the last in most of the cases, but that's not for all. The function also uses polling, so if you increase the number of executions, the time will increase a bit. But as Sjors said, this calculation will
...

✅ willcl-ark closed an issue: "Auto detect IPv6 connectivity"
(https://github.com/bitcoin/bitcoin/issues/28061)

💬 willcl-ark commented on issue "Auto detect IPv6 connectivity":
(https://github.com/bitcoin/bitcoin/issues/28061#issuecomment-3411176533)
This issue may have merit, but it hasn’t attracted much interest from other contributors.

Given that, it doesn’t seem important enough to keep open indefinitely. I’m closing it for now due to lack of activity — but pull requests or renewed discussion are always welcome.

💬 diegoviola commented on pull request "Fix Wayland visual glitches":
(https://github.com/bitcoin-core/gui/pull/904#issuecomment-3411194348)
Reverted as per the previous discussion.

💬 diegoviola commented on pull request "Fix Wayland visual glitches":
(https://github.com/bitcoin-core/gui/pull/904#issuecomment-3411199249)
Choose the revert approach as per the previous discussion.

💬 hebasto commented on issue "Slow unit tests delay functional tests and leave CPU unused":
(https://github.com/bitcoin/bitcoin/issues/32770#issuecomment-3411200053)
> On the libsecp notes, since [bitcoin-core/secp256k1#1734](https://github.com/bitcoin-core/secp256k1/pull/1734) we can parallelize tests. Tagging [@hebasto](https://github.com/hebasto) as he had a patch to do it.

See https://github.com/bitcoin-core/secp256k1/pull/1760.

✅ willcl-ark closed an issue: "Creating a Wallet Feature Guidelines Document"
(https://github.com/bitcoin/bitcoin/issues/28062)

💬 willcl-ark commented on issue "Creating a Wallet Feature Guidelines Document":
(https://github.com/bitcoin/bitcoin/issues/28062#issuecomment-3411201458)
Closing this as it hasn’t seen any activity for a while. If you’d like to continue the discussion or feel the topic is still important, please leave a comment and we can reopen it.

💬 diegoviola commented on pull request "Fix Wayland visual glitches":
(https://github.com/bitcoin-core/gui/pull/904#issuecomment-3411215057)
Going with the revert approach as per the previous discussion.

✅ willcl-ark closed an issue: "Include torrent in binary download verification "
(https://github.com/bitcoin/bitcoin/issues/27702)

💬 willcl-ark commented on issue "Include torrent in binary download verification ":
(https://github.com/bitcoin/bitcoin/issues/27702#issuecomment-3411219605)
There doesn’t seem to have been much activity around implementing this feature.

If it’s something you’re still interested in, please feel free to open a pull request or if you think this issue should be re-opened leave a comment in here.

💬 hebasto commented on pull request "depends: Use `CC_FOR_BUILD` for `config.guess `":
(https://github.com/bitcoin/bitcoin/pull/29963#issuecomment-3411277879)
> What was your intention with this patch, @fanquake ?

@fanquake

Can you please follow up here?

💬 fanquake commented on pull request "depends: Use `CC_FOR_BUILD` for `config.guess `":
(https://github.com/bitcoin/bitcoin/pull/29963#issuecomment-3411347583)
> What was your intention with this patch, @fanquake ?

At this point I can't remember.

🚀 fanquake merged a pull request: "[28.x] Backport & finalise 28.3"
(https://github.com/bitcoin/bitcoin/pull/33613)

💬 hebasto commented on pull request "build: Use clang-cl to build on Windows natively":
(https://github.com/bitcoin/bitcoin/pull/31507#issuecomment-3411368744)
> Reading the description, I'm still not really clear on the goals here. It seems like this is just adding even more ways to compile for Windows, which we have to add more CI / and more work arounds for, but doesn't actually improve the Windows binaries we are shipping to end users in any way.

Building Bitcoin Core from source has always been considered one of the best practices. Not supporting an effective compiler, such as clang-cl on Windows, prevents users from achieving optimal performan
...

💬 hebasto commented on pull request "build: Use clang-cl to build on Windows natively":
(https://github.com/bitcoin/bitcoin/pull/31507#issuecomment-3411395080)
Rebased to refresh the CI.

🤔 ismaelsadeeq reviewed a pull request: "Cluster mempool"
(https://github.com/bitcoin/bitcoin/pull/33629#pullrequestreview-3339641710)
Review the main implementation e6315c24326016cfaee5bd046e8b2e4e1088ac6b

I've not noticed any major issue, dropped a few minor comments and nits.
If any comment become stale after the update feel free to ignore it

💬 ismaelsadeeq commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2432258434)
In "Add new (unused) limits for cluster size/count" 2801e80528a3a1c2949a8fda6338882613a673e5


nit: be specific it is in virtual size
```suggestion
argsman.AddArg("-limitclustersize=<n>", strprintf("Do not accept transactions whose size with all in-mempool connected transactions exceeds <n> virtual kilobytes (default: %u)", DEFAULT_CLUSTER_SIZE_LIMIT_KVB), ArgsManager::ALLOW_ANY | ArgsManager::DEBUG_ONLY, OptionsCategory::DEBUG_TEST);

```

💬 ismaelsadeeq commented on pull request "Cluster mempool":
(https://github.com/bitcoin/bitcoin/pull/33629#discussion_r2432032703)
In "Add sigops adjusted weight calculator" f2eff17c6c4fc945f6fd761564212802107a1d7d

nit: use snake case.