💬 mzumsande commented on pull request "validation: Improve warnings in case of chain corruption":
(https://github.com/bitcoin/bitcoin/pull/33553#discussion_r2434358606)
> This doesn't combine well with invalidateblock

Being out of consensus with all outbound peers is a situation as catastrophic as it gets, and probably requires intervention by the user - why wouldn't we want to be a bit spammy in this scenario?
Outside of a real catastrophic chain split, one could of course artificially induce this situation with `invalidateblock` (which is debug-only) and then circle through outbound peers - but I don't see the use case, why would anyone do this and why w
...

💬 sipa commented on pull request "p2p: Advance pindexLastCommonBlock early after connecting blocks":
(https://github.com/bitcoin/bitcoin/pull/32180#issuecomment-3408890311)
@mzumsande Agree that sounds sufficiently unlikely to optimize for (and sufficiently expensive to intentionally cause).

Code review ACK on the logic change, but I want to have a look at the tests still.

💬 andrewtoth commented on pull request "validation: fetch block inputs on parallel threads >10% faster IBD":
(https://github.com/bitcoin/bitcoin/pull/31132#issuecomment-3408901200)
Rebased due to conflicts.
Removed the first commit. We don't need to modify `EmplaceCoinInternalDANGER`, we can just insert the coins as dirty into the cache. They will be set dirty when they are spent anyways. If a block fails validation inside `ConnectBlock`, then the dirty coins will just rewrite the same value to the db on the next flush or sync.

💬 yuvicc commented on pull request "test: Fix reorg patterns in tests to use proper fork-based approach":
(https://github.com/bitcoin/bitcoin/pull/32587#issuecomment-3409170060)
- Addresses @instagibbs 's [comment](https://github.com/bitcoin/bitcoin/pull/32587#discussion_r2432484590) on adding a note for future reviewers.
- Addressed @instagibbs 's [comment](https://github.com/bitcoin/bitcoin/pull/32587#discussion_r2432451468) on removing the redundant assert.

💬 optout21 commented on pull request "net_processing: rename RelayTransaction to better describe what it does":
(https://github.com/bitcoin/bitcoin/pull/33565#issuecomment-3409283210)
reACK 84b2ad03349bf6af3d6057f3dbcdf84c17f11bcb

💬 TheCharlatan commented on pull request "kernel: Introduce C header API":
(https://github.com/bitcoin/bitcoin/pull/30595#issuecomment-3409324684)
Thanks for the review @stringintech
Updated 81cec737e68b91f5edf90179b81aa620a5a68677 -> a755e00a13541b3b5a707cf385f1cbec0449c6a9 ([kernelApi_73](https://github.com/TheCharlatan/bitcoin/tree/kernelApi_73) -> [kernelApi_74](https://github.com/TheCharlatan/bitcoin/tree/kernelApi_74), [compare](https://github.com/TheCharlatan/bitcoin/compare/kernelApi_73..kernelApi_74))

* Addressed @stringintech's [comment](https://github.com/bitcoin/bitcoin/pull/30595#discussion_r2433069372), replace "chain" w
...

💬 Sjors commented on pull request "Update libmultiprocess subtree in 30.x branch":
(https://github.com/bitcoin/bitcoin/pull/33519#issuecomment-3409387866)
ACK ae63cc4bf2d25a5b7ce9d166aa288431e8ca16a7

💬 Sjors commented on pull request "refactor: use options struct for signing and PSBT operations":
(https://github.com/bitcoin/bitcoin/pull/32876#issuecomment-3409418362)
Rebased after #29675.

💬 zaidmstrr commented on pull request "rpc: Handle -named argument parsing where '=' character is used":
(https://github.com/bitcoin/bitcoin/pull/32821#discussion_r2434797504)
Well, we need to include `address_type` here because the method `getnewaddress` contains `label` which might contain a `=` char, so to prevent treating arguments as positional while named is specified or vice versa, we need to mention that all the parameters' names correspond to the method. This gives the whole idea about what all the possible values a user can pass for the given method. More information about this behaviour is mentioned around lines 43-53 in `client.cpp`.

The second thing i
...

💬 zaidmstrr commented on pull request "rpc: Handle -named argument parsing where '=' character is used":
(https://github.com/bitcoin/bitcoin/pull/32821#discussion_r2434797827)
The original idea about this PR is to handle cases where a user might pass some values which contain the `=` char in them, and those are valid and acceptable, e.g. wallet names, labels, file paths. Methods like `listlabels` and `setwalletflag` do not contain any string parameters which might contain any `=` char in them; that's why I think this is out of scope for this PR.

💬 vasild commented on pull request "net_processing: rename RelayTransaction to better describe what it does":
(https://github.com/bitcoin/bitcoin/pull/33565#discussion_r2434804167)
I will address if I have to re-touch, thanks!

📝 diegoviola opened a pull request: "qt: fix Wayland visual glitches"
(https://github.com/bitcoin-core/gui/pull/904)
Qt::WindowStaysOnTopHint is ineffective on Wayland and causes bitcoin-qt to flicker (see #903 and #33432).

Wayland's window behavior is controlled by the compositor, not the client. This change skips applying hints when running natively under Wayland, resolving the flickering issue.

<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened agains
...

💬 Sjors commented on pull request "wallet: `addhdkey` RPC to add just keys to wallets via new `unused(KEY)` descriptor":
(https://github.com/bitcoin/bitcoin/pull/29136#issuecomment-3409544132)
Needs rebase.

💬 maflcko commented on pull request "CI: silent merge check":
(https://github.com/bitcoin/bitcoin/pull/33145#issuecomment-3409554826)
Any updates here? Just asking, because it is a bit tedious to manually search for all silent merge conflicts. Example ref: https://github.com/bitcoin/bitcoin/pull/29136#issuecomment-3409544132

💬 maflcko commented on issue "Slow unit tests delay functional tests and leave CPU unused":
(https://github.com/bitcoin/bitcoin/issues/32770#issuecomment-3409566092)
On the general topic, there was commit https://github.com/bitcoin/bitcoin/commit/636b611781154f32c8d7ae8ea301d12b1464c151, so someone could some time in the future check if it helps.

✅ maflcko closed an issue: "Revisiting us self-hosting parts of our CI"
(https://github.com/bitcoin/bitcoin/issues/31965)

💬 maflcko commented on issue "Revisiting us self-hosting parts of our CI":
(https://github.com/bitcoin/bitcoin/issues/31965#issuecomment-3409569349)
Closing for now. I think this is fixed. There are some possible follow-ups (https://github.com/bitcoin/bitcoin/issues/31965#issuecomment-3241685779), but they all have their own issue or pull request already.

💬 diegoviola commented on issue "Qt6 version of Bitcoin Core (bitcoin-qt) flickers on Wayland":
(https://github.com/bitcoin-core/gui/issues/903#issuecomment-3409599121)
> I'll take a look...

Appreciate you planning to look into that, I managed to track down the cause and submitted a fix in #904. Let me know if you have any questions during the review. Thanks!

📝 vastonus opened a pull request: "chore: remove repetitive word in src/leveldb/README.md"
(https://github.com/bitcoin/bitcoin/pull/33638)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

💬 yuvicc commented on pull request "rpc, test: allow multiple data outputs in `createrawtransaction` & `createpsbt`":
(https://github.com/bitcoin/bitcoin/pull/32790#issuecomment-3409691430)
@mikekelly see the [comment](https://github.com/bitcoin/bitcoin/issues/32478#issuecomment-2876030352), this changes will come in the next release 31.0. Will update this one soon and mark it for review.