💬 mzumsande commented on pull request "validation: Improve warnings in case of chain corruption":
(https://github.com/bitcoin/bitcoin/pull/33553#issuecomment-3403249590)
> Is the working assumption that the errors users are reporting in #26391 are due to disk corruption causing exactly the serialized `nStatus::BLOCK_FAILED_{VALID,CHILD}` bit to be flipped, causing the block to be loaded as invalid instead of valid, without causing any other corruption that would likely crash the application? Because while that wouldn't be impossible, it seems like an incredibly unlikely event to me?

No, that would indeed be unlikely. The assumption is that some kind of corrup
...

🤔 hodlinator reviewed a pull request: "net: make m_nodes_mutex non-recursive"
(https://github.com/bitcoin/bitcoin/pull/32394#pullrequestreview-3337135597)
Concept ACK 492be23a1873d7165e6cc75d1282f4feb63f87b9

💬 hodlinator commented on pull request "net: make m_nodes_mutex non-recursive":
(https://github.com/bitcoin/bitcoin/pull/32394#discussion_r2430217115)
Tried cherrypicking

<details><summary>minimal diff to change m_nodes_mutex mutex type and ForNode usage</summary>

```diff
diff --git a/src/net.h b/src/net.h
index d806b42a1e..f997bbe820 100644
--- a/src/net.h
+++ b/src/net.h
@@ -1519,7 +1519,7 @@ private:
mutable Mutex m_added_nodes_mutex;
std::vector<CNode*> m_nodes GUARDED_BY(m_nodes_mutex);
std::list<CNode*> m_nodes_disconnected;
- mutable RecursiveMutex m_nodes_mutex;
+ mutable Mutex m_nodes_mutex;
std::atomic<No
...

✅ sdaftuar closed a pull request: "Cluster mempool implementation"
(https://github.com/bitcoin/bitcoin/pull/28676)

📝 sdaftuar opened a pull request: "Cluster mempool "
(https://github.com/bitcoin/bitcoin/pull/33629)
[Reopening #28676 here as a new PR, because GitHub is slow to load the page making it hard to scroll through and see comments. Also, that PR was originally opened with a prototype implementation which has changed significantly with the introduction of `TxGraph`.]

This is an implementation of the [cluster mempool proposal](https://delvingbitcoin.org/t/an-overview-of-the-cluster-mempool-proposal/393).

This branch implements the following observable behavior changes:

- Maintains a partit
...

📝 glozow opened a pull request: "[doc] correct topology requirements in submitpackage helptext"
(https://github.com/bitcoin/bitcoin/pull/33630)
This doc is outdated since #31385. Also made it explicit that a singleton is ok.

Can be backported to 30.x, but doesn't need to be backported earlier ("if any" covers #31096).

⚠️ glozow pinned an issue: "Minor Release 29.3"
(https://github.com/bitcoin/bitcoin/issues/33628)
Backports
- https://github.com/bitcoin/bitcoin/pull/33611

<!--
RC
- [] final changes
- [] tag
- [] upload binaries
- [] announcements
-->

See [release process docs](https://github.com/bitcoin/bitcoin/blob/master/doc/release-process.md) for more details. This issue can be used to track status updates. Please feel free to suggest backports in the comments.

💬 l0rinc commented on pull request "index: initial sync speedup, parallelize process":
(https://github.com/bitcoin/bitcoin/pull/26966#issuecomment-3403469332)
what's the reason for the frequent pushes here recently?

🚀 glozow merged a pull request: "multiprocess: Fix high overhead from message logging"
(https://github.com/bitcoin/bitcoin/pull/33517)

💬 yancyribbens commented on pull request "docs: add doc comment for SRD selection algorithm":
(https://github.com/bitcoin/bitcoin/pull/33622#discussion_r2430345487)
Some of the other algorithms use that wording, for example see coin-grinder: https://github.com/bitcoin/bitcoin/pull/33622/files#diff-d473ed8396f9451afb848923cfcfaa630c9811a78e07f3ae1ffd3a65da218accR208. Therefore just copying a pattern that already exists. Do you not like that wording in coin-grinder also?

💬 yancyribbens commented on pull request "docs: add doc comment for SRD selection algorithm":
(https://github.com/bitcoin/bitcoin/pull/33622#discussion_r2430361531)
There's not much presidence for this when looking at how the other algorithms are documented. coin-grinder seems to have it documented in both the headers file and the cpp file.

🚀 glozow merged a pull request: "wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys"
(https://github.com/bitcoin/bitcoin/pull/29675)

💬 yancyribbens commented on pull request "docs: add doc comment for SRD selection algorithm":
(https://github.com/bitcoin/bitcoin/pull/33622#discussion_r2430363748)
I don't care much either way where the doc comments are, just that it exists someplace that is findable.

💬 andrewtoth commented on pull request "validation: fetch block inputs on parallel threads >10% faster IBD":
(https://github.com/bitcoin/bitcoin/pull/31132#issuecomment-3403508763)
> I noticed that for small dbcache it has a very noticeable effect, but for very high dbcache this seems to add an extra cost - since we already have everything in the cache, so it just does useless work.
I wonder if we could enable this fetching only after the very first time we [Flush](https://github.com/bitcoin/bitcoin/blob/17372d788e6ca6f5a8452acf88d6b7db4221cb7e/src/coins.cpp#L251) and erase, since it cannot help in any way before that.

@l0rinc There is already quite a lot to review her
...

💬 waketraindev commented on pull request "Add reset button and console commands for clearing output/history":
(https://github.com/bitcoin-core/gui/pull/882#issuecomment-3403517787)
Rebased on current master.
Simplified to console commands only, dropped the keyboard shortcut and clear button (no new buttons added).
Added the clear-all command for completness and ease of use.

Tested all commands (clear, clear-all, history, history-clear) on Ubuntu 24.04 and Windows 11 -- all work as expected.

💬 mzumsande commented on pull request "validation: ensure assumevalid is always used during reindex":
(https://github.com/bitcoin/bitcoin/pull/31615#discussion_r2430339233)
I think that this comment is misleading, the call is not only here for `-loadblock`.

This is (unless `-reindex` is used) the first and only time `ActivateBestChain()` is invoked as part of init. Even without `-reindex` and without `-loadblocks` it does important work: It connects the genesis block on first startup (without which init [cannot finish](https://github.com/bitcoin/bitcoin/blob/db4bde0b0347f5141cd6721895e47400239a30e8/src/init.cpp#L1980-L1995)), and on later starts it will connect
...

💬 mzumsande commented on pull request "validation: ensure assumevalid is always used during reindex":
(https://github.com/bitcoin/bitcoin/pull/31615#discussion_r2430391932)
https://github.com/bitcoin/bitcoin/pull/31615#discussion_r2430339233 is relevant to this, too. Basically, we want to connect blocks with the reindexing flag set during a reindex, but need a ABC call in the case of no `-reindex`.

💬 brunoerg commented on pull request "docs: add doc comment for SRD selection algorithm":
(https://github.com/bitcoin/bitcoin/pull/33622#discussion_r2430410352)
I think coin grinder explanation is more complex, but anyway feel free to ignore it.

💬 brunoerg commented on pull request "docs: add doc comment for SRD selection algorithm":
(https://github.com/bitcoin/bitcoin/pull/33622#discussion_r2430413199)
I think it's weird to have a documentation about the paratemers in `coinselection.h` and another documentation about the same parameters but with different wording/explanation in `coinselection.cpp`.

👋 waketraindev's pull request is ready for review: "qt: add console commands for clearing output and history"
(https://github.com/bitcoin-core/gui/pull/882)