💬 maflcko commented on pull request "test: change log rate limit version gate":
(https://github.com/bitcoin/bitcoin/pull/33612#issuecomment-3402383777)
> In the case a user on 29.x runs the functional tests and is confused why logs are rate limited in output.

This may also help in the future, when a previous release of 29.1 (or later in the 29.x series) is picked.

lgtm ACK 7b544341c0021dd713f05bc439ee190de911930c

💬 optout21 commented on pull request "miner: fix empty mempool case for waitNext()":
(https://github.com/bitcoin/bitcoin/pull/33566#issuecomment-3402417850)
ACK 8f7673257a1a86717c1d83770dc857fc254df107

💬 Crypt-iQ commented on pull request "test: change log rate limit version gate":
(https://github.com/bitcoin/bitcoin/pull/33612#issuecomment-3402423882)
I was testing out 29.x without this patch and was very confused why the rate limiting was not being applied. Turns out my description in the OP is wrong.

Unless the version is explicitly set as done in the [`wallet_backwards_compatibility.py`](https://github.com/bitcoin/bitcoin/blob/6c4fe401e908cff1b67d80035b117aae15fe7db6/test/functional/wallet_backwards_compatibility.py#L56-L65) test, the [`version_is_at_least`](https://github.com/bitcoin/bitcoin/blob/6c4fe401e908cff1b67d80035b117aae15fe7db
...

📝 fanquake opened a pull request: "Update secp256k1 subtree to latest master "
(https://github.com/bitcoin/bitcoin/pull/33625)
Updates the subtree to https://github.com/bitcoin-core/secp256k1/commit/a44a339384e1e4b1c0ed7fa59e2857b057f075bf.
Related to #33284.

💬 Christewart commented on issue "`generatetoaddress` 2-3x slower on v30 compared to v29":
(https://github.com/bitcoin/bitcoin/issues/33618#issuecomment-3402472699)
As a side note, why was the `generate` command removed from the RPC interface? It seems like this RPC[ could be useful](https://github.com/bitcoin/bitcoin/issues/16000#issuecomment-491486488) and avoid the performance hit of touching the wallet? I'm trying to dig through various PRs and issues and don't see a straight forward answer, perhaps someone knows? #16000 #17700 #19133 #19455

💬 maflcko commented on pull request "test: P2SH sig ops are only counted with `SCRIPT_VERIFY_P2SH`":
(https://github.com/bitcoin/bitcoin/pull/33624#issuecomment-3402515314)
review ACK fd2ce880e09c686c320811a322d00b9318f317ae 📌

<details><summary>Show signature</summary>

Signature:

```
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
trusted comment: review ACK fd2ce880e09c
...

💬 achow101 commented on issue "`generatetoaddress` 2-3x slower on v30 compared to v29":
(https://github.com/bitcoin/bitcoin/issues/33618#issuecomment-3402534556)
> As a side note, why was the `generate` command removed from the RPC interface?

Because of the separation between node things and wallet things. `generate` is testing only and there's no good reason to have to add it to the node interface just for a convenience function.

> It seems like this RPChttps://github.com/bitcoin/bitcoin/issues/16000#issuecomment-491486488 and avoid the performance hit of touching the wallet?

It would not make a difference. The behavior is not because of any repeated
...

🤔 glozow reviewed a pull request: "cluster mempool: control/optimize TxGraph memory usage"
(https://github.com/bitcoin/bitcoin/pull/33157#pullrequestreview-3336180752)
reACK 023cd5a5469ad61205bf7bb1135895f2b4a20ea9

Thanks for taking the suggestions!

💬 glozow commented on pull request "cluster mempool: control/optimize TxGraph memory usage":
(https://github.com/bitcoin/bitcoin/pull/33157#discussion_r2429540255)
Fwiw, I think parts of the original comment could have been kept, it's helpful to know e.g. that it's "implementation-specific, and can go up (even when transactions are removed) and down (even when dependencies are added), as clusters can split and merge."

🚀 glozow merged a pull request: "cluster mempool: control/optimize TxGraph memory usage"
(https://github.com/bitcoin/bitcoin/pull/33157)

💬 Christewart commented on issue "`generatetoaddress` 2-3x slower on v30 compared to v29":
(https://github.com/bitcoin/bitcoin/issues/33618#issuecomment-3402590889)
> > As a side note, why was the `generate` command removed from the RPC interface?
>
> Because of the separation between node things and wallet things. `generate` is testing only and there's no good reason to have to add it to the node interface just for a convenience function.

I think providing helpful testing tools is a worthwhile goal. For instance it was deemed worthwhile to bring back the utility around in `bitcoin-cli` (#19133). Not everyone uses the entire bitcoin core stack for develop
...

💬 achow101 commented on issue "`generatetoaddress` 2-3x slower on v30 compared to v29":
(https://github.com/bitcoin/bitcoin/issues/33618#issuecomment-3402608360)
> Yes, so have the `generate` RPC send funds a to an address that are not relevant to the wallet

Well the issues you mentioned are talking about the old `generate` which mined into a wallet.

If you want to mine into a black hole, you can do that with `generatetoaddress` and a random address.

💬 hebasto commented on issue "Qt6 version of Bitcoin Core (bitcoin-qt) flickers on Wayland":
(https://github.com/bitcoin-core/gui/issues/903#issuecomment-3402669201)
>```
> 2025-10-14T14:47:07Z Qt 6.10.0 (dynamic), plugin=wayland
> 2025-10-14T14:47:07Z No static plugins.
>```

Could you please try the release binary from https://bitcoincore.org/bin/bitcoin-core-30.0/ or build a statically linked binary with [depends](https://github.com/bitcoin-core/gui/tree/master/depends)?

💬 fanquake commented on pull request "test: change log rate limit version gate":
(https://github.com/bitcoin/bitcoin/pull/33612#issuecomment-3402673663)
cc @stickies-v

👍 stickies-v approved a pull request: "test: change log rate limit version gate"
(https://github.com/bitcoin/bitcoin/pull/33612#pullrequestreview-3336520616)
ACK 7b544341c0021dd713f05bc439ee190de911930c

🚀 fanquake merged a pull request: "test: change log rate limit version gate"
(https://github.com/bitcoin/bitcoin/pull/33612)

💬 fanquake commented on pull request "test: change log rate limit version gate":
(https://github.com/bitcoin/bitcoin/pull/33612#issuecomment-3402716396)
Backported to `30.x` in #33609.

💬 fanquake commented on pull request "test: change log rate limit version gate":
(https://github.com/bitcoin/bitcoin/pull/33612#issuecomment-3402720496)
Backported to `29.x` in #33611.

💬 fanquake commented on pull request "Update libmultiprocess subtree in 30.x branch":
(https://github.com/bitcoin/bitcoin/pull/33519#issuecomment-3402730706)
cc @Sjors @theuni

💬 diegoviola commented on issue "Qt6 version of Bitcoin Core (bitcoin-qt) flickers on Wayland":
(https://github.com/bitcoin-core/gui/issues/903#issuecomment-3402733857)
> > ```
> > 2025-10-14T14:47:07Z Qt 6.10.0 (dynamic), plugin=wayland
> > 2025-10-14T14:47:07Z No static plugins.
> > ```
>
> Could you please try the release binary from https://bitcoincore.org/bin/bitcoin-core-30.0/ or build a statically linked binary with [depends](https://github.com/bitcoin-core/gui/tree/master/depends)?
>
> EDIT: Both options have only the XCB plugin built in and do not use Wayland. I just want to ensure that release binaries are not affected on your system.

Sure, I just
...