💬 maflcko commented on issue "Version 30 `-datadir=` not working":
(https://github.com/bitcoin/bitcoin/issues/33608#issuecomment-3397857521)
> it says [default wallet] [needs migration]. should I click on that and let it migrate my wallet? I didn't know it needed migration. I'm backing everything up before I do anything else.

Yeah, a backup makes sense. See also my previous reply: "my recommendation would be to backup the wallet (following your normal backup flow) and then migrate it, using v30.0.".



> It wants me to put in my pass phrase to migrate the wallet. I don't see anything about having to migrate the wallet from 29.1 in t
...

📝 fanquake opened a pull request: "[30.x] Backports"
(https://github.com/bitcoin/bitcoin/pull/33609)
Backports:
* #33558
* #33580
* #33581

💬 fanquake commented on pull request "ci: Properly include $FILE_ENV in DEPENDS_HASH":
(https://github.com/bitcoin/bitcoin/pull/33581#issuecomment-3397863875)
Backported to `30.x` in #33609.

💬 fanquake commented on pull request "depends: Use $(package)_file_name when downloading from the fallback":
(https://github.com/bitcoin/bitcoin/pull/33580#issuecomment-3397886271)
Backported to `30.x` in #33609.

🤔 jonatack reviewed a pull request: "rpc: Distinguish between vsize and sigop adjusted mempool vsize"
(https://github.com/bitcoin/bitcoin/pull/32800#pullrequestreview-3331998740)
Concept ACK, appears to clarify these values, and adds a new "vsize_bip141" field to the API while not changing the existing vsize values returned.

🤔 janb84 reviewed a pull request: "Clear out space on GHA jobs"
(https://github.com/bitcoin/bitcoin/pull/33514#pullrequestreview-3332011346)
re ACK 014b9f6268390b78e66e1be24813d3f069588442

changes since last ack:
- The PR is back to only running the `Clear unnecessary files` action on the `'CentOS, depends, gui'`

💬 Aa777263100 commented on pull request "ci: Use native platform for win-cross task":
(https://github.com/bitcoin/bitcoin/pull/33558#issuecomment-3397920077)
> Forcing the architecture to amd64 is no longer required. Dropping it should have some benefits:
>
> * Faster CI speed on other arches (riscv64, arm, ...)
> * Unlock the CI task to run on riscv64 at all

💬 Waytoogo commented on issue "Version 30 `-datadir=` not working":
(https://github.com/bitcoin/bitcoin/issues/33608#issuecomment-3397927607)
I have never had to do a wallet migration before. In the past when a database migration was needed, it was stated very plainly that it would happen, no surprises. This time there is a wallet migration the needs me to put in my pass phrase, and it was mentioned way down in the release notes. The message it gave me when I started bitcoin-qt.exe with my data directory was not helpful, and why I filed an issue. Because it requires you to put in your passphrase, it should have been front and center i
...

📝 fanquake opened a pull request: "doc: archive release notes for v29.2"
(https://github.com/bitcoin/bitcoin/pull/33610)

📝 fanquake opened a pull request: "[29.x] Backports"
(https://github.com/bitcoin/bitcoin/pull/33611)
Backports:
* #33581

💬 fanquake commented on issue "Minor Release 29.2":
(https://github.com/bitcoin/bitcoin/issues/33586#issuecomment-3397980836)
Closed the 29.2 milestone: https://github.com/bitcoin/bitcoin/milestone/78.

💬 fanquake commented on issue "Minor Release 29.2":
(https://github.com/bitcoin/bitcoin/issues/33586#issuecomment-3397984360)
Release notes archived in #33610.

💬 fanquake commented on pull request "ci: Properly include $FILE_ENV in DEPENDS_HASH":
(https://github.com/bitcoin/bitcoin/pull/33581#issuecomment-3397985761)
Backported to `29.x` in #33611.

💬 maflcko commented on issue "Version 30 `-datadir=` not working":
(https://github.com/bitcoin/bitcoin/issues/33608#issuecomment-3397996231)
> it should have been front and center in the email, and on the download page.

I am not sure about modifying the download page for a one-off release note snippet. The release notes mention it and the release notes are in the email and on the website.

In any case, it is not possible to go back in time and announce it differently, so I'd say this issue should be closed.

✅ maflcko closed an issue: "Version 30 `-datadir=` not working"
(https://github.com/bitcoin/bitcoin/issues/33608)

💬 maflcko commented on issue "Version 30 `-datadir=` not working":
(https://github.com/bitcoin/bitcoin/issues/33608#issuecomment-3397998511)
Closing for now, but discussion can continue. Also, this issue can be re-opened, when there is need.

📝 Crypt-iQ opened a pull request: "test: change log rate limit version gate from 299900 to 289900"
(https://github.com/bitcoin/bitcoin/pull/33612)
In the case a user on 29.x runs the functional tests and is confused why logs are rate limited in output.

See discussion here: https://github.com/bitcoin/bitcoin/pull/33225#discussion_r2287838255

💬 hebasto commented on pull request "cmake: Get rid of undocumented `BITCOIN_GENBUILD_NO_GIT` environment variable":
(https://github.com/bitcoin/bitcoin/pull/32220#issuecomment-3398016074)
Rebased to refresh the CI.

💬 Waytoogo commented on issue "Version 30 `-datadir=` not working":
(https://github.com/bitcoin/bitcoin/issues/33608#issuecomment-3398016529)
> Closing for now, but discussion can continue. Also, this issue can be re-opened, when there is need.

I'm sorry for all the fuss, but this was very confusing for me. Thank you for your help.

💬 pablomartin4btc commented on pull request "cli: Improve error message on multiwallet cli-side commands":
(https://github.com/bitcoin/bitcoin/pull/26990#issuecomment-3398037313)
> > > Removed validation commit which I'll added in a separate PR as [#26990 (comment)](https://github.com/bitcoin/bitcoin/pull/26990#issuecomment-2354091658) by @jonatack.
> >
> >
> > Does this exist?
>
> So, this was the 2nd commit [3d63fc9](https://github.com/bitcoin/bitcoin/commit/3d63fc976d616436d64335b15a918ffba1883b9a) ...
>
> ... other 2 validations...
> - (a) no params starting with slash "-" will be accepted after a cli-command...
> - (b) duplication of cli-command (and o
...