💬 Waytoogo commented on issue "Version 30 `-datadir=` not working":
(https://github.com/bitcoin/bitcoin/issues/33608#issuecomment-3397625701)
Thank you for fixing the formatting. I'm not very good at this, but I wanted you guys to know about this problem.

💬 maflcko commented on issue "Version 30 `-datadir=` not working":
(https://github.com/bitcoin/bitcoin/issues/33608#issuecomment-3397643805)
Is there a warning about the wallet being BDB, and a suggestion to migrate it? If yes, my recommendation would be to backup the wallet (following your normal backup flow) and then migrate it, using v30.0.

💬 Waytoogo commented on issue "Version 30 `-datadir=` not working":
(https://github.com/bitcoin/bitcoin/issues/33608#issuecomment-3397660956)
No it's just not taking the -datadir= command. In older versions if I put a wrong directory in the command it will tell me the directory does not exist and won't start bitcoin. The new version just starts and completely ignores the -datadir= command and is trying to use the default directory.

💬 maflcko commented on issue "Version 30 `-datadir=` not working":
(https://github.com/bitcoin/bitcoin/issues/33608#issuecomment-3397711941)
Do you have more precise steps to reproduce? Include the full command and the full output for 29.x and 30.x, please.

It works locally:

```
bitcoin-qt -datadir=/tmp/does_not_exist
Error: Specified data directory "/tmp/does_not_exist" does not exist.

💬 Waytoogo commented on issue "Version 30 `-datadir=` not working":
(https://github.com/bitcoin/bitcoin/issues/33608#issuecomment-3397779269)
Yes now that I play with it more, it is opening my data directory, it just doesn't see my wallet. It says
"No wallet has been loaded. Go to File > Open Wallet to load a wallet. If I do that it says [default wallet] [needs migration]. should I click on that and let it migrate my wallet? I didn't know it needed migration. I'm backing everything up before I do anything else.

🤔 pablomartin4btc reviewed a pull request: "qt: add createwallet, createwalletdescriptor, and migratewallet to history filter"
(https://github.com/bitcoin-core/gui/pull/901#pullrequestreview-3331886096)
utACK 4e352efa2ce756c668664486c99d003eef530e0c

_(_`historyFilter` _was originally added in https://github.com/bitcoin/bitcoin/pull/8877)_

🤔 pablomartin4btc reviewed a pull request: "Modernize custom filtering"
(https://github.com/bitcoin-core/gui/pull/899#pullrequestreview-3331894542)
utACK 1a11cacf5225a7534155a9310a5647e7d4876076

_(CentOS CI [failure](https://github.com/bitcoin-core/gui/actions/runs/18352803529/job/52277043612?pr=899) is unrelated_ -
`System.IO.IOException: No space left on device`_)_

💬 Waytoogo commented on issue "Version 30 `-datadir=` not working":
(https://github.com/bitcoin/bitcoin/issues/33608#issuecomment-3397819109)
It wants me to put in my pass phrase to migrate the wallet. I don't see anything about having to migrate the wallet from 29.1 in the release notes. Something is wrong here.

💬 maflcko commented on issue "Version 30 `-datadir=` not working":
(https://github.com/bitcoin/bitcoin/issues/33608#issuecomment-3397857521)
> it says [default wallet] [needs migration]. should I click on that and let it migrate my wallet? I didn't know it needed migration. I'm backing everything up before I do anything else.

Yeah, a backup makes sense. See also my previous reply: "my recommendation would be to backup the wallet (following your normal backup flow) and then migrate it, using v30.0.".



> It wants me to put in my pass phrase to migrate the wallet. I don't see anything about having to migrate the wallet from 29.1 in t
...

📝 fanquake opened a pull request: "[30.x] Backports"
(https://github.com/bitcoin/bitcoin/pull/33609)
Backports:
* #33558
* #33580
* #33581

💬 fanquake commented on pull request "ci: Properly include $FILE_ENV in DEPENDS_HASH":
(https://github.com/bitcoin/bitcoin/pull/33581#issuecomment-3397863875)
Backported to `30.x` in #33609.

💬 fanquake commented on pull request "depends: Use $(package)_file_name when downloading from the fallback":
(https://github.com/bitcoin/bitcoin/pull/33580#issuecomment-3397886271)
Backported to `30.x` in #33609.

🤔 jonatack reviewed a pull request: "rpc: Distinguish between vsize and sigop adjusted mempool vsize"
(https://github.com/bitcoin/bitcoin/pull/32800#pullrequestreview-3331998740)
Concept ACK, appears to clarify these values, and adds a new "vsize_bip141" field to the API while not changing the existing vsize values returned.

🤔 janb84 reviewed a pull request: "Clear out space on GHA jobs"
(https://github.com/bitcoin/bitcoin/pull/33514#pullrequestreview-3332011346)
re ACK 014b9f6268390b78e66e1be24813d3f069588442

changes since last ack:
- The PR is back to only running the `Clear unnecessary files` action on the `'CentOS, depends, gui'`

💬 Aa777263100 commented on pull request "ci: Use native platform for win-cross task":
(https://github.com/bitcoin/bitcoin/pull/33558#issuecomment-3397920077)
> Forcing the architecture to amd64 is no longer required. Dropping it should have some benefits:
>
> * Faster CI speed on other arches (riscv64, arm, ...)
> * Unlock the CI task to run on riscv64 at all

💬 Waytoogo commented on issue "Version 30 `-datadir=` not working":
(https://github.com/bitcoin/bitcoin/issues/33608#issuecomment-3397927607)
I have never had to do a wallet migration before. In the past when a database migration was needed, it was stated very plainly that it would happen, no surprises. This time there is a wallet migration the needs me to put in my pass phrase, and it was mentioned way down in the release notes. The message it gave me when I started bitcoin-qt.exe with my data directory was not helpful, and why I filed an issue. Because it requires you to put in your passphrase, it should have been front and center i
...

📝 fanquake opened a pull request: "doc: archive release notes for v29.2"
(https://github.com/bitcoin/bitcoin/pull/33610)

📝 fanquake opened a pull request: "[29.x] Backports"
(https://github.com/bitcoin/bitcoin/pull/33611)
Backports:
* #33581

💬 fanquake commented on issue "Minor Release 29.2":
(https://github.com/bitcoin/bitcoin/issues/33586#issuecomment-3397980836)
Closed the 29.2 milestone: https://github.com/bitcoin/bitcoin/milestone/78.

💬 fanquake commented on issue "Minor Release 29.2":
(https://github.com/bitcoin/bitcoin/issues/33586#issuecomment-3397984360)
Release notes archived in #33610.