💬 maflcko commented on issue "Intermittent CI network issue downloading assets.json from GitHub":
(https://github.com/bitcoin/bitcoin/issues/33599#issuecomment-3391567312)
https://github.com/bitcoin/bitcoin/actions/runs/18410483211/job/52461242682?pr=33600#step:9:2172

💬 RandyMcMillan commented on pull request "Modernize custom filtering":
(https://github.com/bitcoin-core/gui/pull/899#issuecomment-3391658357)
macOS 14.7.7 (23H723) - confirming build not broken with this change.

```
git at DeepSpaceM1 in /Users/Shared/bitcoincore-dev/.github/bitcoin/pr899.02 on 1916/918471/328849/b510893d00/1a11cacf52-1a11cac [?$]
$ ./bin/test_bitcoin-qt
********* Start testing of AppTests *********
Config: Using QtTest library 6.9.2, Qt 6.9.2 (arm64-little_endian-lp64 shared (dynamic) release build; by Apple LLVM 16.0.0 (clang-1600.0.26.6)), macos 14.7.7
PASS : AppTests::initTestCase()
QWARN : AppTests::
...

🤔 hebasto reviewed a pull request: "guix: update time-machine to 5cb84f2013c5b1e48a7d0e617032266f1e6059e2"
(https://github.com/bitcoin/bitcoin/pull/33185#pullrequestreview-3325369063)
My Guix build:
```
aarch64
c0f071c9bd3236f8faf679f16e9abfb4fba11021135fa70725fb0658196ec707 guix-build-73bea6d39e41/output/aarch64-linux-gnu/SHA256SUMS.part
c09f085cfb26dac9db776fe20729007b3b346da7a136aaaa57c2cb245e0c43f0 guix-build-73bea6d39e41/output/aarch64-linux-gnu/bitcoin-73bea6d39e41-aarch64-linux-gnu-debug.tar.gz
31167a791279e8e68e7187d4782d6badfec67bb4290a34ec2b53bdbdcbf4fc68 guix-build-73bea6d39e41/output/aarch64-linux-gnu/bitcoin-73bea6d39e41-aarch64-linux-gnu.tar.gz
fe0fbc10
...

👍 hebasto approved a pull request: "guix: update time-machine to 5cb84f2013c5b1e48a7d0e617032266f1e6059e2"
(https://github.com/bitcoin/bitcoin/pull/33185#pullrequestreview-3325382329)
re-ACK 73bea6d39e41d273486a17eb87553ad553465124

💬 maflcko commented on pull request "doc: bump the template macOS version since 14 is now the minimum supported version":
(https://github.com/bitcoin/bitcoin/pull/33573#issuecomment-3391830998)
lgtm ACK f6567527d8dafa70335de782511791165bb89ccb

🤔 furszy reviewed a pull request: "index: initial sync speedup, parallelize process"
(https://github.com/bitcoin/bitcoin/pull/26966#pullrequestreview-3325457768)
Rebased to get latest CI updates.

👋 fanquake's pull request is ready for review: "[28.x] 28.3rc2"
(https://github.com/bitcoin/bitcoin/pull/33557)

💬 brunoerg commented on pull request "FUZZ: Test that BnB finds best solution":
(https://github.com/bitcoin/bitcoin/pull/32894#discussion_r2421773084)
> Above 17 UTXOs a fuzz input could be generated whose scenario [exhausts BnB’s iteration limit](https://github.com/bitcoin/bitcoin/blob/23e15d40b96a23112fba24cece5fe513ae1a2877/src/wallet/test/coinselection_tests.cpp#L156) before BnB finds any solution. The invariant that BnB will always find a solution when the brute force algorithm finds a solution no longer holds above 17 UTXOs.

Worth adding a short comment on `max_output_groups ` about this? It would be great to understand this rationale
...

💬 l0rinc commented on pull request "doc: bump the template macOS version since 14 is now the minimum supported version":
(https://github.com/bitcoin/bitcoin/pull/33573#issuecomment-3391920236)
ACK f6567527d8dafa70335de782511791165bb89ccb

The Ubuntu version is a bit far into the future, but I don't mind

💬 maflcko commented on pull request "refactor: Construct g_verify_flag_names on first use":
(https://github.com/bitcoin/bitcoin/pull/33600#issuecomment-3391921802)
<details><summary>for reference, the msan false positive CI logs</summary>

master:

```
...
+ /ci_container_base/ci/scratch/build-aarch64-unknown-linux-gnu/test/fuzz/test_runner.py -j16 -l DEBUG /ci_container_base/ci/scratch/qa-assets/fuzz_corpora/ --empty_min_time=60
==11639==WARNING: MemorySanitizer: use-of-uninitialized-value
#0 0xaaaad25c2408 in SetArgs(int, char**) /ci_container_base/ci/scratch/build-aarch64-unknown-linux-gnu/src/test/fuzz/util/./test/fuzz/fuzz.cpp:52:5
#1
...

💬 glozow commented on pull request "net_processing: rename RelayTransaction to better describe what it does":
(https://github.com/bitcoin/bitcoin/pull/33565#discussion_r2421785265)
If `Queue` is confusing, then I can also suggest MarkTxForRelay or UpdateTxBroadcastSet

I recognize that we can all read verbs differently. I'm just pointing out that "schedule" in this codebase almost always means putting a task on the `scheduler` background thread with a specific time.

🤔 janb84 reviewed a pull request: "doc: bump the template macOS version since 14 is now the minimum supported version"
(https://github.com/bitcoin/bitcoin/pull/33573#pullrequestreview-3325542629)
ACK f6567527d8dafa70335de782511791165bb89ccb

With just recent references there is no discussion anymore if it is supported or not. Just examples of what someone can fill in.

💬 andrewtoth commented on pull request "net_processing: rename RelayTransaction to better describe what it does":
(https://github.com/bitcoin/bitcoin/pull/33565#discussion_r2421877692)
How about `RelayTransactionAfterDelay`?

📝 RandyMcMillan opened a pull request: "rpcnestedtests.cpp:remove qtest-obsolete members"
(https://github.com/bitcoin-core/gui/pull/900)

💬 RandyMcMillan commented on pull request "Modernize custom filtering":
(https://github.com/bitcoin-core/gui/pull/899#issuecomment-3392054463)
@hebasto - while testing this PR - I noticed this can be updated.

https://github.com/bitcoin-core/gui/pull/900

💬 RandyMcMillan commented on pull request "rpcnestedtests.cpp:remove qtest-obsolete members":
(https://github.com/bitcoin-core/gui/pull/900#issuecomment-3392082488)
I will remove 4f29ddf3c5cbd373ebbfe05e5cd571cc9b383b0c if requested.

💬 1440000bytes commented on issue "No way to clear command history in RPC console or reset the console without restarting the node":
(https://github.com/bitcoin-core/gui/issues/897#issuecomment-3392088866)
> The output gets cleared and the input remains regardless if you close wallet, RPC console. It only resets by restarting the node

This is a bug and core does not clear the history for `migratewallet` RPC from the console.

```C++
// don't add private key handling cmd's to the history
const QStringList historyFilter = QStringList()
<< "signmessagewithprivkey"
<< "signrawtransactionwithkey"
<< "walletpassphrase"
<< "walletpassphrasechange"
<< "encryptwallet";


}
```
https://
...

🚀 fanquake merged a pull request: "doc: bump the template macOS version"
(https://github.com/bitcoin/bitcoin/pull/33573)

💬 glozow commented on issue "test: intermittent issue in p2p_1p1c_network.py":
(https://github.com/bitcoin/bitcoin/issues/33318#issuecomment-3392126924)
> The test does the disconnect earlier but from socket closing to clearing of peer state, this race can occur.

If it's a race, then this should go away if we make node3 the one that pre-receives orphans?


```diff

diff --git a/test/functional/p2p_1p1c_network.py b/test/functional/p2p_1p1c_network.py
index e4d3b738c19..5567b4e7002 100755
--- a/test/functional/p2p_1p1c_network.py
+++ b/test/functional/p2p_1p1c_network.py
@@ -109,14 +109,14 @@ class PackageRelayTest(BitcoinTestFramework):

...

💬 hebasto commented on pull request "rpcnestedtests.cpp:remove qtest-obsolete members":
(https://github.com/bitcoin-core/gui/pull/900#discussion_r2421952199)
The minimum supported Qt version [remains 6.2 for now](https://github.com/bitcoin/bitcoin/blob/master/doc/dependencies.md#build-1).