💬 willcl-ark commented on issue "Intermittent CI network issue downloading assets.json from GitHub":
(https://github.com/bitcoin/bitcoin/issues/33599#issuecomment-3391178427)
I have reached out to Cirrus to see if they aware of any rate-limiting or anything else which could cause this.

💬 GrayHatGuy commented on issue "Intermittent CI network issue downloading assets.json from GitHub":
(https://github.com/bitcoin/bitcoin/issues/33599#issuecomment-3391210443)
It's probably due to all the non-financial op_return data polluting the chain

🤔 brunoerg reviewed a pull request: "index: initial sync speedup, parallelize process"
(https://github.com/bitcoin/bitcoin/pull/26966#pullrequestreview-3324866101)
Left the fuzz target (`threadpool`) running overnight, performance is reasonable and didn't get any memory leak. I generated a coverage report at https://brunoerg.xyz/bitcoin-core-coverage/26966/coverage_report/.

💬 instagibbs commented on issue "test: intermittent issue in p2p_1p1c_network.py":
(https://github.com/bitcoin/bitcoin/issues/33318#issuecomment-3391409712)
I think I've nailed down what's happening from logs:

1. test peer sends child to node1
2. node1 has parent resolved normally, it's above minfee
3. test peer is picked as unique peer to schedule resolution of child during test peer's next "turn" in networking thread
4. node0 advertises child by wtxid (it's ignored currently because it's in orphanage and has no missing deps)
5. test peer disconnects before ProcessOrphanTx is called (and we never reconsider the orphan again because all parents are
...

💬 furszy commented on pull request "index: initial sync speedup, parallelize process":
(https://github.com/bitcoin/bitcoin/pull/26966#issuecomment-3391433693)
> Left the fuzz target (`threadpool`) running overnight, performance is reasonable and didn't get any memory leak. I generated a coverage report at https://brunoerg.xyz/bitcoin-core-coverage/26966/coverage_report/.

Both awesome news! Added report link to the PR description. Thanks!

💬 maflcko commented on issue "Intermittent CI network issue downloading assets.json from GitHub":
(https://github.com/bitcoin/bitcoin/issues/33599#issuecomment-3391567312)
https://github.com/bitcoin/bitcoin/actions/runs/18410483211/job/52461242682?pr=33600#step:9:2172

💬 RandyMcMillan commented on pull request "Modernize custom filtering":
(https://github.com/bitcoin-core/gui/pull/899#issuecomment-3391658357)
macOS 14.7.7 (23H723) - confirming build not broken with this change.

```
git at DeepSpaceM1 in /Users/Shared/bitcoincore-dev/.github/bitcoin/pr899.02 on 1916/918471/328849/b510893d00/1a11cacf52-1a11cac [?$]
$ ./bin/test_bitcoin-qt
********* Start testing of AppTests *********
Config: Using QtTest library 6.9.2, Qt 6.9.2 (arm64-little_endian-lp64 shared (dynamic) release build; by Apple LLVM 16.0.0 (clang-1600.0.26.6)), macos 14.7.7
PASS : AppTests::initTestCase()
QWARN : AppTests::
...

🤔 hebasto reviewed a pull request: "guix: update time-machine to 5cb84f2013c5b1e48a7d0e617032266f1e6059e2"
(https://github.com/bitcoin/bitcoin/pull/33185#pullrequestreview-3325369063)
My Guix build:
```
aarch64
c0f071c9bd3236f8faf679f16e9abfb4fba11021135fa70725fb0658196ec707 guix-build-73bea6d39e41/output/aarch64-linux-gnu/SHA256SUMS.part
c09f085cfb26dac9db776fe20729007b3b346da7a136aaaa57c2cb245e0c43f0 guix-build-73bea6d39e41/output/aarch64-linux-gnu/bitcoin-73bea6d39e41-aarch64-linux-gnu-debug.tar.gz
31167a791279e8e68e7187d4782d6badfec67bb4290a34ec2b53bdbdcbf4fc68 guix-build-73bea6d39e41/output/aarch64-linux-gnu/bitcoin-73bea6d39e41-aarch64-linux-gnu.tar.gz
fe0fbc10
...

👍 hebasto approved a pull request: "guix: update time-machine to 5cb84f2013c5b1e48a7d0e617032266f1e6059e2"
(https://github.com/bitcoin/bitcoin/pull/33185#pullrequestreview-3325382329)
re-ACK 73bea6d39e41d273486a17eb87553ad553465124

💬 maflcko commented on pull request "doc: bump the template macOS version since 14 is now the minimum supported version":
(https://github.com/bitcoin/bitcoin/pull/33573#issuecomment-3391830998)
lgtm ACK f6567527d8dafa70335de782511791165bb89ccb

🤔 furszy reviewed a pull request: "index: initial sync speedup, parallelize process"
(https://github.com/bitcoin/bitcoin/pull/26966#pullrequestreview-3325457768)
Rebased to get latest CI updates.

👋 fanquake's pull request is ready for review: "[28.x] 28.3rc2"
(https://github.com/bitcoin/bitcoin/pull/33557)

💬 brunoerg commented on pull request "FUZZ: Test that BnB finds best solution":
(https://github.com/bitcoin/bitcoin/pull/32894#discussion_r2421773084)
> Above 17 UTXOs a fuzz input could be generated whose scenario [exhausts BnB’s iteration limit](https://github.com/bitcoin/bitcoin/blob/23e15d40b96a23112fba24cece5fe513ae1a2877/src/wallet/test/coinselection_tests.cpp#L156) before BnB finds any solution. The invariant that BnB will always find a solution when the brute force algorithm finds a solution no longer holds above 17 UTXOs.

Worth adding a short comment on `max_output_groups ` about this? It would be great to understand this rationale
...

💬 l0rinc commented on pull request "doc: bump the template macOS version since 14 is now the minimum supported version":
(https://github.com/bitcoin/bitcoin/pull/33573#issuecomment-3391920236)
ACK f6567527d8dafa70335de782511791165bb89ccb

The Ubuntu version is a bit far into the future, but I don't mind

💬 maflcko commented on pull request "refactor: Construct g_verify_flag_names on first use":
(https://github.com/bitcoin/bitcoin/pull/33600#issuecomment-3391921802)
<details><summary>for reference, the msan false positive CI logs</summary>

master:

```
...
+ /ci_container_base/ci/scratch/build-aarch64-unknown-linux-gnu/test/fuzz/test_runner.py -j16 -l DEBUG /ci_container_base/ci/scratch/qa-assets/fuzz_corpora/ --empty_min_time=60
==11639==WARNING: MemorySanitizer: use-of-uninitialized-value
#0 0xaaaad25c2408 in SetArgs(int, char**) /ci_container_base/ci/scratch/build-aarch64-unknown-linux-gnu/src/test/fuzz/util/./test/fuzz/fuzz.cpp:52:5
#1
...

💬 glozow commented on pull request "net_processing: rename RelayTransaction to better describe what it does":
(https://github.com/bitcoin/bitcoin/pull/33565#discussion_r2421785265)
If `Queue` is confusing, then I can also suggest MarkTxForRelay or UpdateTxBroadcastSet

I recognize that we can all read verbs differently. I'm just pointing out that "schedule" in this codebase almost always means putting a task on the `scheduler` background thread with a specific time.

🤔 janb84 reviewed a pull request: "doc: bump the template macOS version since 14 is now the minimum supported version"
(https://github.com/bitcoin/bitcoin/pull/33573#pullrequestreview-3325542629)
ACK f6567527d8dafa70335de782511791165bb89ccb

With just recent references there is no discussion anymore if it is supported or not. Just examples of what someone can fill in.

💬 andrewtoth commented on pull request "net_processing: rename RelayTransaction to better describe what it does":
(https://github.com/bitcoin/bitcoin/pull/33565#discussion_r2421877692)
How about `RelayTransactionAfterDelay`?

📝 RandyMcMillan opened a pull request: "rpcnestedtests.cpp:remove qtest-obsolete members"
(https://github.com/bitcoin-core/gui/pull/900)

💬 RandyMcMillan commented on pull request "Modernize custom filtering":
(https://github.com/bitcoin-core/gui/pull/899#issuecomment-3392054463)
@hebasto - while testing this PR - I noticed this can be updated.

https://github.com/bitcoin-core/gui/pull/900