💬 sipa commented on pull request "cluster mempool: control/optimize TxGraph memory usage":
(https://github.com/bitcoin/bitcoin/pull/33157#discussion_r2417305579)
Seems unrelated to this PR.

💬 earonesty commented on pull request "policy: uncap datacarrier by default":
(https://github.com/bitcoin/bitcoin/pull/32406#issuecomment-3386603198)
- agreed that it must evolve to "settlement", but disagree that lowering
blocksize won't help. aggregate fee per block will strictly increase as
block space is limited.

- maturing is lovely, but bitcoin's goal is decentralization and
censorship resistant p2p electronic cash

- we don't need an "ecosystem of shitcoins". but we do need a way to
batch enter and unilaterally exit a vtxo for us to get a robust layer 2
that anyone can safely use


On Wed, Oct 8, 2025 at 5:04 PM Wycli
...

💬 Crypt-iQ commented on pull request "fuzz: compact block harness":
(https://github.com/bitcoin/bitcoin/pull/33300#discussion_r2417331534)
Some signals are not caught by the fuzzer, so if it creates a datadir (i.e. `process_messages`) and you Ctrl-C, it will leave it around instead of deleting it in `~BasicTestingSetup`. In any case, not using `g_rng_temp_path` seems like the right choice.

💬 hebasto commented on pull request "Revert "depends: Update URL for `qrencode` package source tarball"":
(https://github.com/bitcoin/bitcoin/pull/33577#issuecomment-3386621614)
> Just checking someone has the original tarball?

I have:
```
$ sha256sum sources/qrencode-4.1.1.tar.gz
da448ed4f52aba6bcb0cd48cac0dd51b8692bccc4cd127431402fca6f8171e8e sources/qrencode-4.1.1.tar.gz
```

⚠️ glozow opened an issue: "Minor Release 29.2"
(https://github.com/bitcoin/bitcoin/issues/33586)
Backports
- #33344
- #33474
- #33403

RC 1:
- [x] final changes #33344
- [x] tag
- [x] upload binaries

RC 2:
- [x] final changes #33534
- [x] tag
- [x] upload binaries
- [x] announcements

Final version:
- [ ] final changes
- [ ] tag
- [ ] upload binaries
- [ ] announcements
- [ ] archive release notes
- [ ] github release

See [release process docs](https://github.com/bitcoin/bitcoin/blob/master/doc/release-process.md) for more details. This issue can be used to track status updates. Please fe
...

💬 glozow commented on issue "Minor Release 29.2":
(https://github.com/bitcoin/bitcoin/issues/33586#issuecomment-3386635593)
rc1 bins: https://bitcoincore.org/bin/bitcoin-core-29.2/test.rc1/
rc2 bins: https://bitcoincore.org/bin/bitcoin-core-29.2/test.rc2/

announcements for release candidates:
https://delvingbitcoin.org/t/bitcoin-core-v29-2-release-candidate-available/2036
https://groups.google.com/g/bitcoindev/c/FAebgCmXOKs

💬 TheCharlatan commented on pull request "kernel: Introduce initial C header API":
(https://github.com/bitcoin/bitcoin/pull/30595#issuecomment-3386641151)
Updated 2a80cd9f1db45dfc1775ded6698b034691e7bf2d -> 81cec737e68b91f5edf90179b81aa620a5a68677 ([kernelApi_72](https://github.com/TheCharlatan/bitcoin/tree/kernelApi_72) -> [kernelApi_73](https://github.com/TheCharlatan/bitcoin/tree/kernelApi_73), [compare](https://github.com/TheCharlatan/bitcoin/compare/kernelApi_72..kernelApi_73))

* Addressed @ismaelsadeeq's [comment](https://github.com/bitcoin/bitcoin/pull/30595#discussion_r2416004410), removed confusing notice in message printed by bitcoin-
...

📝 bavani-2024-aia opened a pull request: "No remote repository configured (fatal: 'origin' does not appear to be a git repository)Add files via upload"
(https://github.com/bitcoin/bitcoin/pull/33587)
While trying to push local commits to GitHub using git push -u origin master, Git returned the error:

fatal: 'origin' does not appear to be a git repository
fatal: Could not read from remote repository.


This happens because the local repository is not linked to any remote repository. Git cannot find a remote named origin, so it doesn’t know where to push the commits.

Cause:

The repository was initialized locally using git init.

No remote repository (on GitHub or other Git hosti
...

👍 brunoerg approved a pull request: "test: add functional test for `TestShell` (matching doc example)"
(https://github.com/bitcoin/bitcoin/pull/33546#pullrequestreview-3319800382)
ACK 57f7c68821d96cc096db624cb06b7a252d038300

💬 sipa commented on pull request "cluster mempool: control/optimize TxGraph memory usage":
(https://github.com/bitcoin/bitcoin/pull/33157#discussion_r2417370157)
Yeah, extracting is seen as moving to the "none" quality level.

💬 sipa commented on pull request "cluster mempool: control/optimize TxGraph memory usage":
(https://github.com/bitcoin/bitcoin/pull/33157#discussion_r2417374122)
This matches the code that's already in GenericClusterImpl.

💬 ryanofsky commented on issue "RFC: Cancelling waitNext calls in the IPC mining interface":
(https://github.com/bitcoin/bitcoin/issues/33575#issuecomment-3386691100)
re: https://github.com/bitcoin/bitcoin/issues/33575#issuecomment-3386438916

> I guess in theory they could be unified into a single loop, however `interruptWait` would have to be called whenever **some** incoming Sv2 message arrived, not only if that was a `CoinbaseOutputConstraints`.

This is surprising to me, but it sounds like this justifies using two loops to avoid pointless `interruptWait` and `waitNext` churn.

In python pseudocode above, waitNext promise is stored in the `next_block` var
...

💬 instagibbs commented on pull request "[30.x] Finalise v30.0":
(https://github.com/bitcoin/bitcoin/pull/33559#issuecomment-3386708420)
ACK d615eb6998eeccb9106854dffa95f36b319177e1

reviewed the release notes

💬 glozow commented on pull request "net_processing: rename RelayTransaction to better describe what it does":
(https://github.com/bitcoin/bitcoin/pull/33565#discussion_r2417392577)
Fwiw I don't agree with this either as we are not scheduling anything, and ForceRelay is the name of the permission.

💬 theStack commented on pull request "Rollback for dumptxoutset without invalidating blocks":
(https://github.com/bitcoin/bitcoin/pull/33477#issuecomment-3386727879)
Concept ACK

📝 bavani-2024-aia opened a pull request: "config.ini headers missing causes test framework failure"
(https://github.com/bitcoin/bitcoin/pull/33588)
The functional tests in the repository fail because the config.ini file is missing proper section headers, causing the test framework to throw a MissingSectionHeaderError.

This occurs when running tests like mempool_ephemeral_dust.py, producing the following error:

configparser.MissingSectionHeaderError: File contains no section headers.
file: '.../test/config.ini', line: 1
'[environment]\n'


The root cause is either a missing [environment] header or an invisible BOM (Byte Order M
...

📝 bavani-2024-aia opened a pull request: "config.ini headers missing causes test framework failure"
(https://github.com/bitcoin/bitcoin/pull/33589)
The functional tests in the repository fail because the config.ini file is missing proper section headers, causing the test framework to throw a MissingSectionHeaderError.

This occurs when running tests like mempool_ephemeral_dust.py, producing the following error:

configparser.MissingSectionHeaderError: File contains no section headers.
file: '.../test/config.ini', line: 1
'[environment]\n'


The root cause is either a missing [environment] header or an invisible BOM (Byte Order M
...

🤔 andrewtoth reviewed a pull request: "node: change a tx-relay on/off flag to enum"
(https://github.com/bitcoin/bitcoin/pull/33567#pullrequestreview-3319681241)
Not sure we should add comments (yet) that suggest adding to the mempool is optional. With this change it is still always added unless it already exists. In the change for private broadcast there are a few comments that can be updated.

💬 andrewtoth commented on pull request "node: change a tx-relay on/off flag to enum":
(https://github.com/bitcoin/bitcoin/pull/33567#discussion_r2417297799)
The transaction is passed by const ref, so it's not really "consuming" it. Perhaps "Process a local transaction"?

💬 andrewtoth commented on pull request "node: change a tx-relay on/off flag to enum":
(https://github.com/bitcoin/bitcoin/pull/33567#discussion_r2417280933)
This parameter does not allow the caller to decide whether to add the transaction to the mempool (yet).