💬 furszy commented on pull request "doc: how to update a subtree":
(https://github.com/bitcoin/bitcoin/pull/33568#discussion_r2411126967)
Need to add the remote first. E.g.
```
git remote add libmultiprocess <repo_URL>
git subtree pull --prefix=src/ipc/libmultiprocess libmultiprocess master --squash
```

👍 willcl-ark approved a pull request: "[27.x] Fix Qt download URLs"
(https://github.com/bitcoin/bitcoin/pull/33564#pullrequestreview-3310847305)
utACK 9652f4754d93c41f224f29b41110ebd21f55d976

Backports look OK.

💬 andrewtoth commented on pull request "index: initial sync speedup, parallelize process":
(https://github.com/bitcoin/bitcoin/pull/26966#discussion_r2411161631)
Any reason we can't use `memory_order_relaxed` on loads and stores of `m_interrupt`?

💬 Sjors commented on pull request "doc: how to update a subtree":
(https://github.com/bitcoin/bitcoin/pull/33568#discussion_r2411169370)
That's explained in the linter doc that's linked right above, but I can duplicate it if needed.

👍 theuni approved a pull request: "Update libmultiprocess subtree to support reduced logging"
(https://github.com/bitcoin/bitcoin/pull/33518#pullrequestreview-3311068924)
utACK eda91b07fd9f2a6af3c31659d51f51aacf8989c4.

The upstream changes are good ones and this is a good time to sync up.

💬 monlovesmango commented on pull request "wallet: don't consider unconfirmed TRUC coins with ancestors":
(https://github.com/bitcoin/bitcoin/pull/33528#issuecomment-3377833421)
Wow so on top of it @glozow :)

A couple things.

When I went back to test the commands I pasted in https://github.com/bitcoin/bitcoin/issues/33368#issuecomment-3319935660 I found that it was still failing silently despite the functional test failing appropriately. I was able to tweak the functional test a bit and get it to also mimic the silent failing behavior in this branch:
https://github.com/monlovesmango/bitcoin/tree/pr33528-functional-test-tweak
I am still trying to figure out the
...

💬 Crypt-iQ commented on pull request "fuzz: compact block harness":
(https://github.com/bitcoin/bitcoin/pull/33300#discussion_r2411373516)
Are you fuzzing with persistent mode?

👍 hebasto approved a pull request: "[27.x] Fix Qt download URLs"
(https://github.com/bitcoin/bitcoin/pull/33564#pullrequestreview-3311244901)
ACK 9652f4754d93c41f224f29b41110ebd21f55d976.

💬 fjahr commented on pull request "doc: how to update a subtree":
(https://github.com/bitcoin/bitcoin/pull/33568#discussion_r2411433522)
Might be good to duplicate for the avoidance of doubt.

💬 fjahr commented on pull request "doc: how to update a subtree":
(https://github.com/bitcoin/bitcoin/pull/33568#issuecomment-3377941576)
Looks good to me, this matches what I run to get experimental secp branches. I think @furszy 's comment should be addressed then this should be good to go.

🤔 Ystel2001 reviewed a pull request: "[29.x] finalise v29.1"
(https://github.com/bitcoin/bitcoin/pull/33271#pullrequestreview-3311286244)
SSH

💬 epiccurious commented on issue "30.0 RC Testing Guide Feedback":
(https://github.com/bitcoin/bitcoin/issues/33369#issuecomment-3377969964)
Nit feedback -

> Before compiling, make sure that your system has all the correct [dependencies](https://github.com/bitcoin/bitcoin/blob/master/doc/dependencies.md) installed (note the new Cap'n proto (optional) build dependency)

`(optional)` should be either removed or changed to `(required by default)`, since capnp is now required unless disabled with the `DENABLE_IPC=OFF` cmake option.

For example:

> Before compiling, make sure that your system has all the correct [dependencies](https://g
...

💬 janb84 commented on issue "30.0 RC Testing Guide Feedback":
(https://github.com/bitcoin/bitcoin/issues/33369#issuecomment-3377982088)
> Nit feedback -
>
> > Before compiling, make sure that your system has all the correct [dependencies](https://github.com/bitcoin/bitcoin/blob/master/doc/dependencies.md) installed (note the new Cap'n proto (optional) build dependency)
>
> `(optional)` should be either removed or changed to `(required by default)`, since capnp is now required unless disabled with the `DENABLE_IPC=OFF` cmake option.
>
> For example:
>
> > Before compiling, make sure that your system has all the correct [depen
...

🤔 stickies-v reviewed a pull request: "validation: Improve warnings in case of chain corruption"
(https://github.com/bitcoin/bitcoin/pull/33553#pullrequestreview-3309605995)
Approach ACK, agreed that something non-invasive like logging is the way to go here.

💬 stickies-v commented on pull request "validation: Improve warnings in case of chain corruption":
(https://github.com/bitcoin/bitcoin/pull/33553#discussion_r2410252917)
nit: trivial docstring, would prefer removing (or elaborating)

💬 stickies-v commented on pull request "validation: Improve warnings in case of chain corruption":
(https://github.com/bitcoin/bitcoin/pull/33553#discussion_r2411490892)
nit to respect line-length, clang-format and grammatically make things clearer that the peer in question did not send the previous version of the header:

<details>
<summary>git diff on d55830cd50</summary>

```diff
diff --git a/src/net_processing.cpp b/src/net_processing.cpp
index 073a434335..4574c6cf19 100644
--- a/src/net_processing.cpp
+++ b/src/net_processing.cpp
@@ -2957,8 +2957,10 @@ void PeerManagerImpl::ProcessHeadersMessage(CNode& pfrom, Peer& peer,
if (!processed) {

...

💬 Sjors commented on pull request "doc: how to update a subtree":
(https://github.com/bitcoin/bitcoin/pull/33568#discussion_r2411501268)
Done

💬 vasild commented on issue "build: depends sqlite compile failure for FreeBSD Clang cross":
(https://github.com/bitcoin/bitcoin/issues/33560#issuecomment-3378059234)
When I run this on Ubuntu 24.04.3 I get:

```sh
$ make -C depends/ HOST=aarch64-unknown-freebsd CC=clang CXX=clang++ CFLAGS="--sysroot=/path/to/sysroot/ " CXXFLAGS="--sysroot=/path/to/sysroot/ -stdlib=libc++" LDFLAGS="-fuse-ld=lld" AR=llvm-ar STRIP=llvm-strip NM=llvm-nm RANLIB=llvm-ranlib NO_QT=1
...
Configuring boost...
-- The CXX compiler identification is Clang 18.1.3
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - failed
-- Check for working CXX compiler: /usr/bin/cla
...

💬 stringintech commented on pull request "fuzz: compact block harness":
(https://github.com/bitcoin/bitcoin/pull/33300#discussion_r2411570436)
Yes. I am compiling using `afl-clang-fast++` (it seems that other options are either unavailable or obsolete on macOS). However, I just added a `#undef __AFL_LOOP` at the top of `fuzz.cpp` to disable persistent mode (I made sure I no longer see the `[+] Persistent mode binary detected` log when running) and reverted the above change to `rand_path()`, but the same crash still occurs.

💬 l0rinc commented on pull request "validation: fetch block inputs on parallel threads >10% faster IBD":
(https://github.com/bitcoin/bitcoin/pull/31132#issuecomment-3378291849)
Compared it against master on a Raspberry Pi 5 synchronizing from real peers for realism, ran it twice for good measure until 917000 blocks with dbcache 450:

This isn't the [latest version](https://github.com/bitcoin/bitcoin/compare/a8f9a806751b5755bdec5b096186f70c0bfddcfa..cf209da104d483aa064aa3bec621f1adc9574749) of the PR, but should likely be representative anyway.

<details>
<summary>First run: 19% faster, finished IBD in 13h:11m | IBD | 917000 blocks | dbcache 450 | rpi5-16-2 | aarch
...