💬 maflcko commented on pull request "ci: Use native platform for win-cross task":
(https://github.com/bitcoin/bitcoin/pull/33558#issuecomment-3376554869)
> Error: invalid platform syntax for "linux" (use OS/ARCH[/VARIANT][,...])

thanks for testing. However, this looks like an unrelated issue with your podman version. I presume you can't run any native task at all. My recommendation would be to upgrade your os (or podman) to the latest stable version.

💬 andrewtoth commented on pull request "index: initial sync speedup, parallelize process":
(https://github.com/bitcoin/bitcoin/pull/26966#discussion_r2410469877)
It went well thanks https://github.com/bitcoin/bitcoin/commit/0030dc5ba46da402d36edd5cb32492397deeae7f
Sorry for hijacking the PR :)

📝 fanquake opened a pull request: "[29.x] build: fix depends Qt download link"
(https://github.com/bitcoin/bitcoin/pull/33563)
Fix Qt download path, so we wont always hit the fallback.

💬 hebasto commented on pull request "[28.x] ci: Fix Qt 5.15 URL":
(https://github.com/bitcoin/bitcoin/pull/33561#issuecomment-3376706733)
Closing in favour of https://github.com/bitcoin/bitcoin/pull/33563.

👍 hebasto approved a pull request: "[29.x] build: fix depends Qt download link"
(https://github.com/bitcoin/bitcoin/pull/33563#pullrequestreview-3309931772)
ACK abf4a6eeaee116917dafd56eb9caee03e13048d2.

👍 hebasto approved a pull request: "ci: remove 3rd party js from windows dll gha job"
(https://github.com/bitcoin/bitcoin/pull/32513#pullrequestreview-3310010920)
ACK 156927903d64297500dd73380908c654b07bfb1a.

🚀 fanquake merged a pull request: "[29.x] build: fix depends Qt download link"
(https://github.com/bitcoin/bitcoin/pull/33563)

💬 ryanofsky commented on issue "build: `libcapnp*.so` "warning: GCS is required by -z gcs, but this shared library lacks the necessary property note."":
(https://github.com/bitcoin/bitcoin/issues/33556#issuecomment-3376812594)
It seems like ideal solution would be to get debian to build capnproto package with GCS, maybe submitting a patch or issue requesting this. There should be no downside to enabling GCS, since it modifies return instructions but is otherwise ABI compatible, and the GCS feature can be turned on and off per thread at runtime. Only difficultly may be that capnproto dependencies (openssl and zlib) will also need to be built with GCS. There's a debian page at https://wiki.debian.org/ToolChain/GCS with
...

💬 fanquake commented on issue "build: `libcapnp*.so` "warning: GCS is required by -z gcs, but this shared library lacks the necessary property note."":
(https://github.com/bitcoin/bitcoin/issues/33556#issuecomment-3376823119)
> Assuming the same warning happen when when building other binaries like bitcoind and test_bitcoin it's probably not worth it.

There are no other linker warnings for any other binaries.

💬 fanquake commented on pull request "[29.x] build: fix depends Qt download link":
(https://github.com/bitcoin/bitcoin/pull/33563#issuecomment-3376826209)
Backported to 28.x in #33557.

💬 ryanofsky commented on issue "[`v30.0rc3`]`bitcoin-node` aborts with mining IPC interface usage":
(https://github.com/bitcoin/bitcoin/issues/33554#issuecomment-3376864778)
Just to be clear about next steps, the node aborts should be prevented by https://github.com/bitcoin-core/libmultiprocess/pull/214 which is set to be backported in https://github.com/bitcoin/bitcoin/pull/33519. (The aborts were originally intentional but are an unnecessarily harsh way to fail, so those PR's replace them with IPC "thread busy" errors.)

Regardless of this, the rust client code needs to be changed to either not make other IPC calls at the same time as there is an active `waitNext(
...

💬 ryanofsky commented on issue "build: `libcapnp*.so` "warning: GCS is required by -z gcs, but this shared library lacks the necessary property note."":
(https://github.com/bitcoin/bitcoin/issues/33556#issuecomment-3376909971)
> > Assuming the same warning happen when when building other binaries like bitcoind and test_bitcoin it's probably not worth it.
>
> There are no other linker warnings for any other binaries.

Sorry was mistaken: there should not be a warning for `bitcoind` because that is not linked against capnproto. But I would expect warnings to appear when linking `bitcoin-node` and `test_bitcoin`. It would be unexpected if make VERBOSE=1 output showed `bitcoin-node` being linked `libcapnp.so` but not pro
...

🤔 stratospher reviewed a pull request: "Improve LastCommonAncestor performance + add tests"
(https://github.com/bitcoin/bitcoin/pull/33515#pullrequestreview-3310200173)
ACK 3635d62f5a935801e26a0d5fa2cb5e2dbbb42f9b.

Seems to work better when there are fewer but deeper forks.

Got this when running each LCA algorithm 10,000 times on the same block pairs in the same block constellation:


- No forks - kind of same
LastCommonAncestor : 962us
NaiveLastCommonAncestor : 986us

- 0.1% forks - 18x slower
LastCommonAncestor : 1103us
NaiveLastCommonAncestor : 20481us

- 0.5% forks - 11x slower
LastCommonAncestor : 1030us
NaiveLastCommonAncestor : 11591us
...

💬 fanquake commented on pull request "[28.x] ci: Fix Qt 5.15 URL":
(https://github.com/bitcoin/bitcoin/pull/33561#issuecomment-3376996728)
ACK 2cd432dc6dad1b9f97d1c791ff1c1b0dd25a8db6

🚀 fanquake merged a pull request: "[28.x] ci: Fix Qt 5.15 URL"
(https://github.com/bitcoin/bitcoin/pull/33561)

💬 furszy commented on pull request "index: initial sync speedup, parallelize process":
(https://github.com/bitcoin/bitcoin/pull/26966#discussion_r2410734769)
> It went well thanks [0030dc5](https://github.com/bitcoin/bitcoin/commit/0030dc5ba46da402d36edd5cb32492397deeae7f)
> Sorry for hijacking the PR :)

hehe np, I owe you a few reviews anyway.

📝 fanquake opened a pull request: "[27.x] Fix Qt download URLs"
(https://github.com/bitcoin/bitcoin/pull/33564)
Backports:
* #33561
* #33563

💬 ryanofsky commented on pull request "Update libmultiprocess subtree to support reduced logging":
(https://github.com/bitcoin/bitcoin/pull/33518#issuecomment-3377126580)
<!-- begin push-2 -->
Updated 0e3fd1142c45f8feced5a4cfff3ed654e450310f -> 2e24e1c7331105ab141b3d734c19a2ccf857c293 ([`pr/subtree-6.1`](https://github.com/ryanofsky/bitcoin/commits/pr/subtree-6.1) -> [`pr/subtree-6.2`](https://github.com/ryanofsky/bitcoin/commits/pr/subtree-6.2), [compare](https://github.com/ryanofsky/bitcoin/compare/pr/subtree-6.1..pr/subtree-6.2))<!-- end --> adding https://github.com/bitcoin-core/libmultiprocess/pull/222 to fix CI errors

<!-- begin push-3 -->
Updated 2e24
...

👋 ryanofsky's pull request is ready for review: "Update libmultiprocess subtree to support reduced logging"
(https://github.com/bitcoin/bitcoin/pull/33518)

💬 ryanofsky commented on pull request "Update libmultiprocess subtree in 30.x branch":
(https://github.com/bitcoin/bitcoin/pull/33519#issuecomment-3377143022)
<!-- begin push-2 -->
Updated 8c0c0bf1b078bc931965418ef9b28d176d57db0d -> ae63cc4bf2d25a5b7ce9d166aa288431e8ca16a7 ([`pr/subtree-6-v30.1`](https://github.com/ryanofsky/bitcoin/commits/pr/subtree-6-v30.1) -> [`pr/subtree-6-v30.2`](https://github.com/ryanofsky/bitcoin/commits/pr/subtree-6-v30.2), [compare](https://github.com/ryanofsky/bitcoin/compare/pr/subtree-6-v30.1..pr/subtree-6-v30.2))<!-- end --> adding https://github.com/bitcoin-core/libmultiprocess/pull/222 and https://github.com/bitcoin-
...