🤔 w0xlt reviewed a pull request: "argsman, cli: GNU-style command-line option parsing (allows options after non-option arguments)"
(https://github.com/bitcoin/bitcoin/pull/33540#pullrequestreview-3302396406)
Concept ACK
(https://github.com/bitcoin/bitcoin/pull/33540#pullrequestreview-3302396406)
Concept ACK
👍 hebasto approved a pull request: "build: Drop support for EOL macOS 13"
(https://github.com/bitcoin/bitcoin/pull/33489#pullrequestreview-3302397689)
ACK 1aaaaa078bb2efed126e3f41ecf7c81ccf005818.
(https://github.com/bitcoin/bitcoin/pull/33489#pullrequestreview-3302397689)
ACK 1aaaaa078bb2efed126e3f41ecf7c81ccf005818.
💬 pinheadmz commented on pull request "argsman, cli: GNU-style command-line option parsing (allows options after non-option arguments)":
(https://github.com/bitcoin/bitcoin/pull/33540#issuecomment-3369083619)
> Such good news. Hard to believe this PR doesn't reference an existing user request.
>
>
This comment does not contribute to the technical discussion. Please put in more effort in the future or you may be banned.
(https://github.com/bitcoin/bitcoin/pull/33540#issuecomment-3369083619)
> Such good news. Hard to believe this PR doesn't reference an existing user request.
>
>
This comment does not contribute to the technical discussion. Please put in more effort in the future or you may be banned.
🤔 furszy reviewed a pull request: "Improve LastCommonAncestor performance + add tests"
(https://github.com/bitcoin/bitcoin/pull/33515#pullrequestreview-3302435512)
ACK 3635d62f5a935801e26a0d5fa2cb5e2dbbb42f9b
(https://github.com/bitcoin/bitcoin/pull/33515#pullrequestreview-3302435512)
ACK 3635d62f5a935801e26a0d5fa2cb5e2dbbb42f9b
💬 timorkon commented on issue "Faster way to get block with prevouts in JSON-RPC":
(https://github.com/bitcoin/bitcoin/issues/30495#issuecomment-3369155270)
thanks sir it works
(https://github.com/bitcoin/bitcoin/issues/30495#issuecomment-3369155270)
thanks sir it works
💬 timorkon commented on issue "show error "could not sign any more inputs" when sign PSBT for multisig":
(https://github.com/bitcoin/bitcoin/issues/30177#issuecomment-3369155434)
I have the same issue
(https://github.com/bitcoin/bitcoin/issues/30177#issuecomment-3369155434)
I have the same issue
📝 waketraindev converted_to_draft a pull request: "Add reset button and console commands for clearing output/history"
(https://github.com/bitcoin-core/gui/pull/882)
- Added Reset button with Ctrl+Shift+L shortcut to clear both console output and command history.
- Added new console commands:
- clear -> clears console output
- history-clear -> clears console output and command history
- history -> prints all stored command history
(https://github.com/bitcoin-core/gui/pull/882)
- Added Reset button with Ctrl+Shift+L shortcut to clear both console output and command history.
- Added new console commands:
- clear -> clears console output
- history-clear -> clears console output and command history
- history -> prints all stored command history
📝 apogio opened a pull request: "gui: add coins (UTXOs) tab and makes it view-only"
(https://github.com/bitcoin/bitcoin/pull/33542)
# GUI: Add coins tab and sets view-only mode
Adds Coins (UTXOs) tab at the top and:
- Removes selection checkboxes from the dialog
- Disables coin selection functionality
- Maintains UTXO viewing capabilities
- Removes all the information from the top area of the dialog.
(https://github.com/bitcoin/bitcoin/pull/33542)
# GUI: Add coins tab and sets view-only mode
Adds Coins (UTXOs) tab at the top and:
- Removes selection checkboxes from the dialog
- Disables coin selection functionality
- Maintains UTXO viewing capabilities
- Removes all the information from the top area of the dialog.
💬 hebasto commented on pull request "gui: add coins (UTXOs) tab and makes it view-only":
(https://github.com/bitcoin/bitcoin/pull/33542#issuecomment-3369196700)
Please move this PR to https://github.com/bitcoin-core/gui.
(https://github.com/bitcoin/bitcoin/pull/33542#issuecomment-3369196700)
Please move this PR to https://github.com/bitcoin-core/gui.
📝 apogio opened a pull request: "gui: add coins (UTXOs) tab and makes it view-only"
(https://github.com/bitcoin-core/gui/pull/898)
GUI: Add coins tab and sets view-only mode
Adds Coins (UTXOs) tab at the top and:
- Removes selection checkboxes from the dialog
- Disables coin selection functionality
- Maintains UTXO viewing capabilities
- Removes all the information from the top area of the dialog.
The following pictures depict how the GUI would look like:
<img width="1082" height="705" alt="coins_1" src="https://github.com/user-attachments/assets/939e6b11-cb88-4662-bc11-adead54675c3" />
<img width="1128" h
...
(https://github.com/bitcoin-core/gui/pull/898)
GUI: Add coins tab and sets view-only mode
Adds Coins (UTXOs) tab at the top and:
- Removes selection checkboxes from the dialog
- Disables coin selection functionality
- Maintains UTXO viewing capabilities
- Removes all the information from the top area of the dialog.
The following pictures depict how the GUI would look like:
<img width="1082" height="705" alt="coins_1" src="https://github.com/user-attachments/assets/939e6b11-cb88-4662-bc11-adead54675c3" />
<img width="1128" h
...
✅ apogio closed a pull request: "gui: add coins (UTXOs) tab and makes it view-only"
(https://github.com/bitcoin/bitcoin/pull/33542)
(https://github.com/bitcoin/bitcoin/pull/33542)
💬 apogio commented on pull request "gui: add coins (UTXOs) tab and makes it view-only":
(https://github.com/bitcoin/bitcoin/pull/33542#issuecomment-3369223727)
Pull request opened on https://github.com/bitcoin-core/gui/
(https://github.com/bitcoin/bitcoin/pull/33542#issuecomment-3369223727)
Pull request opened on https://github.com/bitcoin-core/gui/
⚠️ MalachiRevolts opened an issue: "Set default datacarriersize to 160 bytes"
(https://github.com/bitcoin/bitcoin/issues/33543)
**Many current Bitcoin Core users do not support setting the default datacarriersize to 100,000 bytes in the upcoming v30 release**
This conclusion is based on following weeks of public threads.
The community is divided, and this proposal to set datacarriersize to 160 bytes aims to unify users with a balanced compromise.
**Why 160 bytes**
Users often view OP_RETURN outputs larger than 160 bytes as excessive for typical use cases,
preferring smaller limits to prioritize financial transactions.
...
(https://github.com/bitcoin/bitcoin/issues/33543)
**Many current Bitcoin Core users do not support setting the default datacarriersize to 100,000 bytes in the upcoming v30 release**
This conclusion is based on following weeks of public threads.
The community is divided, and this proposal to set datacarriersize to 160 bytes aims to unify users with a balanced compromise.
**Why 160 bytes**
Users often view OP_RETURN outputs larger than 160 bytes as excessive for typical use cases,
preferring smaller limits to prioritize financial transactions.
...
💬 hebasto commented on issue "ARM Windows build and release":
(https://github.com/bitcoin/bitcoin/issues/31388#issuecomment-3369255505)
I've managed to cross-compile on Ubuntu 24.04 for Windows ARM64 using the [LLVM MinGW](https://github.com/mstorsjo/llvm-mingw) toolchain. Only a small patch related to the [`std::basic_ifstream`](https://en.cppreference.com/w/cpp/io/basic_ifstream/basic_ifstream.html) tempated constructor was required:
```
gmake -C depends -j 16 HOST=aarch64-w64-mingw32 CC=aarch64-w64-mingw32-clang CXX=aarch64-w64-mingw32-clang++ NO_ZMQ=1
cmake -B build --toolchain depends/aarch64-w64-mingw32/toolchain.cmake
cma
...
(https://github.com/bitcoin/bitcoin/issues/31388#issuecomment-3369255505)
I've managed to cross-compile on Ubuntu 24.04 for Windows ARM64 using the [LLVM MinGW](https://github.com/mstorsjo/llvm-mingw) toolchain. Only a small patch related to the [`std::basic_ifstream`](https://en.cppreference.com/w/cpp/io/basic_ifstream/basic_ifstream.html) tempated constructor was required:
```
gmake -C depends -j 16 HOST=aarch64-w64-mingw32 CC=aarch64-w64-mingw32-clang CXX=aarch64-w64-mingw32-clang++ NO_ZMQ=1
cmake -B build --toolchain depends/aarch64-w64-mingw32/toolchain.cmake
cma
...
🤔 Zero-1729 reviewed a pull request: "[30.x] Backports & rc3"
(https://github.com/bitcoin/bitcoin/pull/33473#pullrequestreview-3302548661)
LGTM ACK 4e869a67aa7415f9c756bf6463e3437ae0a3ec44
Tested locally, all checks out.
(https://github.com/bitcoin/bitcoin/pull/33473#pullrequestreview-3302548661)
LGTM ACK 4e869a67aa7415f9c756bf6463e3437ae0a3ec44
Tested locally, all checks out.
🤔 FranciscoBelchior reviewed a pull request: "util: Revert "common: Close non-std fds before exec in RunCommandJSON""
(https://github.com/bitcoin/bitcoin/pull/33063#pullrequestreview-3302569087)
Concluiu
(https://github.com/bitcoin/bitcoin/pull/33063#pullrequestreview-3302569087)
Concluiu
💬 FranciscoBelchior commented on pull request "run_command: Close non-std fds when execing slave processes":
(https://github.com/bitcoin/bitcoin/pull/30756#discussion_r2404699387)
I didn't authorize this
(https://github.com/bitcoin/bitcoin/pull/30756#discussion_r2404699387)
I didn't authorize this
✅ pinheadmz closed an issue: "Set default datacarriersize to 160 bytes"
(https://github.com/bitcoin/bitcoin/issues/33543)
(https://github.com/bitcoin/bitcoin/issues/33543)
💬 pinheadmz commented on issue "Set default datacarriersize to 160 bytes":
(https://github.com/bitcoin/bitcoin/issues/33543#issuecomment-3369397436)
This is a duplicate of issues #33298 and #33240 Not to mention extensive discussion in pull requests #32381 #32359 #32406 and the meta discussion https://github.com/bitcoin-core/meta/discussions/18 and also the [mailing list post](https://groups.google.com/g/bitcoindev/c/d6ZO7gXGYbQ/m/mJyek28lDAAJ).
Additional op_return concerns were already addressed at length [here](https://delvingbitcoin.org/t/addressing-community-concerns-and-objections-regarding-my-recent-proposal-to-relax-bitcoin-cores-st
...
(https://github.com/bitcoin/bitcoin/issues/33543#issuecomment-3369397436)
This is a duplicate of issues #33298 and #33240 Not to mention extensive discussion in pull requests #32381 #32359 #32406 and the meta discussion https://github.com/bitcoin-core/meta/discussions/18 and also the [mailing list post](https://groups.google.com/g/bitcoindev/c/d6ZO7gXGYbQ/m/mJyek28lDAAJ).
Additional op_return concerns were already addressed at length [here](https://delvingbitcoin.org/t/addressing-community-concerns-and-objections-regarding-my-recent-proposal-to-relax-bitcoin-cores-st
...
⚠️ mikekelly opened an issue: "v30rc2 createrawtransaction unable to create txns with multiple OP_RETURNs"
(https://github.com/bitcoin/bitcoin/issues/33544)
### Is there an existing issue for this?
- [x] I have searched the existing issues
### Current behaviour
createrawtransaction in v30rc2 seems unable to create txns with multiple OP_RETURNs
### Expected behaviour
Expected v30 cli to be able to generate transactions with multiple OP_RETURN outputs.
### Steps to reproduce
```bash
$ bitcoin-cli -regtest createrawtransaction \
'[{"txid":"0000000000000000000000000000000000000000000000000000000000000000","vout":0}]' \
'[{"data":"68656c6c6f"}
...
(https://github.com/bitcoin/bitcoin/issues/33544)
### Is there an existing issue for this?
- [x] I have searched the existing issues
### Current behaviour
createrawtransaction in v30rc2 seems unable to create txns with multiple OP_RETURNs
### Expected behaviour
Expected v30 cli to be able to generate transactions with multiple OP_RETURN outputs.
### Steps to reproduce
```bash
$ bitcoin-cli -regtest createrawtransaction \
'[{"txid":"0000000000000000000000000000000000000000000000000000000000000000","vout":0}]' \
'[{"data":"68656c6c6f"}
...