Bitcoin Core Github
44 subscribers
120K links
Download Telegram
👍 TheCharlatan approved a pull request: "init: Fix Ctrl-C shutdown hangs during wait calls"
(https://github.com/bitcoin/bitcoin/pull/33511#pullrequestreview-3302308582)
Thanks for the fix, makes sense to call Interrupt earlier in the shutdown sequence.
ACK c25a5e670b27d3b6eb958ce437dbe89678bd1511
📝 hebasto opened a pull request: "Release: 30.0rc3 translations update"
(https://github.com/bitcoin/bitcoin/pull/33541)
This PR updates the Polish (pl) translation and addresses [this](https://github.com/bitcoin/bitcoin/pull/33275#issuecomment-3329617679) comment.

Updates for other languages have been skipped, as I believe the review effort would not be worthwhile at this stage of the release process.
👍 hebasto approved a pull request: "[30.x] Backports & rc3"
(https://github.com/bitcoin/bitcoin/pull/33473#pullrequestreview-3302348285)
ACK 4e869a67aa7415f9c756bf6463e3437ae0a3ec44, I agree on the backported PRs. I've reproduced locally all backports, the manpages update, and the example `bitcoin.conf` updated, and obtained zero diff with this PR.
🤔 w0xlt reviewed a pull request: "argsman, cli: GNU-style command-line option parsing (allows options after non-option arguments)"
(https://github.com/bitcoin/bitcoin/pull/33540#pullrequestreview-3302396406)
Concept ACK
👍 hebasto approved a pull request: "build: Drop support for EOL macOS 13"
(https://github.com/bitcoin/bitcoin/pull/33489#pullrequestreview-3302397689)
ACK 1aaaaa078bb2efed126e3f41ecf7c81ccf005818.
💬 pinheadmz commented on pull request "argsman, cli: GNU-style command-line option parsing (allows options after non-option arguments)":
(https://github.com/bitcoin/bitcoin/pull/33540#issuecomment-3369083619)
> Such good news. Hard to believe this PR doesn't reference an existing user request.
>
>

This comment does not contribute to the technical discussion. Please put in more effort in the future or you may be banned.
🤔 furszy reviewed a pull request: "Improve LastCommonAncestor performance + add tests"
(https://github.com/bitcoin/bitcoin/pull/33515#pullrequestreview-3302435512)
ACK 3635d62f5a935801e26a0d5fa2cb5e2dbbb42f9b
💬 timorkon commented on issue "Faster way to get block with prevouts in JSON-RPC":
(https://github.com/bitcoin/bitcoin/issues/30495#issuecomment-3369155270)
thanks sir it works
💬 timorkon commented on issue "show error "could not sign any more inputs" when sign PSBT for multisig":
(https://github.com/bitcoin/bitcoin/issues/30177#issuecomment-3369155434)
I have the same issue
📝 waketraindev converted_to_draft a pull request: "Add reset button and console commands for clearing output/history"
(https://github.com/bitcoin-core/gui/pull/882)
- Added Reset button with Ctrl+Shift+L shortcut to clear both console output and command history.
- Added new console commands:
- clear -> clears console output
- history-clear -> clears console output and command history
- history -> prints all stored command history
📝 apogio opened a pull request: "gui: add coins (UTXOs) tab and makes it view-only"
(https://github.com/bitcoin/bitcoin/pull/33542)
# GUI: Add coins tab and sets view-only mode

Adds Coins (UTXOs) tab at the top and:
- Removes selection checkboxes from the dialog
- Disables coin selection functionality
- Maintains UTXO viewing capabilities
- Removes all the information from the top area of the dialog.
💬 hebasto commented on pull request "gui: add coins (UTXOs) tab and makes it view-only":
(https://github.com/bitcoin/bitcoin/pull/33542#issuecomment-3369196700)
Please move this PR to https://github.com/bitcoin-core/gui.
📝 apogio opened a pull request: "gui: add coins (UTXOs) tab and makes it view-only"
(https://github.com/bitcoin-core/gui/pull/898)
GUI: Add coins tab and sets view-only mode

Adds Coins (UTXOs) tab at the top and:

- Removes selection checkboxes from the dialog
- Disables coin selection functionality
- Maintains UTXO viewing capabilities
- Removes all the information from the top area of the dialog.

The following pictures depict how the GUI would look like:

<img width="1082" height="705" alt="coins_1" src="https://github.com/user-attachments/assets/939e6b11-cb88-4662-bc11-adead54675c3" />

<img width="1128" h
...
apogio closed a pull request: "gui: add coins (UTXOs) tab and makes it view-only"
(https://github.com/bitcoin/bitcoin/pull/33542)
💬 apogio commented on pull request "gui: add coins (UTXOs) tab and makes it view-only":
(https://github.com/bitcoin/bitcoin/pull/33542#issuecomment-3369223727)
Pull request opened on https://github.com/bitcoin-core/gui/
⚠️ MalachiRevolts opened an issue: "Set default datacarriersize to 160 bytes"
(https://github.com/bitcoin/bitcoin/issues/33543)
**Many current Bitcoin Core users do not support setting the default datacarriersize to 100,000 bytes in the upcoming v30 release**
This conclusion is based on following weeks of public threads.
The community is divided, and this proposal to set datacarriersize to 160 bytes aims to unify users with a balanced compromise.

**Why 160 bytes**
Users often view OP_RETURN outputs larger than 160 bytes as excessive for typical use cases,
preferring smaller limits to prioritize financial transactions.

...
💬 hebasto commented on issue "ARM Windows build and release":
(https://github.com/bitcoin/bitcoin/issues/31388#issuecomment-3369255505)
I've managed to cross-compile on Ubuntu 24.04 for Windows ARM64 using the [LLVM MinGW](https://github.com/mstorsjo/llvm-mingw) toolchain. Only a small patch related to the [`std::basic_ifstream`](https://en.cppreference.com/w/cpp/io/basic_ifstream/basic_ifstream.html) tempated constructor was required:
```
gmake -C depends -j 16 HOST=aarch64-w64-mingw32 CC=aarch64-w64-mingw32-clang CXX=aarch64-w64-mingw32-clang++ NO_ZMQ=1
cmake -B build --toolchain depends/aarch64-w64-mingw32/toolchain.cmake
cma
...
🤔 Zero-1729 reviewed a pull request: "[30.x] Backports & rc3"
(https://github.com/bitcoin/bitcoin/pull/33473#pullrequestreview-3302548661)
LGTM ACK 4e869a67aa7415f9c756bf6463e3437ae0a3ec44

Tested locally, all checks out.