π¬ TheCharlatan commented on pull request "kernel: Introduce initial C header API":
(https://github.com/bitcoin/bitcoin/pull/30595#issuecomment-3368378954)
Thank you for the review @alexanderwiederin
f3ca1d65b0444097fd0e2f059a01eb5b29c950c1 -> 45ca0bb904d308671635d233b737047f740d487b ([kernelApi_68](https://github.com/TheCharlatan/bitcoin/tree/kernelApi_68) -> [kernelApi_69](https://github.com/TheCharlatan/bitcoin/tree/kernelApi_69), [compare](https://github.com/TheCharlatan/bitcoin/compare/kernelApi_68..kernelApi_69))
* Addressed @alexanderwiederin's various nits; cleaning up commits, improving commit messages, smaller doc fixes.
* Added a
...
(https://github.com/bitcoin/bitcoin/pull/30595#issuecomment-3368378954)
Thank you for the review @alexanderwiederin
f3ca1d65b0444097fd0e2f059a01eb5b29c950c1 -> 45ca0bb904d308671635d233b737047f740d487b ([kernelApi_68](https://github.com/TheCharlatan/bitcoin/tree/kernelApi_68) -> [kernelApi_69](https://github.com/TheCharlatan/bitcoin/tree/kernelApi_69), [compare](https://github.com/TheCharlatan/bitcoin/compare/kernelApi_68..kernelApi_69))
* Addressed @alexanderwiederin's various nits; cleaning up commits, improving commit messages, smaller doc fixes.
* Added a
...
β
benthecarman closed a pull request: "Fix dark mode detection on Linux"
(https://github.com/bitcoin-core/gui/pull/895)
(https://github.com/bitcoin-core/gui/pull/895)
π¬ hebasto commented on pull request "doc: Add `INSTALL.md` to Linux release tarballs":
(https://github.com/bitcoin/bitcoin/pull/33451#discussion_r2404081843)
Removed.
(https://github.com/bitcoin/bitcoin/pull/33451#discussion_r2404081843)
Removed.
π¬ hebasto commented on pull request "doc: Add `INSTALL.md` to Linux release tarballs":
(https://github.com/bitcoin/bitcoin/pull/33451#issuecomment-3368402179)
[Feedback](https://github.com/bitcoin/bitcoin/pull/33451#discussion_r2402371308) from @fanquake has been addressed.
(https://github.com/bitcoin/bitcoin/pull/33451#issuecomment-3368402179)
[Feedback](https://github.com/bitcoin/bitcoin/pull/33451#discussion_r2402371308) from @fanquake has been addressed.
π andrewtoth approved a pull request: "log: print every script verification state change"
(https://github.com/bitcoin/bitcoin/pull/33336#pullrequestreview-3302015530)
ACK 45bd8914658a675d00aa9c83373d6903a8a9ece8
(https://github.com/bitcoin/bitcoin/pull/33336#pullrequestreview-3302015530)
ACK 45bd8914658a675d00aa9c83373d6903a8a9ece8
π pablomartin4btc opened a pull request: "argsman, cli: GNU-style command-line option parsing (allows options after non-option arguments)"
(https://github.com/bitcoin/bitcoin/pull/33540)
This PR simplifies the argument parsing logic and resolves practical issues for `bitcoin-cli` and similar binaries (e.g. `bitcoin-wallet`) making their usage more consistent and predictable, enabling valid patterns such as mixing commands with wallet- or RPC-specific optionsβwithout relying on argument ordering quirks.
<details>
<summary>What's changed in ArgsManager that allows the above.</summary>
- Previously, `ArgsManager` stopped interpreting options once a non-option argument was en
...
(https://github.com/bitcoin/bitcoin/pull/33540)
This PR simplifies the argument parsing logic and resolves practical issues for `bitcoin-cli` and similar binaries (e.g. `bitcoin-wallet`) making their usage more consistent and predictable, enabling valid patterns such as mixing commands with wallet- or RPC-specific optionsβwithout relying on argument ordering quirks.
<details>
<summary>What's changed in ArgsManager that allows the above.</summary>
- Previously, `ArgsManager` stopped interpreting options once a non-option argument was en
...
π¬ Eunovo commented on pull request "wallet/rpc: fix listdescriptors RPC fails to return descriptors with private key information when wallet contains descriptors missing any key":
(https://github.com/bitcoin/bitcoin/pull/32471#discussion_r2404232251)
Thanks for pointing this out.
> 1. `out` doesn't need to be cleared if no priv keys found. For non watch-only wallets, a descriptor without any private keys can't be imported anyway so there can't be a case wherein we need to propagate this check from `MuSigPubkeyProvider` to `TrDescriptor`.
Yes, there must be a private key somewhere in the descriptor, so the `MusigPubkeyProvider` should not clear the string.
I used your patch and added you as co-author.
(https://github.com/bitcoin/bitcoin/pull/32471#discussion_r2404232251)
Thanks for pointing this out.
> 1. `out` doesn't need to be cleared if no priv keys found. For non watch-only wallets, a descriptor without any private keys can't be imported anyway so there can't be a case wherein we need to propagate this check from `MuSigPubkeyProvider` to `TrDescriptor`.
Yes, there must be a private key somewhere in the descriptor, so the `MusigPubkeyProvider` should not clear the string.
I used your patch and added you as co-author.
π¬ Eunovo commented on pull request "wallet/rpc: fix listdescriptors RPC fails to return descriptors with private key information when wallet contains descriptors missing any key":
(https://github.com/bitcoin/bitcoin/pull/32471#discussion_r2404232564)
I have updated the comment.
(https://github.com/bitcoin/bitcoin/pull/32471#discussion_r2404232564)
I have updated the comment.
π¬ Eunovo commented on pull request "wallet/rpc: fix listdescriptors RPC fails to return descriptors with private key information when wallet contains descriptors missing any key":
(https://github.com/bitcoin/bitcoin/pull/32471#discussion_r2404232718)
I don't believe the suggested message is an improvement, so I will leave it as is.
(https://github.com/bitcoin/bitcoin/pull/32471#discussion_r2404232718)
I don't believe the suggested message is an improvement, so I will leave it as is.
π¬ katesalazar commented on pull request "argsman, cli: GNU-style command-line option parsing (allows options after non-option arguments)":
(https://github.com/bitcoin/bitcoin/pull/33540#issuecomment-3368884598)
Such good news. Hard to believe this PR doesn't reference an existing user request.
(https://github.com/bitcoin/bitcoin/pull/33540#issuecomment-3368884598)
Such good news. Hard to believe this PR doesn't reference an existing user request.
π TheCharlatan approved a pull request: "init: Fix Ctrl-C shutdown hangs during wait calls"
(https://github.com/bitcoin/bitcoin/pull/33511#pullrequestreview-3302308582)
Thanks for the fix, makes sense to call Interrupt earlier in the shutdown sequence.
ACK c25a5e670b27d3b6eb958ce437dbe89678bd1511
(https://github.com/bitcoin/bitcoin/pull/33511#pullrequestreview-3302308582)
Thanks for the fix, makes sense to call Interrupt earlier in the shutdown sequence.
ACK c25a5e670b27d3b6eb958ce437dbe89678bd1511
π hebasto opened a pull request: "Release: 30.0rc3 translations update"
(https://github.com/bitcoin/bitcoin/pull/33541)
This PR updates the Polish (pl) translation and addresses [this](https://github.com/bitcoin/bitcoin/pull/33275#issuecomment-3329617679) comment.
Updates for other languages have been skipped, as I believe the review effort would not be worthwhile at this stage of the release process.
(https://github.com/bitcoin/bitcoin/pull/33541)
This PR updates the Polish (pl) translation and addresses [this](https://github.com/bitcoin/bitcoin/pull/33275#issuecomment-3329617679) comment.
Updates for other languages have been skipped, as I believe the review effort would not be worthwhile at this stage of the release process.
π¬ Filipa200o commented on something "":
(https://github.com/bitcoin/bitcoin/commit/cfb0d74698addef5a07a4cef2c3e18248891cb41#r167205404)
Ree
(https://github.com/bitcoin/bitcoin/commit/cfb0d74698addef5a07a4cef2c3e18248891cb41#r167205404)
Ree
π¬ Filipa200o commented on something "":
(https://github.com/bitcoin/bitcoin/commit/cfb0d74698addef5a07a4cef2c3e18248891cb41#r167205414)
Open my main wallet
(https://github.com/bitcoin/bitcoin/commit/cfb0d74698addef5a07a4cef2c3e18248891cb41#r167205414)
Open my main wallet
π hebasto approved a pull request: "[30.x] Backports & rc3"
(https://github.com/bitcoin/bitcoin/pull/33473#pullrequestreview-3302348285)
ACK 4e869a67aa7415f9c756bf6463e3437ae0a3ec44, I agree on the backported PRs. I've reproduced locally all backports, the manpages update, and the example `bitcoin.conf` updated, and obtained zero diff with this PR.
(https://github.com/bitcoin/bitcoin/pull/33473#pullrequestreview-3302348285)
ACK 4e869a67aa7415f9c756bf6463e3437ae0a3ec44, I agree on the backported PRs. I've reproduced locally all backports, the manpages update, and the example `bitcoin.conf` updated, and obtained zero diff with this PR.
π€ w0xlt reviewed a pull request: "argsman, cli: GNU-style command-line option parsing (allows options after non-option arguments)"
(https://github.com/bitcoin/bitcoin/pull/33540#pullrequestreview-3302396406)
Concept ACK
(https://github.com/bitcoin/bitcoin/pull/33540#pullrequestreview-3302396406)
Concept ACK
π hebasto approved a pull request: "build: Drop support for EOL macOS 13"
(https://github.com/bitcoin/bitcoin/pull/33489#pullrequestreview-3302397689)
ACK 1aaaaa078bb2efed126e3f41ecf7c81ccf005818.
(https://github.com/bitcoin/bitcoin/pull/33489#pullrequestreview-3302397689)
ACK 1aaaaa078bb2efed126e3f41ecf7c81ccf005818.
π¬ pinheadmz commented on pull request "argsman, cli: GNU-style command-line option parsing (allows options after non-option arguments)":
(https://github.com/bitcoin/bitcoin/pull/33540#issuecomment-3369083619)
> Such good news. Hard to believe this PR doesn't reference an existing user request.
>
>
This comment does not contribute to the technical discussion. Please put in more effort in the future or you may be banned.
(https://github.com/bitcoin/bitcoin/pull/33540#issuecomment-3369083619)
> Such good news. Hard to believe this PR doesn't reference an existing user request.
>
>
This comment does not contribute to the technical discussion. Please put in more effort in the future or you may be banned.
π€ furszy reviewed a pull request: "Improve LastCommonAncestor performance + add tests"
(https://github.com/bitcoin/bitcoin/pull/33515#pullrequestreview-3302435512)
ACK 3635d62f5a935801e26a0d5fa2cb5e2dbbb42f9b
(https://github.com/bitcoin/bitcoin/pull/33515#pullrequestreview-3302435512)
ACK 3635d62f5a935801e26a0d5fa2cb5e2dbbb42f9b
π¬ timorkon commented on issue "Faster way to get block with prevouts in JSON-RPC":
(https://github.com/bitcoin/bitcoin/issues/30495#issuecomment-3369155270)
thanks sir it works
(https://github.com/bitcoin/bitcoin/issues/30495#issuecomment-3369155270)
thanks sir it works