💬 achow101 commented on pull request "wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys":
(https://github.com/bitcoin/bitcoin/pull/29675#discussion_r2403607122)
If I need to retouch.

💬 achow101 commented on pull request "wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys":
(https://github.com/bitcoin/bitcoin/pull/29675#discussion_r2403607163)
If I need to retouch.

💬 achow101 commented on pull request "wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys":
(https://github.com/bitcoin/bitcoin/pull/29675#discussion_r2403610047)
I think it's fine as is but can change if I need to retouch.

💬 achow101 commented on pull request "wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys":
(https://github.com/bitcoin/bitcoin/pull/29675#discussion_r2403610180)
If I need to retouch.

📝 fanquake opened a pull request: "[wip] A more static bitcoin-qt"
(https://github.com/bitcoin/bitcoin/pull/33537)
Based on #33181.
Still some issues making libcxb fully static.
Untested.

💬 fanquake commented on pull request "depends: static libxcb-cursor":
(https://github.com/bitcoin/bitcoin/pull/33434#issuecomment-3367675378)
> I'm not familiar enough with X to say why it's seemingly not possible to link all the xcb_utils statically, but this change seems sane to me.

@TheCharlatan Having a look in #33537.

💬 l0rinc commented on pull request "validation: fetch block inputs on parallel threads >10% faster IBD":
(https://github.com/bitcoin/bitcoin/pull/31132#issuecomment-3367707177)
The latest version seems very promising, I like that the algorithms is getting simpler.
I noticed that for small dbcache it has a very noticeable effect, but for very high dbcache this seems to add an extra cost - since we already have everything in the cache, so it just does useless work.
I wonder if we could enable this fetching only after the very first time we [Flush](https://github.com/bitcoin/bitcoin/blob/17372d788e6ca6f5a8452acf88d6b7db4221cb7e/src/coins.cpp#L251) and erase, since it ca
...

👍 dergoegge approved a pull request: "[28.x] More backports"
(https://github.com/bitcoin/bitcoin/pull/33535#pullrequestreview-3301496342)
ACK 06fe49dc88638e2ad21f1b7d0dd87661de384517

👍 dergoegge approved a pull request: "[30.x] Backports & rc3"
(https://github.com/bitcoin/bitcoin/pull/33473#pullrequestreview-3301502822)
ACK 4e869a67aa7415f9c756bf6463e3437ae0a3ec44

⚠️ venpisey12 opened an issue: "Share the CoinGecko App0968812058"
(https://github.com/bitcoin/bitcoin/issues/33538)
https://www.coingecko.com/ provides fundamental analysis of the crypto market, covering over 3000+ cryptocurrencies!
Download the iOS/Android App here:
https://bit.ly/coingecko-ios
https://bit.ly/coingecko-android

✅ achow101 closed an issue: "Share the CoinGecko App0968812058"
(https://github.com/bitcoin/bitcoin/issues/33538)

💬 dergoegge commented on pull request "ci: Turn CentOS config into Alpine musl config":
(https://github.com/bitcoin/bitcoin/pull/33480#issuecomment-3367990090)
Concept ACK

💬 hebasto commented on pull request "[wip] A more static bitcoin-qt":
(https://github.com/bitcoin/bitcoin/pull/33537#issuecomment-3368001867)
How is this approach better than https://github.com/bitcoin/bitcoin/pull/29923?

cc @laanwj

💬 sr-gi commented on pull request "Fix tiebreak when loading blocks from disk (and add tests for comparing chain ties)":
(https://github.com/bitcoin/bitcoin/pull/29640#issuecomment-3368003655)
Would you mind giving this another look @mzumsande @furszy ?

💬 Sjors commented on pull request "init: Fix Ctrl-C shutdown hangs during wait calls":
(https://github.com/bitcoin/bitcoin/pull/33511#issuecomment-3368056941)
tACK c25a5e670b27d3b6eb958ce437dbe89678bd1511

It's also a nice simplification.

💬 Sjors commented on pull request "[30.x] Backports & rc3":
(https://github.com/bitcoin/bitcoin/pull/33473#issuecomment-3368060495)
ACK on the #33446 changes.

Can you add #33229?

⚠️ hebasto opened an issue: "Compilation failure with Clang SNAPSHOT"
(https://github.com/bitcoin/bitcoin/issues/33539)
```
$ clang++ --version
Ubuntu clang version 22.0.0 (++20251003081846+36dc2a941f53-1~exp1~20251003202013.1205)
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm-22/bin
$ cmake --build build -j 1
[4/447] Building CXX object src/CMakeFiles/bitcoin_node.dir/mapport.cpp.o
FAILED: src/CMakeFiles/bitcoin_node.dir/mapport.cpp.o
/usr/bin/ccache /usr/bin/clang++-22 -DBOOST_MULTI_INDEX_DISABLE_SERIALIZATION -DBOOST_NO_CXX98_FUNCTION_BASE -I/home/hebasto/dev/bitcoin/build/src -I/
...

💬 hebasto commented on issue "Compilation failure with Clang SNAPSHOT":
(https://github.com/bitcoin/bitcoin/issues/33539#issuecomment-3368081518)
cc @sipa as the code author.

🤔 janb84 reviewed a pull request: "depends: Update URL for `qrencode` package source tarball"
(https://github.com/bitcoin/bitcoin/pull/33494#pullrequestreview-3301766544)
ACK 93a70a42d30fa2f9404b76d5bbdb5ea316fc1032

PR Updates URL where the package can be downloaded for `qrencode` for depends. Because the package slightly differs from the original a new Hash has been added plus some changes to make sure the CI builds do not use the cache version.

- Code review on the "added" shell scripts in the package to make sure that there has not been added some obvious malicious stuff. (yes package is from gh is from 2020 but still). ✅
- code review ✅

<details><s
...

💬 sipa commented on issue "Compilation failure with Clang SNAPSHOT":
(https://github.com/bitcoin/bitcoin/issues/33539#issuecomment-3368219857)
I can't reproduce this on godbolt. Does the code there work for you? https://godbolt.org/z/f7E4Y7rrb