Bitcoin Core Github
44 subscribers
120K links
Download Telegram
🤔 danielabrozzoni reviewed a pull request: "p2p: Use network-dependent timers for inbound inv scheduling"
(https://github.com/bitcoin/bitcoin/pull/33464#pullrequestreview-3301194864)
reACK 0f7d4ee4e8

I'm not very familiar with this portion of the code, but using `g_msgproc_mutex` seems fine to me (and cleaner than having the atomic). The lock already needs to be held in `SendMessages`, which is the only function from where we call `NextInvToInbounds`.
🚀 fanquake merged a pull request: "p2p: Use network-dependent timers for inbound inv scheduling"
(https://github.com/bitcoin/bitcoin/pull/33464)
💬 andrewtoth commented on pull request "validation: fetch block inputs on parallel threads >10% faster IBD":
(https://github.com/bitcoin/bitcoin/pull/31132#discussion_r2403595535)
Done.
💬 achow101 commented on pull request "wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys":
(https://github.com/bitcoin/bitcoin/pull/29675#discussion_r2403607077)
If I need to retouch.
💬 achow101 commented on pull request "wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys":
(https://github.com/bitcoin/bitcoin/pull/29675#discussion_r2403607122)
If I need to retouch.
💬 achow101 commented on pull request "wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys":
(https://github.com/bitcoin/bitcoin/pull/29675#discussion_r2403607163)
If I need to retouch.
💬 achow101 commented on pull request "wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys":
(https://github.com/bitcoin/bitcoin/pull/29675#discussion_r2403610047)
I think it's fine as is but can change if I need to retouch.
💬 achow101 commented on pull request "wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys":
(https://github.com/bitcoin/bitcoin/pull/29675#discussion_r2403610180)
If I need to retouch.
📝 fanquake opened a pull request: "[wip] A more static bitcoin-qt"
(https://github.com/bitcoin/bitcoin/pull/33537)
Based on #33181.
Still some issues making libcxb fully static.
Untested.
💬 fanquake commented on pull request "depends: static libxcb-cursor":
(https://github.com/bitcoin/bitcoin/pull/33434#issuecomment-3367675378)
> I'm not familiar enough with X to say why it's seemingly not possible to link all the xcb_utils statically, but this change seems sane to me.

@TheCharlatan Having a look in #33537.
💬 l0rinc commented on pull request "validation: fetch block inputs on parallel threads >10% faster IBD":
(https://github.com/bitcoin/bitcoin/pull/31132#issuecomment-3367707177)
The latest version seems very promising, I like that the algorithms is getting simpler.
I noticed that for small dbcache it has a very noticeable effect, but for very high dbcache this seems to add an extra cost - since we already have everything in the cache, so it just does useless work.
I wonder if we could enable this fetching only after the very first time we [Flush](https://github.com/bitcoin/bitcoin/blob/17372d788e6ca6f5a8452acf88d6b7db4221cb7e/src/coins.cpp#L251) and erase, since it ca
...
👍 dergoegge approved a pull request: "[28.x] More backports"
(https://github.com/bitcoin/bitcoin/pull/33535#pullrequestreview-3301496342)
ACK 06fe49dc88638e2ad21f1b7d0dd87661de384517
👍 dergoegge approved a pull request: "[30.x] Backports & rc3"
(https://github.com/bitcoin/bitcoin/pull/33473#pullrequestreview-3301502822)
ACK 4e869a67aa7415f9c756bf6463e3437ae0a3ec44
⚠️ venpisey12 opened an issue: "Share the CoinGecko App0968812058"
(https://github.com/bitcoin/bitcoin/issues/33538)
https://www.coingecko.com/ provides fundamental analysis of the crypto market, covering over 3000+ cryptocurrencies!
Download the iOS/Android App here:
https://bit.ly/coingecko-ios
https://bit.ly/coingecko-android
achow101 closed an issue: "Share the CoinGecko App0968812058"
(https://github.com/bitcoin/bitcoin/issues/33538)
💬 dergoegge commented on pull request "ci: Turn CentOS config into Alpine musl config":
(https://github.com/bitcoin/bitcoin/pull/33480#issuecomment-3367990090)
Concept ACK
💬 hebasto commented on pull request "[wip] A more static bitcoin-qt":
(https://github.com/bitcoin/bitcoin/pull/33537#issuecomment-3368001867)
How is this approach better than https://github.com/bitcoin/bitcoin/pull/29923?

cc @laanwj
💬 sr-gi commented on pull request "Fix tiebreak when loading blocks from disk (and add tests for comparing chain ties)":
(https://github.com/bitcoin/bitcoin/pull/29640#issuecomment-3368003655)
Would you mind giving this another look @mzumsande @furszy ?
💬 Sjors commented on pull request "init: Fix Ctrl-C shutdown hangs during wait calls":
(https://github.com/bitcoin/bitcoin/pull/33511#issuecomment-3368056941)
tACK c25a5e670b27d3b6eb958ce437dbe89678bd1511

It's also a nice simplification.
💬 Sjors commented on pull request "[30.x] Backports & rc3":
(https://github.com/bitcoin/bitcoin/pull/33473#issuecomment-3368060495)
ACK on the #33446 changes.

Can you add #33229?