Bitcoin Core Github
44 subscribers
120K links
Download Telegram
đŸ’Ŧ blocktraveler commented on issue "Enable `importprivkey`, `addmultisigaddress` in descriptor wallets":
(https://github.com/bitcoin/bitcoin/issues/30175#issuecomment-3367229312)
â„šī¸ I've released the [Core Wallet Migration Tools](https://github.com/blocktraveler/Core-Wallet-Migration-Tools) in Python for this purpose which could be implemented into Core with a simple light-weight wrapper over the existing RPCs `getdescriptorinfo` and `importdescriptors`, see [Proposal: Add importprivkeys RPC (helper for WIF → descriptor import)](https://gist.github.com/blocktraveler/3e6198c698a272bd8b13b16e0f13d390) for details (also shared with the mailing list with subject `Add importp
...
đŸ’Ŧ fanquake commented on pull request "Clear out space on centos job":
(https://github.com/bitcoin/bitcoin/pull/33514#issuecomment-3367257294)
cc @m3dwards
đŸ’Ŧ ryanofsky commented on pull request "Update libmultiprocess subtree to support reduced logging":
(https://github.com/bitcoin/bitcoin/pull/33518#issuecomment-3367277916)
Note: This PR (and also #33519) is blocked on https://github.com/bitcoin-core/libmultiprocess/pull/222 to fix CI errors here. If that PR is reviewed and merged, this PR can be updated to include it and taken out of draft state.

https://github.com/bitcoin-core/libmultiprocess/pull/224 would also be nice to include here as it fixes the LLM linter typos pointed out above.
🚀 fanquake merged a pull request: "test: set par=2 in default config for functional test framework"
(https://github.com/bitcoin/bitcoin/pull/33485)
🤔 danielabrozzoni reviewed a pull request: "p2p: Use network-dependent timers for inbound inv scheduling"
(https://github.com/bitcoin/bitcoin/pull/33464#pullrequestreview-3301194864)
reACK 0f7d4ee4e8

I'm not very familiar with this portion of the code, but using `g_msgproc_mutex` seems fine to me (and cleaner than having the atomic). The lock already needs to be held in `SendMessages`, which is the only function from where we call `NextInvToInbounds`.
🚀 fanquake merged a pull request: "p2p: Use network-dependent timers for inbound inv scheduling"
(https://github.com/bitcoin/bitcoin/pull/33464)
đŸ’Ŧ andrewtoth commented on pull request "validation: fetch block inputs on parallel threads >10% faster IBD":
(https://github.com/bitcoin/bitcoin/pull/31132#discussion_r2403595535)
Done.
đŸ’Ŧ achow101 commented on pull request "wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys":
(https://github.com/bitcoin/bitcoin/pull/29675#discussion_r2403607077)
If I need to retouch.
đŸ’Ŧ achow101 commented on pull request "wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys":
(https://github.com/bitcoin/bitcoin/pull/29675#discussion_r2403607122)
If I need to retouch.
đŸ’Ŧ achow101 commented on pull request "wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys":
(https://github.com/bitcoin/bitcoin/pull/29675#discussion_r2403607163)
If I need to retouch.
đŸ’Ŧ achow101 commented on pull request "wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys":
(https://github.com/bitcoin/bitcoin/pull/29675#discussion_r2403610047)
I think it's fine as is but can change if I need to retouch.
đŸ’Ŧ achow101 commented on pull request "wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys":
(https://github.com/bitcoin/bitcoin/pull/29675#discussion_r2403610180)
If I need to retouch.
📝 fanquake opened a pull request: "[wip] A more static bitcoin-qt"
(https://github.com/bitcoin/bitcoin/pull/33537)
Based on #33181.
Still some issues making libcxb fully static.
Untested.
đŸ’Ŧ fanquake commented on pull request "depends: static libxcb-cursor":
(https://github.com/bitcoin/bitcoin/pull/33434#issuecomment-3367675378)
> I'm not familiar enough with X to say why it's seemingly not possible to link all the xcb_utils statically, but this change seems sane to me.

@TheCharlatan Having a look in #33537.
đŸ’Ŧ l0rinc commented on pull request "validation: fetch block inputs on parallel threads >10% faster IBD":
(https://github.com/bitcoin/bitcoin/pull/31132#issuecomment-3367707177)
The latest version seems very promising, I like that the algorithms is getting simpler.
I noticed that for small dbcache it has a very noticeable effect, but for very high dbcache this seems to add an extra cost - since we already have everything in the cache, so it just does useless work.
I wonder if we could enable this fetching only after the very first time we [Flush](https://github.com/bitcoin/bitcoin/blob/17372d788e6ca6f5a8452acf88d6b7db4221cb7e/src/coins.cpp#L251) and erase, since it ca
...
👍 dergoegge approved a pull request: "[28.x] More backports"
(https://github.com/bitcoin/bitcoin/pull/33535#pullrequestreview-3301496342)
ACK 06fe49dc88638e2ad21f1b7d0dd87661de384517
👍 dergoegge approved a pull request: "[30.x] Backports & rc3"
(https://github.com/bitcoin/bitcoin/pull/33473#pullrequestreview-3301502822)
ACK 4e869a67aa7415f9c756bf6463e3437ae0a3ec44
âš ī¸ venpisey12 opened an issue: "Share the CoinGecko App0968812058"
(https://github.com/bitcoin/bitcoin/issues/33538)
https://www.coingecko.com/ provides fundamental analysis of the crypto market, covering over 3000+ cryptocurrencies!
Download the iOS/Android App here:
https://bit.ly/coingecko-ios
https://bit.ly/coingecko-android
✅ achow101 closed an issue: "Share the CoinGecko App0968812058"
(https://github.com/bitcoin/bitcoin/issues/33538)
đŸ’Ŧ dergoegge commented on pull request "ci: Turn CentOS config into Alpine musl config":
(https://github.com/bitcoin/bitcoin/pull/33480#issuecomment-3367990090)
Concept ACK