💬 marciak121 commented on issue "crash":
(https://github.com/bitcoin/bitcoin/issues/33521#issuecomment-3361980803)
finished

📝 fanquake opened a pull request: "guix: use LIEF 0.17.0"
(https://github.com/bitcoin/bitcoin/pull/33522)
Update LIEF in Guix & the CI to 0.17.0: https://lief.re/blog/2025-09-14-lief-0-17-0/.

💬 Crypt-iQ commented on pull request "fuzz: compact block harness":
(https://github.com/bitcoin/bitcoin/pull/33300#discussion_r2399412490)
Fixed in ba89cdd93ee39e884c924ae12737dd06639cee8f, verified that the `CheckBlockHeader` call in validation.cpp no longer fails.

💬 Crypt-iQ commented on pull request "fuzz: compact block harness":
(https://github.com/bitcoin/bitcoin/pull/33300#issuecomment-3362128175)
e2f921458913bcbbe74115cdb2174b0ab31784f2 -> ed813c48f826d083becf93c741b483774c850c86:
- Fixes an issue pointed out by @marcofleon with the PoW checks failing
- Adds more descriptive commit messages

💬 sipa commented on pull request "Cluster mempool implementation":
(https://github.com/bitcoin/bitcoin/pull/28676#issuecomment-3362136518)
@sdaftuar and I ran a simulation, replaying most of 2023, and grabbing a `getblocktemplate` just before every real block, in a node with `-bytespersigop=0`. For each three numbers were computed:
* (a) the fees gathered by the `getblocktemplate` template itself.
* (b) the fees found using the same mempool, using a dynamic programming algorithm that finds the optimal template restricted to just cluster prefixes at chunk boundaries.
* (c) a conservative overestimate, computed by eagerly filling
...

📝 gikol876934 opened a pull request: "Update .editorconfig"
(https://github.com/bitcoin/bitcoin/pull/33523)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

✅ gikol876934 closed a pull request: "Update .editorconfig"
(https://github.com/bitcoin/bitcoin/pull/33523)

⚠️ gikol876934 opened an issue: "crash"
(https://github.com/bitcoin/bitcoin/issues/33524)
crash on win11

✅ gikol876934 closed an issue: "crash"
(https://github.com/bitcoin/bitcoin/issues/33524)

📝 timkon99 opened a pull request: "Create amazing"
(https://github.com/bitcoin/bitcoin/pull/33525)
faster fixes and tools

⚠️ timkon99 opened an issue: "error"
(https://github.com/bitcoin/bitcoin/issues/33526)

✅ timkon99 closed an issue: "error"
(https://github.com/bitcoin/bitcoin/issues/33526)

🤔 mzumsande reviewed a pull request: "net: support overriding the proxy selection in ConnectNode()"
(https://github.com/bitcoin/bitcoin/pull/33454#pullrequestreview-3295630375)
Code Review ACK c76de2eea18076f91dd80b52f66ba790f071a2b1

🤔 danielabrozzoni reviewed a pull request: "p2p: Correct unrealistic headerssync unit test behavior"
(https://github.com/bitcoin/bitcoin/pull/32579#pullrequestreview-3295765688)
reACK cc5dda1de333cf7aa10e2237ee2c9221f705dbd9

I checked the diff since my last view (https://github.com/bitcoin/bitcoin/pull/32579#pullrequestreview-3182000020 + subspan nit + https://github.com/bitcoin/bitcoin/pull/32579#issuecomment-3287698877), and read the whole code once again to make sure I still understand what's going on :)

👍 pablomartin4btc approved a pull request: "rpc: refactor: use string_view in Arg/MaybeArg"
(https://github.com/bitcoin/bitcoin/pull/32983#pullrequestreview-3295778939)
re-ACK [b63428a](https://github.com/bitcoin/bitcoin/commit/b63428ac9ce2c903670409b3e47b9f6730917ae8)

_(tiny nit - sorry, just realised this - only if you have to retouch or rebase again, it would be good to update the copyrights on the files changed that requires it)_

💬 enirox001 commented on pull request "test: Replace legacy wallet with MiniWallet in rpc_getblockstats.py":
(https://github.com/bitcoin/bitcoin/pull/33184#discussion_r2399696431)
> This is basically testing that two results of `getblockstats` match each other. It doesn't actually determine the `expected_tip_stats` in the test and then compare against the actual result of `getblockstats`.

This is a good observation. I've reverted to using hardcoded expected values instead of circular getblockstats comparisons, ensuring the test validates actual correctness rather than just consistency.

📝 ujok777 opened a pull request: "Create simpl2"
(https://github.com/bitcoin/bitcoin/pull/33527)
patches

💬 polespinasa commented on pull request "RPC: add sendrawtransactiontopeer":
(https://github.com/bitcoin/bitcoin/pull/33507#issuecomment-3362532664)
> Maybe it should just do validation then, and can be followed up by the raw send?

If this is the flow we want to follow then this PR is not necessary at all. We can already do that with `testmempoolaccept` and then `sendmsgtopeer`

> > Additionally, peer_id argument could take an array of ids and send the tx to multiple peers. (this is not implemented, but shouldn't be difficult to)
>
> Sounds like a job for batching.

Yeah that's why I didn't implement it in the first place, but it's
...

👍 davidgumberg approved a pull request: "ci: remove 3rd party js from windows dll gha job"
(https://github.com/bitcoin/bitcoin/pull/32513#pullrequestreview-3296059963)
crACK 156927903d64297

Nice! Was bad that we were depending on 3rd party JS before this.

This branch also extends the executable manifest check to all binaries, which would have caught the missing manifest in #31375 which #32634 caught.

💬 willcl-ark commented on pull request "depends: static libxcb-cursor":
(https://github.com/bitcoin/bitcoin/pull/33434#issuecomment-3362609863)
(matching) Guix hashes from my x64 build:

```
❯ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
cf7f86d91288477c11afdc767969d6b19b0ba1e62c73924e72b22a2527374653 guix-build-eca50854e1cb/output/aarch64-linux-gnu/SHA256SUMS.part
5afe50eb76079f96a5129b5e51e2ede657f10c5031abe24a875410f006c55511 guix-build-eca50854e1cb/output/aarch64-linux-gnu/bitcoin-eca50854e1cb-aarch64-linux-gnu-debug.tar.gz
ba6f7937c5d333e64560abcd95dbb
...