Bitcoin Core Github
44 subscribers
120K links
Download Telegram
💬 andrewtoth commented on pull request "validation: fetch block inputs on parallel threads >10% faster IBD":
(https://github.com/bitcoin/bitcoin/pull/31132#issuecomment-3361944949)
Updated the input fetcher significantly:
- uses counting_semaphores to synchronize threads instead of mutex + condvar.
- stores tx + vin indexes in global vector instead of copying the COutPoints. The COutPoints are read from a global CBlock pointer.
- The fetch queue counter is an atomic int instead of a mutex guarded int.
📝 marciak121 opened a pull request: "Update .editorconfig"
(https://github.com/bitcoin/bitcoin/pull/33520)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...
marciak121 closed a pull request: "Update .editorconfig"
(https://github.com/bitcoin/bitcoin/pull/33520)
⚠️ marciak121 opened an issue: "crash"
(https://github.com/bitcoin/bitcoin/issues/33521)
crashes on windows 7
marciak121 closed an issue: "crash"
(https://github.com/bitcoin/bitcoin/issues/33521)
💬 marciak121 commented on issue "crash":
(https://github.com/bitcoin/bitcoin/issues/33521#issuecomment-3361980803)
finished
📝 fanquake opened a pull request: "guix: use LIEF 0.17.0"
(https://github.com/bitcoin/bitcoin/pull/33522)
Update LIEF in Guix & the CI to 0.17.0: https://lief.re/blog/2025-09-14-lief-0-17-0/.
💬 Crypt-iQ commented on pull request "fuzz: compact block harness":
(https://github.com/bitcoin/bitcoin/pull/33300#discussion_r2399412490)
Fixed in ba89cdd93ee39e884c924ae12737dd06639cee8f, verified that the `CheckBlockHeader` call in validation.cpp no longer fails.
💬 Crypt-iQ commented on pull request "fuzz: compact block harness":
(https://github.com/bitcoin/bitcoin/pull/33300#issuecomment-3362128175)
e2f921458913bcbbe74115cdb2174b0ab31784f2 -> ed813c48f826d083becf93c741b483774c850c86:
- Fixes an issue pointed out by @marcofleon with the PoW checks failing
- Adds more descriptive commit messages
💬 sipa commented on pull request "Cluster mempool implementation":
(https://github.com/bitcoin/bitcoin/pull/28676#issuecomment-3362136518)
@sdaftuar and I ran a simulation, replaying most of 2023, and grabbing a `getblocktemplate` just before every real block, in a node with `-bytespersigop=0`. For each three numbers were computed:
* (a) the fees gathered by the `getblocktemplate` template itself.
* (b) the fees found using the same mempool, using a dynamic programming algorithm that finds the optimal template restricted to just cluster prefixes at chunk boundaries.
* (c) a conservative overestimate, computed by eagerly filling
...
📝 gikol876934 opened a pull request: "Update .editorconfig"
(https://github.com/bitcoin/bitcoin/pull/33523)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...
gikol876934 closed a pull request: "Update .editorconfig"
(https://github.com/bitcoin/bitcoin/pull/33523)
⚠️ gikol876934 opened an issue: "crash"
(https://github.com/bitcoin/bitcoin/issues/33524)
crash on win11
gikol876934 closed an issue: "crash"
(https://github.com/bitcoin/bitcoin/issues/33524)
📝 timkon99 opened a pull request: "Create amazing"
(https://github.com/bitcoin/bitcoin/pull/33525)
faster fixes and tools
⚠️ timkon99 opened an issue: "error"
(https://github.com/bitcoin/bitcoin/issues/33526)
timkon99 closed an issue: "error"
(https://github.com/bitcoin/bitcoin/issues/33526)
🤔 mzumsande reviewed a pull request: "net: support overriding the proxy selection in ConnectNode()"
(https://github.com/bitcoin/bitcoin/pull/33454#pullrequestreview-3295630375)
Code Review ACK c76de2eea18076f91dd80b52f66ba790f071a2b1
🤔 danielabrozzoni reviewed a pull request: "p2p: Correct unrealistic headerssync unit test behavior"
(https://github.com/bitcoin/bitcoin/pull/32579#pullrequestreview-3295765688)
reACK cc5dda1de333cf7aa10e2237ee2c9221f705dbd9

I checked the diff since my last view (https://github.com/bitcoin/bitcoin/pull/32579#pullrequestreview-3182000020 + subspan nit + https://github.com/bitcoin/bitcoin/pull/32579#issuecomment-3287698877), and read the whole code once again to make sure I still understand what's going on :)
👍 pablomartin4btc approved a pull request: "rpc: refactor: use string_view in Arg/MaybeArg"
(https://github.com/bitcoin/bitcoin/pull/32983#pullrequestreview-3295778939)
re-ACK [b63428a](https://github.com/bitcoin/bitcoin/commit/b63428ac9ce2c903670409b3e47b9f6730917ae8)

_(tiny nit - sorry, just realised this - only if you have to retouch or rebase again, it would be good to update the copyrights on the files changed that requires it)_