💬 l0rinc commented on pull request "validation: fetch block inputs on parallel threads >10% faster IBD":
(https://github.com/bitcoin/bitcoin/pull/31132#discussion_r2399100147)
I think I would prefer a less opinionated version, as long as it's still correct. No need to optimize for the consensus failure speed in my opinion, I would prefer simpler code for a change as risky as this one.
(https://github.com/bitcoin/bitcoin/pull/31132#discussion_r2399100147)
I think I would prefer a less opinionated version, as long as it's still correct. No need to optimize for the consensus failure speed in my opinion, I would prefer simpler code for a change as risky as this one.
💬 l0rinc commented on pull request "build: Drop support for EOL macOS 13":
(https://github.com/bitcoin/bitcoin/pull/33489#issuecomment-3361587199)
> This is about something else:
What's the reason for keeping a version in the bug issue template that we don't support?
> I don't see how this is related to this pull?
If we recommend a newer `AppleClang` version, it may not work with fuzzing, that's all.
(https://github.com/bitcoin/bitcoin/pull/33489#issuecomment-3361587199)
> This is about something else:
What's the reason for keeping a version in the bug issue template that we don't support?
> I don't see how this is related to this pull?
If we recommend a newer `AppleClang` version, it may not work with fuzzing, that's all.
💬 l0rinc commented on pull request "validation: fetch block inputs on parallel threads >10% faster IBD":
(https://github.com/bitcoin/bitcoin/pull/31132#discussion_r2399116295)
No, that's orthogonal, it's another area where we could possibly reduce contention.
(https://github.com/bitcoin/bitcoin/pull/31132#discussion_r2399116295)
No, that's orthogonal, it's another area where we could possibly reduce contention.
💬 maflcko commented on pull request "build: Drop support for EOL macOS 13":
(https://github.com/bitcoin/bitcoin/pull/33489#issuecomment-3361601497)
> > This is about something else:
>
> What's the reason for keeping a version in the bug issue template that we don't support?
It is just a placeholder, so shouldn't matter. I can bump it on the next push, if there is one, or it can be done as a follow-up.
(https://github.com/bitcoin/bitcoin/pull/33489#issuecomment-3361601497)
> > This is about something else:
>
> What's the reason for keeping a version in the bug issue template that we don't support?
It is just a placeholder, so shouldn't matter. I can bump it on the next push, if there is one, or it can be done as a follow-up.
💬 fanquake commented on issue "Release Schedule for 30.0":
(https://github.com/bitcoin/bitcoin/issues/32275#issuecomment-3361619599)
Moved the release date forward a week, as we still need to do at least an rc3.
(https://github.com/bitcoin/bitcoin/issues/32275#issuecomment-3361619599)
Moved the release date forward a week, as we still need to do at least an rc3.
💬 maflcko commented on pull request "ci: Turn CentOS config into Alpine musl config":
(https://github.com/bitcoin/bitcoin/pull/33480#issuecomment-3361650414)
Another (tiny) benefit of this pull request is that the task will now finally be able to run on my riscv64 box (modulo the two python wheels)
(https://github.com/bitcoin/bitcoin/pull/33480#issuecomment-3361650414)
Another (tiny) benefit of this pull request is that the task will now finally be able to run on my riscv64 box (modulo the two python wheels)
💬 l0rinc commented on pull request "build: Drop support for EOL macOS 13":
(https://github.com/bitcoin/bitcoin/pull/33489#issuecomment-3361731762)
code review ACK 1aaaaa078bb2efed126e3f41ecf7c81ccf005818
(https://github.com/bitcoin/bitcoin/pull/33489#issuecomment-3361731762)
code review ACK 1aaaaa078bb2efed126e3f41ecf7c81ccf005818
💬 l0rinc commented on pull request "coins: use number of dirty cache entries in flush warnings/logs":
(https://github.com/bitcoin/bitcoin/pull/33512#discussion_r2399206305)
You also answered something similar in https://github.com/bitcoin/bitcoin/pull/31132#discussion_r2399049434
(https://github.com/bitcoin/bitcoin/pull/33512#discussion_r2399206305)
You also answered something similar in https://github.com/bitcoin/bitcoin/pull/31132#discussion_r2399049434
💬 fanquake commented on pull request "init: Fix Ctrl-C shutdown hangs during wait calls":
(https://github.com/bitcoin/bitcoin/pull/33511#issuecomment-3361852609)
> This should be backported in my opinion.
Not going to block `30.0` if it's not ready, but marked for backport.
(https://github.com/bitcoin/bitcoin/pull/33511#issuecomment-3361852609)
> This should be backported in my opinion.
Not going to block `30.0` if it's not ready, but marked for backport.
💬 andrewtoth commented on pull request "validation: fetch block inputs on parallel threads >10% faster IBD":
(https://github.com/bitcoin/bitcoin/pull/31132#issuecomment-3361944949)
Updated the input fetcher significantly:
- uses counting_semaphores to synchronize threads instead of mutex + condvar.
- stores tx + vin indexes in global vector instead of copying the COutPoints. The COutPoints are read from a global CBlock pointer.
- The fetch queue counter is an atomic int instead of a mutex guarded int.
(https://github.com/bitcoin/bitcoin/pull/31132#issuecomment-3361944949)
Updated the input fetcher significantly:
- uses counting_semaphores to synchronize threads instead of mutex + condvar.
- stores tx + vin indexes in global vector instead of copying the COutPoints. The COutPoints are read from a global CBlock pointer.
- The fetch queue counter is an atomic int instead of a mutex guarded int.
📝 marciak121 opened a pull request: "Update .editorconfig"
(https://github.com/bitcoin/bitcoin/pull/33520)
<!--
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:
* Any test improvements or new tests that improv
...
(https://github.com/bitcoin/bitcoin/pull/33520)
<!--
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:
* Any test improvements or new tests that improv
...
✅ marciak121 closed a pull request: "Update .editorconfig"
(https://github.com/bitcoin/bitcoin/pull/33520)
(https://github.com/bitcoin/bitcoin/pull/33520)
⚠️ marciak121 opened an issue: "crash"
(https://github.com/bitcoin/bitcoin/issues/33521)
crashes on windows 7
(https://github.com/bitcoin/bitcoin/issues/33521)
crashes on windows 7
✅ marciak121 closed an issue: "crash"
(https://github.com/bitcoin/bitcoin/issues/33521)
(https://github.com/bitcoin/bitcoin/issues/33521)
💬 marciak121 commented on issue "crash":
(https://github.com/bitcoin/bitcoin/issues/33521#issuecomment-3361980803)
finished
(https://github.com/bitcoin/bitcoin/issues/33521#issuecomment-3361980803)
finished
📝 fanquake opened a pull request: "guix: use LIEF 0.17.0"
(https://github.com/bitcoin/bitcoin/pull/33522)
Update LIEF in Guix & the CI to 0.17.0: https://lief.re/blog/2025-09-14-lief-0-17-0/.
(https://github.com/bitcoin/bitcoin/pull/33522)
Update LIEF in Guix & the CI to 0.17.0: https://lief.re/blog/2025-09-14-lief-0-17-0/.
💬 Crypt-iQ commented on pull request "fuzz: compact block harness":
(https://github.com/bitcoin/bitcoin/pull/33300#discussion_r2399412490)
Fixed in ba89cdd93ee39e884c924ae12737dd06639cee8f, verified that the `CheckBlockHeader` call in validation.cpp no longer fails.
(https://github.com/bitcoin/bitcoin/pull/33300#discussion_r2399412490)
Fixed in ba89cdd93ee39e884c924ae12737dd06639cee8f, verified that the `CheckBlockHeader` call in validation.cpp no longer fails.
💬 Crypt-iQ commented on pull request "fuzz: compact block harness":
(https://github.com/bitcoin/bitcoin/pull/33300#issuecomment-3362128175)
e2f921458913bcbbe74115cdb2174b0ab31784f2 -> ed813c48f826d083becf93c741b483774c850c86:
- Fixes an issue pointed out by @marcofleon with the PoW checks failing
- Adds more descriptive commit messages
(https://github.com/bitcoin/bitcoin/pull/33300#issuecomment-3362128175)
e2f921458913bcbbe74115cdb2174b0ab31784f2 -> ed813c48f826d083becf93c741b483774c850c86:
- Fixes an issue pointed out by @marcofleon with the PoW checks failing
- Adds more descriptive commit messages
💬 sipa commented on pull request "Cluster mempool implementation":
(https://github.com/bitcoin/bitcoin/pull/28676#issuecomment-3362136518)
@sdaftuar and I ran a simulation, replaying most of 2023, and grabbing a `getblocktemplate` just before every real block, in a node with `-bytespersigop=0`. For each three numbers were computed:
* (a) the fees gathered by the `getblocktemplate` template itself.
* (b) the fees found using the same mempool, using a dynamic programming algorithm that finds the optimal template restricted to just cluster prefixes at chunk boundaries.
* (c) a conservative overestimate, computed by eagerly filling
...
(https://github.com/bitcoin/bitcoin/pull/28676#issuecomment-3362136518)
@sdaftuar and I ran a simulation, replaying most of 2023, and grabbing a `getblocktemplate` just before every real block, in a node with `-bytespersigop=0`. For each three numbers were computed:
* (a) the fees gathered by the `getblocktemplate` template itself.
* (b) the fees found using the same mempool, using a dynamic programming algorithm that finds the optimal template restricted to just cluster prefixes at chunk boundaries.
* (c) a conservative overestimate, computed by eagerly filling
...
📝 gikol876934 opened a pull request: "Update .editorconfig"
(https://github.com/bitcoin/bitcoin/pull/33523)
<!--
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:
* Any test improvements or new tests that improv
...
(https://github.com/bitcoin/bitcoin/pull/33523)
<!--
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:
* Any test improvements or new tests that improv
...