💬 instagibbs commented on pull request "[NO MERGE] BIP331 Ancestor Package Relay":
(https://github.com/bitcoin/bitcoin/pull/27742#discussion_r1210724340)
really close to `OrphanageAddTx` even though the comments are clear of its purpose here. Maybe `AddKnownOrphanTx` or `AddAlreadyKnownOrphanTx`?

💬 instagibbs commented on pull request "[NO MERGE] BIP331 Ancestor Package Relay":
(https://github.com/bitcoin/bitcoin/pull/27742#discussion_r1210708748)
> is_wtxid

where is this defined?

💬 instagibbs commented on pull request "[NO MERGE] BIP331 Ancestor Package Relay":
(https://github.com/bitcoin/bitcoin/pull/27742#discussion_r1210729694)
`is_wtxid=false`?

💬 instagibbs commented on pull request "[NO MERGE] BIP331 Ancestor Package Relay":
(https://github.com/bitcoin/bitcoin/pull/27742#discussion_r1210769183)
where did this behavior live prior, where this isn't a behavior change?

💬 instagibbs commented on pull request "[NO MERGE] BIP331 Ancestor Package Relay":
(https://github.com/bitcoin/bitcoin/pull/27742#discussion_r1210736698)
What does this last sentence mean?

💬 instagibbs commented on pull request "[NO MERGE] BIP331 Ancestor Package Relay":
(https://github.com/bitcoin/bitcoin/pull/27742#discussion_r1211763570)
since we're touching this, would you mind annotating the bool as `/* best */` to make it clearer what this is doing? New to tx tracking; would be helpful

💬 petertodd commented on pull request "Ignore datacarrier limits for dataless OP_RETURN outputs":
(https://github.com/bitcoin/bitcoin/pull/27261#issuecomment-1573858529)
> Would you mind submitting the test to test current `master` behavior for `-nodatacarrier`, or would you mind if someone else did that?

I certainly don't mind if someone else does that.

💬 pinheadmz commented on issue "Add test vectors in BIP143 into tx_valid.json / sighash.json":
(https://github.com/bitcoin/bitcoin/issues/14308#issuecomment-1573869228)
I think it's safe to close this as won't-fix for the reasons stated above. Pull requests are always welcome!

✅ pinheadmz closed an issue: "Add test vectors in BIP143 into tx_valid.json / sighash.json"
(https://github.com/bitcoin/bitcoin/issues/14308)

💬 glozow commented on pull request "[NO MERGE] BIP331 Ancestor Package Relay":
(https://github.com/bitcoin/bitcoin/pull/27742#discussion_r1214484568)
> Should this function ever be called with a protected orphan?

Yes. It's called when orphans expire as well.

> Tests don't cover these lines for protected peers

Sounds like I neglected to write a test for this. Expiry is pretty long, but theoretically we can hit this if we have multiple peers stalling us on the resolution of this orphan. We might happen to be trying package relay with one of the peers when the expiration is reached.

💬 pinheadmz commented on issue "Alerting blockchain reorgs":
(https://github.com/bitcoin/bitcoin/issues/14915#issuecomment-1573869821)
I think it's safe to close this as won't-fix for the reasons stated above. Pull requests are always welcome!

✅ pinheadmz closed an issue: "Alerting blockchain reorgs"
(https://github.com/bitcoin/bitcoin/issues/14915)

💬 instagibbs commented on pull request "[NO MERGE] BIP331 Ancestor Package Relay":
(https://github.com/bitcoin/bitcoin/pull/27742#discussion_r1214486019)
Ah! Didn't put 2 and 2 together. Comment-worthy

💬 fanquake commented on pull request "[wip] rng: adds support for x86 rdrand/rdseed instructions when building using MSVC":
(https://github.com/bitcoin/bitcoin/pull/22158#issuecomment-1573871155)
Closing for now. Feel free to ping for a reopen if/when you want to return to this.

✅ fanquake closed a pull request: "[wip] rng: adds support for x86 rdrand/rdseed instructions when building using MSVC"
(https://github.com/bitcoin/bitcoin/pull/22158)

💬 fanquake commented on pull request "Drop IO priority to idle while reading blocks for peer requests and startup verification":
(https://github.com/bitcoin/bitcoin/pull/9245#issuecomment-1573874582)
Closing for now. Can be re-opened in future if/when above issues are going to be accounted for.

✅ fanquake closed a pull request: "Drop IO priority to idle while reading blocks for peer requests and startup verification"
(https://github.com/bitcoin/bitcoin/pull/9245)

💬 glozow commented on pull request "[NO MERGE] BIP331 Ancestor Package Relay":
(https://github.com/bitcoin/bitcoin/pull/27742#discussion_r1214489207)
Ah yes, that's a bug! This `while` condition is very strange since one part applies to the unprotected orphanage and the other applies to the total orphanage. I think we should change the second condition to be on `m_total_unprotected_orphan_bytes`, yes.

💬 pinheadmz commented on issue "Processing of new blocks slower than necessary due to overly selective peer selection":
(https://github.com/bitcoin/bitcoin/issues/21803#issuecomment-1573877338)
@rebroad is this issue closed by https://github.com/bitcoin/bitcoin/pull/27626 ?

💬 pinheadmz commented on pull request "Parallel compact block downloads, take 3":
(https://github.com/bitcoin/bitcoin/pull/27626#issuecomment-1573877749)
@instagibbs does this close https://github.com/bitcoin/bitcoin/issues/21803 ?