💬 amishhaa commented on pull request "contrib: fix for macOS deployment build failing on Qt translations even though it is optional.":
(https://github.com/bitcoin/bitcoin/pull/33482#issuecomment-3336844540)
Refer PR: #33358 for previous discussions.

💬 amishhaa commented on pull request "contrib: fix for macOS deployment build failing on Qt translations even though it is optional.":
(https://github.com/bitcoin/bitcoin/pull/33358#issuecomment-3336848208)
Closed this PR due to some local branching issues. Reopened with a clean working tree. (cc: @hebasto, @fanquake )

🤔 hebasto reviewed a pull request: "build: Remove CMAKE_SKIP_BUILD_RPATH and SKIP_BUILD_RPATH settings"
(https://github.com/bitcoin/bitcoin/pull/33247#pullrequestreview-3270544945)
My Guix build:
```
aarch64
ab375345e39248d2c61fe6fce1afeb7b95623cfc9db452a7cfbd5b6797bf9c16 guix-build-d55753626292/output/aarch64-linux-gnu/SHA256SUMS.part
85bd20c1b7076387d8efcb5ade58d29774f8114a712492a77315627d0db41094 guix-build-d55753626292/output/aarch64-linux-gnu/bitcoin-d55753626292-aarch64-linux-gnu-debug.tar.gz
f52e90c92d99b17c916b2c3ff2b57608597ca39ec7324ff5840550636cfd3a50 guix-build-d55753626292/output/aarch64-linux-gnu/bitcoin-d55753626292-aarch64-linux-gnu.tar.gz
9c8c935f
...

💬 maflcko commented on pull request "test/refactor: use test deque to avoid quadratic iteration":
(https://github.com/bitcoin/bitcoin/pull/33313#issuecomment-3337139398)
lgtm ACK 75e6984ec8c6fa196ad78c11f454da506d7c8ff1

This shouldn't affect performance, but it seems fine as a style-cleanup/refactor.

👍 hebasto approved a pull request: "build: Remove CMAKE_SKIP_BUILD_RPATH and SKIP_BUILD_RPATH settings"
(https://github.com/bitcoin/bitcoin/pull/33247#pullrequestreview-3270575407)
ACK d55753626292be17fbb300b54601942ff2730729.

🤔 w0xlt reviewed a pull request: "test/refactor: use test deque to avoid quadratic iteration"
(https://github.com/bitcoin/bitcoin/pull/33313#pullrequestreview-3270590403)
reACK https://github.com/bitcoin/bitcoin/pull/33313/commits/75e6984ec8c6fa196ad78c11f454da506d7c8ff1

💬 0xB10C commented on issue "Ability to retrieve peer info by peer id":
(https://github.com/bitcoin/bitcoin/issues/33478#issuecomment-3337172425)
for reference, this seems related to https://github.com/bitcoin/bitcoin/pull/32741

💬 Eunovo commented on pull request "validation: ensure assumevalid is always used during reindex":
(https://github.com/bitcoin/bitcoin/pull/31615#discussion_r2381229968)
Looks like you are suggesting we do something more invasive. Can you clarify what you mean?
I do not believe something more invasive is required since this simple fix works, but I'm happy to hear what others think.

🤔 janb84 reviewed a pull request: "build: Remove CMAKE_SKIP_BUILD_RPATH and SKIP_BUILD_RPATH settings"
(https://github.com/bitcoin/bitcoin/pull/33247#pullrequestreview-3270732296)
re ACK d55753626292be17fbb300b54601942ff2730729

change since last ack:
- changes in comments in script.

💬 maflcko commented on pull request "cmake: exclude secp256k1 from all":
(https://github.com/bitcoin/bitcoin/pull/33390#issuecomment-3337304020)
Could turn into draft while CI is red?

💬 jmoik commented on pull request "cmake: Inherit WERROR setting for secp256k1 build":
(https://github.com/bitcoin/bitcoin/pull/33297#discussion_r2381326351)
Good point, I was not aware of this variable, I have adjusted the code and tested it.

💬 maflcko commented on pull request "cmake: Inherit WERROR setting for secp256k1 build":
(https://github.com/bitcoin/bitcoin/pull/33297#discussion_r2381335649)
Please squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits

💬 janb84 commented on pull request "ci: Turn CentOS config into Alpine musl config":
(https://github.com/bitcoin/bitcoin/pull/33480#issuecomment-3337344205)
> > nitpicker
>
> No worries. Happy to adjust the pull description, if you have any suggestions I could take over.

How about something like this:

The CentOS task aligns with Ubuntu/Debian CI tasks in terms of libc usage, but (slightly) differs in package naming and update philosophy. I am not aware of the task ever discovering a centos-related issue, so it seems fine to recycle it into an Alpine Linux task.

💬 maflcko commented on pull request "ci: Turn CentOS config into Alpine musl config":
(https://github.com/bitcoin/bitcoin/pull/33480#issuecomment-3337358394)
thx, edited description

🤔 janb84 reviewed a pull request: "ci: Turn CentOS config into Alpine musl config"
(https://github.com/bitcoin/bitcoin/pull/33480#pullrequestreview-3270943030)
ACK fa6b2e9efece2d728bdc257c36c95db03e1a7bc4

This PR introduces more libc diversity in the CI pipeline (in the form of using Alpine), which is welcome.

💬 maflcko commented on pull request "ci: use Mold linker for asan-lsan-ubsan-integer-no-depends-usdt workflow":
(https://github.com/bitcoin/bitcoin/pull/33370#issuecomment-3337423480)
lgtm ACK f031536f2d267655a0fb40ab84d03e7ffa903d4c

Makes the config a bit more verbose, but otherwise I don't see any harm, so should be fine.

💬 willcl-ark commented on pull request "test: Run bench sanity checks in parallel with functional tests":
(https://github.com/bitcoin/bitcoin/pull/33142#issuecomment-3337628247)
I have had a play with porting this to cmake-native (ctest) code, and IMO the main difference is that (in my implementation) it just that it feels more obscure to collect the benchmarks, cost them (not implemented in this PR), and run them in parallel using cmake files vs a few lines of python.

Perhaps I'm doing it wrong, but I found I needed a whole new target `generate_bench_tests` to dynamically parse benchmark names _after_ bitcoin_bench was built, which can then create the necessary `cte
...

💬 maflcko commented on pull request "test: Run bench sanity checks in parallel with functional tests":
(https://github.com/bitcoin/bitcoin/pull/33142#issuecomment-3337747034)
> Perhaps I'm doing it wrong, but I found I needed a whole new target `generate_bench_tests` to dynamically parse benchmark names _after_ bitcoin_bench was built, which can then create the necessary `ctest` file, which can then be run in "true parallel" by `ctest`.

Yes, it is possible (and thanks for trying), see also https://habla.news/u/purplekarrot.net/cmake-and-test-suites. However,

* it requires more code, and the review for it.
* the win-cross issue is pre-existing and even if the c
...

💬 hebasto commented on pull request "ci: Remove bash -c from cmake invocation using eval":
(https://github.com/bitcoin/bitcoin/pull/33401#discussion_r2381735638)
```suggestion
eval "CMAKE_ARGS=($BITCOIN_CONFIG_ALL $BITCOIN_CONFIG)"
```

👍 hebasto approved a pull request: "ci: Remove bash -c from cmake invocation using eval"
(https://github.com/bitcoin/bitcoin/pull/33401#pullrequestreview-3271334044)
ACK 8406c1e6321fbc3ce739aa7ccb18c67fb706a4b9.