💬 RandyMcMillan commented on pull request "rpcconsole: display signet challenge":
(https://github.com/bitcoin-core/gui/pull/896#discussion_r2380297519)
move ChallengeToStdString to src/util/strencodings.cpp for later availability in main window.

💬 RandyMcMillan commented on pull request "rpcconsole: display signet challenge":
(https://github.com/bitcoin-core/gui/pull/896#discussion_r2380298450)
removed std::string RPCConsole::challengeToString(const std::vector<uint8_t>& v)

💬 D33r-Gee commented on pull request "[DRAFT] Expose AssumeUTXO Load Snapshot Functionality To The GUI":
(https://github.com/bitcoin-core/gui/pull/870#issuecomment-3335902873)
With [82a3969](https://github.com/bitcoin-core/gui/commit/82a3969f6570d370943fb3a7be86cd3ffdacdd4d) it updates the interface methods to match https://github.com/bitcoin/bitcoin/pull/33117
It also adds a load snapshot button during the intro and seamless loading if a proper path has been selected (from @luke-jr suggestion)
Also adds the use of threads to make sure there's no hanging or UI blocking when the load snapshot button is used in the options dialog (hopefully addressing @Sjors experie
...

💬 RandyMcMillan commented on pull request "rpcconsole: display signet challenge":
(https://github.com/bitcoin-core/gui/pull/896#issuecomment-3335904661)
added "trivial challenge" support per signet implementation.

<img width="1062" height="613" alt="Screenshot 2025-09-25 at 4 47 29 PM" src="https://github.com/user-attachments/assets/d09860cf-2578-4b55-95f2-7a8f948909d6" />

💬 RandyMcMillan commented on pull request "rpcconsole: display signet challenge":
(https://github.com/bitcoin-core/gui/pull/896#issuecomment-3335910910)
handle long challenges with proper elision and text flow.

<img width="1062" height="597" alt="Screenshot 2025-09-25 at 4 24 29 PM" src="https://github.com/user-attachments/assets/0f1d7b97-77c9-48f6-ae43-7b72e7fd8084" />

💬 RandyMcMillan commented on pull request "rpcconsole: display signet challenge":
(https://github.com/bitcoin-core/gui/pull/896#issuecomment-3335914267)
common length challenges elide and flow correctly.
<img width="1078" height="673" alt="Screenshot 2025-09-25 at 4 25 50 PM" src="https://github.com/user-attachments/assets/f76d9839-ae13-4f70-aeea-0a268ecfad19" />

💬 achow101 commented on pull request "multiprocess: Don't require bitcoin -m argument when IPC options are used":
(https://github.com/bitcoin/bitcoin/pull/33229#issuecomment-3335956226)
ACK 453b0fa286e5dce0af682b7b73684dd6415a50de

🤔 pablomartin4btc reviewed a pull request: "rpcconsole: display signet challenge"
(https://github.com/bitcoin-core/gui/pull/896#pullrequestreview-3269486950)
It would be good to put the label "challenge:" in both the info tab and the title, and also differentiate between the default challenge and the custom one (specified by `-signet_challenge`). With this in mind perhaps when there's no custom challenge specified we don't update the window title but only the info tab (`"`Name: Signet (challenge: 512103ad...e6c452ae, default`)`" or something like that).

For the conversion you can use `HexStr()` instead of `ChallengeToStdString()`.

💬 RandyMcMillan commented on pull request "rpcconsole: display signet challenge":
(https://github.com/bitcoin-core/gui/pull/896#issuecomment-3335972068)
> It would be good to put the label "challenge:" in both the info tab and the title, and also differentiate between the default challenge and the custom one (specified by `-signet_challenge`). With this in mind perhaps when there's no custom challenge specified we don't update the window title but only the info tab (`"`Name: Signet (challenge: 512103ad...e6c452ae, default`)`" or something like that).
>
> For the conversion you can use `HexStr()` instead of `ChallengeToStdString()`.

i was t
...

💬 RandyMcMillan commented on pull request "rpcconsole: display signet challenge":
(https://github.com/bitcoin-core/gui/pull/896#issuecomment-3335981603)
also trying to treat the challenge as a fingerprint - avoiding clutter in the title but the rcpconsole formatting ought to look ok.

🚀 achow101 merged a pull request: "multiprocess: Don't require bitcoin -m argument when IPC options are used"
(https://github.com/bitcoin/bitcoin/pull/33229)

🤔 pablomartin4btc reviewed a pull request: "Add reset button and console commands for clearing output/history"
(https://github.com/bitcoin-core/gui/pull/882#pullrequestreview-3269551890)
Sorry I haven't had the chance to check the PR earlier.

For the shortcut perhaps you can document it in the welcome message of the console:

<img width="828" height="519" alt="image" src="https://github.com/user-attachments/assets/0209a08c-0807-499b-9938-0ea6e6e5cb7d" />


Replacing this line:
`Use up and down arrows to navigate history, and Ctrl+L to clear screen.`
By:
`Use up and down arrows to navigate history, Ctrl+L to clear screen and Ctrl+L to clear screen and Ctrl+Shift+L to c
...

💬 pracakjarenthom777-cell commented on pull request "rpc: add target to getmininginfo field and show next block info":
(https://github.com/bitcoin/bitcoin/pull/31583#issuecomment-3336053592)
bf7996cbc3becf329d8b1cd2f1007fec9b3a3188

💬 achow101 commented on pull request "rpc: addpeeraddress: throw on invalid IP":
(https://github.com/bitcoin/bitcoin/pull/33430#issuecomment-3336143980)
ACK 316a0c513278d53cb25f42ea502d20691962aad6

🚀 achow101 merged a pull request: "rpc: addpeeraddress: throw on invalid IP"
(https://github.com/bitcoin/bitcoin/pull/33430)

💬 RandyMcMillan commented on pull request "rpcconsole: display signet challenge":
(https://github.com/bitcoin-core/gui/pull/896#issuecomment-3336239941)
fixed typo and commit scope
add Network Name formatting per @pablomartin4btc feed back
Challenge Copy&Paste-able from gui per @luke-jr feed back
Detect Default signet_challenge and display "Default"

💬 RandyMcMillan commented on pull request "rpcconsole: display signet challenge":
(https://github.com/bitcoin-core/gui/pull/896#issuecomment-3336242136)
tooltip displays challenge (even if obfuscated in rpcconsole)
<img width="970" height="690" alt="Screenshot 2025-09-25 at 7 25 34 PM" src="https://github.com/user-attachments/assets/a2a12f56-8468-4373-bfdd-40c2b5ae909d" />

💬 RandyMcMillan commented on pull request "rpcconsole: display signet challenge":
(https://github.com/bitcoin-core/gui/pull/896#issuecomment-3336245069)
when default signet_challenge detected:
<img width="1376" height="623" alt="Screenshot 2025-09-25 at 7 23 29 PM" src="https://github.com/user-attachments/assets/d2a0cd88-5585-4762-a028-d61980b72a20" />

💬 RandyMcMillan commented on pull request "rpcconsole: display signet challenge":
(https://github.com/bitcoin-core/gui/pull/896#issuecomment-3336247945)
when common length signet_challenge:

<img width="1396" height="566" alt="Screenshot 2025-09-25 at 7 22 52 PM" src="https://github.com/user-attachments/assets/866e0fe5-de31-4a80-815b-e3281272c4bf" />

💬 l0rinc commented on pull request "[IBD] coins: increase default UTXO flush batch size to 32 MiB":
(https://github.com/bitcoin/bitcoin/pull/31645#issuecomment-3336254681)
Now that we have built-in support for querying total memory, I wonder if the batch size should depend on that or if we should just bump it to constant 32 (as proposed currently). Given how messy it was to measure even this one reliably, it's likely best to leave it a constant.
But maybe we can still keep the 64 MiB version (which performed best), now that excessive dbcache already warns. Feedback is welcome.