💬 l0rinc commented on pull request "index: handle case where pindex_prev equals chain tip in NextSyncBlock()":
(https://github.com/bitcoin/bitcoin/pull/32875#discussion_r2379697450)
Not sure what that means, we write tests to tell us when the behavior of the application changed.
You have changed the behavior and no test broke, so there's a lack of test coverage that we should fix to explain why this change is needed. It also helps the reviewers debug the given scenario to understand why this changes is needed - or if there's a different solution that would also solve it, etc.

🤔 danielabrozzoni reviewed a pull request: "p2p: Use network-dependent timers for inbound inv scheduling"
(https://github.com/bitcoin/bitcoin/pull/33464#pullrequestreview-3268650422)
tACK beb75e48ae1d5771932f427a490c7e1b6c1720d3

I tested locally by adding a log line, and checking that different networks schedule different inv times:
```diff
diff --git a/src/net_processing.cpp b/src/net_processing.cpp
index f5f04c7a17..fec1cfcb6b 100644
--- a/src/net_processing.cpp
+++ b/src/net_processing.cpp
@@ -5716,6 +5716,7 @@ bool PeerManagerImpl::SendMessages(CNode* pto)
fSendTrickle = true;
if (pto->IsInboundConn()) {

...

💬 fjahr commented on pull request "wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys":
(https://github.com/bitcoin/bitcoin/pull/29675#discussion_r2379758795)
This line [fails in the no IPC, i686, DEBUG CI](https://github.com/bitcoin/bitcoin/actions/runs/17962047927/job/51087206906?pr=29675#step:9:3082).

<details><summary>Traceback</summary>

```
Traceback (most recent call last):
File "/home/admin/actions-runner/_work/_temp/test/functional/test_framework/test_framework.py", line 199, in main
self.run_test()
File "/home/admin/actions-runner/_work/_temp/build/test/functional/wallet_musig.py", line 224, in run_test
self.do_test("ra
...

💬 maflcko commented on pull request "ci: Turn CentOS config into Alpine musl config":
(https://github.com/bitcoin/bitcoin/pull/33480#issuecomment-3335108541)
Also confirmed that the gcc debug mode works on alpine: https://github.com/maflcko/bitcoin-core-with-ci/actions/runs/18013008390/job/51250509812#step:8:2473 :

```
/usr/include/c++/14.2.0/debug/vector:508:
In function:
constexpr std::debug::vector<_Tp, _Allocator>::reference std::
debug::vector<_Tp, _Allocator>::operator[](size_type) [with _Tp =
CTxOut; _Allocator = std::allocator<CTxOut>; reference = CTxOut&;
size_type = long unsigned int]

Error: attempt to subscrip
...

💬 achow101 commented on issue "No way to clear command history in RPC console or reset the console without restarting the node":
(https://github.com/bitcoin-core/gui/issues/897#issuecomment-3335117139)
There's already a clear history button in the top right corner of the console window, next to the font size buttons. It works fine for me.

💬 waketraindev commented on issue "No way to clear command history in RPC console or reset the console without restarting the node":
(https://github.com/bitcoin-core/gui/issues/897#issuecomment-3335127373)
> There's already a clear history button in the top right corner of the console window, next to the font size buttons. It works fine for me.

Hello and thank you for the reply. I'm actually talking about the command input history, the one in the input box where you use the arrow keys to browse

Hope that clears it

💬 theStack commented on pull request "wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys":
(https://github.com/bitcoin/bitcoin/pull/29675#discussion_r2379831421)
Compiling at commit 2a49082e491810fab48485e0a63e1fadfb09b1b7 currently fails, as the `musig2_`... fields haven't been added to the `SignatureData` struct yet.

💬 polespinasa commented on issue "`generateblock` RPC Not Collecting Transaction Fees":
(https://github.com/bitcoin/bitcoin/issues/31684#issuecomment-3335167174)
I think you might want to take a look to #32468.
At the moment it only collects fees when the mempool option is used and not when a set of txs is provided manually, but it's a start :)

🤔 maflcko reviewed a pull request: "rpc: require integer verbosity; remove boolean 'verbose'"
(https://github.com/bitcoin/bitcoin/pull/33214#pullrequestreview-3268772493)
not sure where this pull is going, but it could make sense to split out the test changes into a separate pull (replacing the deprecated values with integers and named args), except for one deprecated value for each RPC, so that all code branches remain tests, but most code is using the new way and named args.

💬 maflcko commented on pull request "rpc: require integer verbosity; remove boolean 'verbose'":
(https://github.com/bitcoin/bitcoin/pull/33214#discussion_r2379836497)
this is still moved

💬 maflcko commented on pull request "rpc: require integer verbosity; remove boolean 'verbose'":
(https://github.com/bitcoin/bitcoin/pull/33214#discussion_r2379838271)
seems odd to change the behavior here to allow deprecated values when they were forbidden

💬 maflcko commented on pull request "rpc: require integer verbosity; remove boolean 'verbose'":
(https://github.com/bitcoin/bitcoin/pull/33214#discussion_r2379845951)
when passing integral literal values, it makes sense to use named args, otherwise it is not clear what they mean from reading just the code

💬 m3dwards commented on pull request "ci: remove 3rd party js from windows dll gha job":
(https://github.com/bitcoin/bitcoin/pull/32513#issuecomment-3335185534)
> On the [master](https://github.com/bitcoin/bitcoin/actions/runs/17921155333/job/50956194860) branch:
>
> ```
> VSCMD_ARG_HOST_ARCH: x64
> VSCMD_ARG_TGT_ARCH: x64
> ```
>
> However, with this [PR](https://github.com/bitcoin/bitcoin/actions/runs/17807365691/job/50622408408):
>
> ```
> VSCMD_ARG_HOST_ARCH: x86
> VSCMD_ARG_TGT_ARCH: x86
> ```

What a great catch! Sorted it in this [run](https://github.com/m3dwards/bitcoin/actions/runs/18015235679/job/51258366346), will update PR s
...

📝 waketraindev reopened a pull request: "Add reset button and console commands for clearing output/history"
(https://github.com/bitcoin-core/gui/pull/882)
- Added Reset button with Ctrl+Shift+L shortcut to clear both console output and command history.
- Added new console commands:
- clear -> clears console output
- history-clear -> clears console output and command history
- history -> prints all stored command history

💬 waketraindev commented on issue "No way to clear command history in RPC console or reset the console without restarting the node":
(https://github.com/bitcoin-core/gui/issues/897#issuecomment-3335194642)
My take on the fix,

https://github.com/bitcoin-core/gui/pull/882

💬 maflcko commented on issue "build: `test_bitcoin` link failure with `-flto=thin` & address sanitizer":
(https://github.com/bitcoin/bitcoin/issues/33147#issuecomment-3335205925)
Can be closed as fixed?

💬 maflcko commented on pull request "ci: add libcpp hardening flags to macOS fuzz job":
(https://github.com/bitcoin/bitcoin/pull/33462#issuecomment-3335221230)
Concept ACK. The qa-assets repo has a libc++ debug run, so this isn't required, but it seems fast enough to not hurt.

Would be nice to push my suggested diff, so that the xcode is hardcoded again.

💬 achow101 commented on pull request "wallet: Add `exportwatchonlywallet` RPC to export a watchonly version of a wallet":
(https://github.com/bitcoin/bitcoin/pull/32489#discussion_r2379892167)
Yes, but that's not an issue.

💬 achow101 commented on pull request "wallet: Add `exportwatchonlywallet` RPC to export a watchonly version of a wallet":
(https://github.com/bitcoin/bitcoin/pull/32489#discussion_r2379903393)
Yes. The nodes in this test are not always in sync with each other.

🤔 l0rinc reviewed a pull request: "qa: Improvements to debug_assert_log + busy_wait_for_debug_log"
(https://github.com/bitcoin/bitcoin/pull/33423#pullrequestreview-3268886010)
The error message seems off to me now, we're potentially logging lines as missing that we haven't checked.