💬 waketraindev commented on pull request "net: Provide block templates to peers on request":
(https://github.com/bitcoin/bitcoin/pull/33191#discussion_r2365773084)
NIT: Replace break; return; with just return for clarity and to simplify control flow.

```suggestion
return;
```

💬 hodlinator commented on pull request "node: Add --debug_runs/-waitfordebugger":
(https://github.com/bitcoin/bitcoin/pull/31723#issuecomment-3333179240)
Realized one could start a debugger session from the CLI:
`$ subl --command "debugger {\"action\": \"start\", \"configuration\": {\"name\": \"foo\", \"type\": \"lldb\", \"request\": \"launch\", \"program\": \"\${project_path}/build/bin/bitcoind\", \"args\": [\"-noconnect\"]}}"`
or
`$ kgx -- $(which lldb) -o run -- /home/hodlinator/bc/3/build/bin/bitcoind -noconnect`

So I've explored a variation of this which does not change the C++ side at all - https://github.com/hodlinator/bitcoin/tree/r
...

👋 hodlinator's pull request is ready for review: "node: Add --debug_runs/-waitfordebugger"
(https://github.com/bitcoin/bitcoin/pull/31723)

💬 hodlinator commented on pull request "node: Add --debug_runs/-waitfordebugger + --debug_cmd":
(https://github.com/bitcoin/bitcoin/pull/31723#discussion_r2378506262)
I've explored launching the debugger instead of attaching in a separate branch, see https://github.com/bitcoin/bitcoin/pull/31723#issuecomment-3333179240

💬 ismaelsadeeq commented on pull request "cluster mempool: control/optimize TxGraph memory usage":
(https://github.com/bitcoin/bitcoin/pull/33157#issuecomment-3333198233)
reACK 5ac32aa441bf3ec1f1fa826f689405bc4a7b7354

Changes since last ACK are nits fixes.

💬 zaidmstrr commented on pull request "rpc: Handle -named argument parsing where '=' character is used":
(https://github.com/bitcoin/bitcoin/pull/32821#discussion_r2378570634)
Added in the latest commit.

💬 zaidmstrr commented on pull request "rpc: Handle -named argument parsing where '=' character is used":
(https://github.com/bitcoin/bitcoin/pull/32821#discussion_r2378570767)
Seems good. Fixed.

💬 zaidmstrr commented on pull request "rpc: Handle -named argument parsing where '=' character is used":
(https://github.com/bitcoin/bitcoin/pull/32821#discussion_r2378570933)
Done.

💬 hebasto commented on pull request "rpcconsole: display signet challenge":
(https://github.com/bitcoin-core/gui/pull/896#issuecomment-3333308568)
cc @Sjors

👍 vasild approved a pull request: "log: reduce excessive "rolling back/forward" messages during block replay"
(https://github.com/bitcoin/bitcoin/pull/33443#pullrequestreview-3266970216)
ACK 1fc7a81f1f5f30ba3ebe305ac2a520c7b4afb596

👍 luke-jr approved a pull request: "bugfix: miner: fix `addPackageTxs` unsigned integer overflow"
(https://github.com/bitcoin/bitcoin/pull/33475#pullrequestreview-3267000636)
utACK

💬 luke-jr commented on pull request "Rollback for dumptxoutset without invalidating blocks":
(https://github.com/bitcoin/bitcoin/pull/33477#issuecomment-3333347528)
Concept ACK, this seems cleaner.

> master took 3m 17s vs 9m 16s in my last test with the code here

I suspect if you go back further, this approach will end up performing better because we no longer need to roll back forward at the end

💬 luke-jr commented on pull request "rpcconsole: display signet challenge":
(https://github.com/bitcoin-core/gui/pull/896#discussion_r2378633638)
Might be a better way to elide the middle so that a copy/paste gets the full string?

⚠️ Jamesthomas32 opened an issue: "Cryptocurrency Scam Fraud Tracing & Recovery, SMITH WHITE HACK SERVICE"
(https://github.com/bitcoin/bitcoin/issues/33479)
### Motivation

I never thought I will get scammed of all my assets on this exchange which I was warned by friends to keep off the exchange, they stole all my life saving the total funds of $850k worth of bitcoin. I couldn’t believe bitcoin can ever be recovered, all thanks to a kind hearted man called SMITH WHITE HACK SERVICE he just offered me top notch services and he is capable of offering hacking services of any sort. To that one person or persons out there who really need a true and effici
...

✅ willcl-ark closed an issue: "Cryptocurrency Scam Fraud Tracing & Recovery, SMITH WHITE HACK SERVICE"
(https://github.com/bitcoin/bitcoin/issues/33479)

💬 willcl-ark commented on issue "Cryptocurrency Scam Fraud Tracing & Recovery, SMITH WHITE HACK SERVICE":
(https://github.com/bitcoin/bitcoin/issues/33479#issuecomment-3333368905)
For general bitcoin discussion you can try [bitcointalk](https://bitcointalk.org) or [https://reddit.com/r/bitcoin](reddit.com/r/bitcoin).

💬 hebasto commented on pull request "contrib: fix for macOS deployment build failing on Qt translations even though it is optional.":
(https://github.com/bitcoin/bitcoin/pull/33358#issuecomment-3333537565)
@amishhaa

Would you mind sharing the steps to reproduce the failure?

🚀 fanquake merged a pull request: "bugfix: miner: fix `addPackageTxs` unsigned integer overflow"
(https://github.com/bitcoin/bitcoin/pull/33475)

💬 fanquake commented on pull request "bugfix: miner: fix `addPackageTxs` unsigned integer overflow":
(https://github.com/bitcoin/bitcoin/pull/33475#issuecomment-3333677484)
Backported to 30.x in #33473.

💬 hebasto commented on pull request "build: Remove CMAKE_SKIP_BUILD_RPATH and SKIP_BUILD_RPATH settings":
(https://github.com/bitcoin/bitcoin/pull/33247#discussion_r2378912338)
Is there any particular reason to capitalize "installed" here?