💬 ismaelsadeeq commented on pull request "rpc: fix getblock(header) returns target for tip":
(https://github.com/bitcoin/bitcoin/pull/33446#discussion_r2375610799)
In "test: add block 2016 to mock mainnet" 4c3c1f42cf705e039751395799240da33ca969bd

This is a bit confusing @Sjors you updated the name to `halving_period` but still use the regtest retaget period constant.

The constant should be updated `REGTEST_SUBSIDY_HALVING_INTERVAL` for regtest and also define the interval for mainet too, it can be reused in other places.

💬 ismaelsadeeq commented on pull request "rpc: fix getblock(header) returns target for tip":
(https://github.com/bitcoin/bitcoin/pull/33446#discussion_r2375621220)
In "test: add block 2016 to mock mainnet" 4c3c1f42cf705e039751395799240da33ca969bd

Is this okay to be here? Shouldn't it be in an issue to discuss the tradeoff and why those checks are added in the first place and why it should be removed?

💬 hebasto commented on pull request "depends: static libxcb-cursor":
(https://github.com/bitcoin/bitcoin/pull/33434#issuecomment-3328210405)
@davidgumberg

> Trying to do a guix build on this branch I get the following error: ...

What's the architecture of your build platform?

💬 m3dwards commented on pull request "Backport Cirrus runners to 29.x":
(https://github.com/bitcoin/bitcoin/pull/33403#issuecomment-3328222723)
ACK 5750355139eb7fc2bd11124adf46bf053be6b690

So here are all the (innocent) changed that I've found compared with PR https://github.com/bitcoin/bitcoin/pull/32989

- Windows job uses cmd rather than powershell
- i686 job file is different in 29.x
- Macos test script is different in 29.x
- Adds decreasing runner sizes
- Adds checking latest merged pulls
- Adds ci: link against -lstdc++

Tools used to compare: [Will's backport fish function](https://github.com/willcl-ark/nixos-config/b
...

💬 hebasto commented on pull request "depends: static libxcb-cursor":
(https://github.com/bitcoin/bitcoin/pull/33434#issuecomment-3328228978)
> This library is no-longer present on modern Ubuntu.

Specifically, the Ubuntu 24.04.3 LTS image from https://ubuntu.com/download/desktop does not install `libxcb-cursor0` when using the "Default selection" install option.

💬 janb84 commented on pull request "guix: documented shasum gathering command":
(https://github.com/bitcoin/bitcoin/pull/33472#issuecomment-3328233182)
Guix Build Output

```shell
9e3e3372c1bb063a575e9f6037c53a666537cf6d297116601e2f2de8092cfe61 guix-build-d29ab9946f3c/output/aarch64-linux-gnu/SHA256SUMS.part
6b1183039d07aa9ba16b50980d10d28f3c5598ad8412bb9088d3c9e66f059f43 guix-build-d29ab9946f3c/output/aarch64-linux-gnu/bitcoin-d29ab9946f3c-aarch64-linux-gnu-debug.tar.gz
d7abff7f58f2bf1813afb76226a96646b057c56f1ff8f4b5a45e309063c9c23e guix-build-d29ab9946f3c/output/aarch64-linux-gnu/bitcoin-d29ab9946f3c-aarch64-linux-gnu.tar.gz
724
...

💬 TheCharlatan commented on pull request "multiprocess: Add capnp wrapper for Chain interface":
(https://github.com/bitcoin/bitcoin/pull/29409#issuecomment-3328236725)
I tried rebasing this PR, but I'm getting a bunch of compilation errors. Can you rebase it @ryanofsky?

💬 plebhash commented on issue "`bitcoin-node` is unkillable after mining IPC connection is established":
(https://github.com/bitcoin/bitcoin/issues/33463#issuecomment-3328278574)
> Most useful thing to debug would be a stack trace, which you could get by running the process under GDB and running `thread apply all bt`.

@ryanofsky I'm on macOS, would a stack trace from LLDB be equally useful?

> Other things to try might be running with `-debug=ipc` to log IPC calls

here's logs running with `-debug=ipc`, trying to kill it with ctrl+c, not being able to, and then actually killing via `sudo kill -9`:
```
./build/bin/bitcoin-node -regtest -ipcbind=unix -debug=ipc
...
2025-0
...

💬 bitschmidty commented on pull request "docs: Undeprecate datacarrier and datacarriersize configuration options":
(https://github.com/bitcoin/bitcoin/pull/33453#issuecomment-3328286118)
> "deprecated but not currently scheduled for removal" makes no sense to me from a user point of view

I can understand where youre coming from. Confusion around this is partly due to different definitions of deprecated. Most include 'discouraged for use', yet some also add something like 'slated for future removal'. Two separate considerations in one single flag. So can end up to some as a sort of Schrödinger's deprecation.

💬 mstampfer commented on pull request "contrib: Add zsh completion scripts":
(https://github.com/bitcoin/bitcoin/pull/33402#issuecomment-3328293918)
updated 2012-2022 to 2025-present in Copyright statement
added zsh completions to README.md

💬 Sjors commented on pull request "rpc: fix getblock(header) returns target for tip":
(https://github.com/bitcoin/bitcoin/pull/33446#discussion_r2375719841)
I could rename it if I have to retouch, but at the time didn't feel like adding another constant :-)

💬 Sjors commented on pull request "rpc: fix getblock(header) returns target for tip":
(https://github.com/bitcoin/bitcoin/pull/33446#discussion_r2375723320)
It just describes how to generate the data for this test, I'm not proposing actually removing these checks in the repository.

💬 Sjors commented on pull request "rpc: fix getblock(header) returns target for tip":
(https://github.com/bitcoin/bitcoin/pull/33446#discussion_r2375726568)
Will change if I need to retouch.

💬 willcl-ark commented on pull request "macdeploy: avoid use of `Bitcoin Core` in Linux cross build":
(https://github.com/bitcoin/bitcoin/pull/33158#issuecomment-3328361231)
Guix hashes:

```
e522b04c6af1759ea97e71c01b55713685ecb0b25557a864a9fa36af26042a8d guix-build-8e434a84999c/output/arm64-apple-darwin/SHA256SUMS.part
740e33ee5d6d9a9cbc25dc0b4775e108612650b8c644f75adbce00537316abd9 guix-build-8e434a84999c/output/arm64-apple-darwin/bitcoin-8e434a84999c-arm64-apple-darwin-codesigning.tar.gz
bca939a67f3ac36c4345d61ed498d815608b4889a0e2367a2f71273e8f03b605 guix-build-8e434a84999c/output/arm64-apple-darwin/bitcoin-8e434a84999c-arm64-apple-darwin-unsigned.tar.g
...

👍 willcl-ark approved a pull request: "macdeploy: avoid use of `Bitcoin Core` in Linux cross build"
(https://github.com/bitcoin/bitcoin/pull/33158#pullrequestreview-3262868167)
ACK 8e434a84999c473a7295772a346cbce27888d28e

Changes here seem good, I also prefer the new naming.

I guess no longer deriving from CLIENT_NAME _might_ affect forks (only if they use this same build/release process?), but the rename in the guix script is currently hardcoded (to `Bitcoin-Core.zip`), so I doubt this worked for them as-is anyway.

💬 waketraindev commented on pull request "docs: Undeprecate datacarrier and datacarriersize configuration options":
(https://github.com/bitcoin/bitcoin/pull/33453#issuecomment-3328498567)
This PR is pretty much a waste of time especially when considering all the other hundreds of open PRs

💬 waketraindev commented on pull request "Add reset button and console commands for clearing output/history":
(https://github.com/bitcoin-core/gui/pull/882#issuecomment-3328509707)
Obviously this project isn't interested in this PR I'll keep it for my own use and close this PR. Thanks everyone who participated in reviews.

🤔 theStack reviewed a pull request: "rpc: combinerawtransaction now rejects unmergeable transactions"
(https://github.com/bitcoin/bitcoin/pull/31298#pullrequestreview-3262922701)
Concept ACK

💬 theStack commented on pull request "rpc: combinerawtransaction now rejects unmergeable transactions":
(https://github.com/bitcoin/bitcoin/pull/31298#discussion_r2375806658)
nit: as per our coding guidelines, [variable names should be in `camel_case`](https://github.com/bitcoin/bitcoin/blob/ad4a49090da81a3683fc50694ed7b42a80fdf90b/doc/developer-notes.md?plain=1#L38-L39), and new style should be favored over mimicking the surrounding style

💬 theStack commented on pull request "rpc: combinerawtransaction now rejects unmergeable transactions":
(https://github.com/bitcoin/bitcoin/pull/31298#discussion_r2375825517)
could test more thoroughly by repeatedly modifying other fields that commit to the txid (w/o scriptSig), but this can be done in a follow-up