Bitcoin Core Github
44 subscribers
120K links
Download Telegram
📝 asutosh23 opened a pull request: "test tenki runners"
(https://github.com/bitcoin/bitcoin/pull/33466)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...
asutosh23 closed a pull request: "test tenki runners"
(https://github.com/bitcoin/bitcoin/pull/33466)
📝 asutosh23 opened a pull request: "test tenki runners"
(https://github.com/bitcoin/bitcoin/pull/33467)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...
asutosh23 closed a pull request: "test tenki runners"
(https://github.com/bitcoin/bitcoin/pull/33467)
⚠️ jb55 opened an issue: "sqlite legacy descriptor wallet migration fails"
(https://github.com/bitcoin/bitcoin/issues/33468)
### Is there an existing issue for this?

- [x] I have searched the existing issues

### Current behaviour

the latest version of bitcoin does not load my legacy wallet, and migration doesn't work

when I try to migrate:

```
./build/bin/bitcoin-cli migratewallet personal
```

I get:

```
error code: -4
error message:
Error: This wallet is already a descriptor wallet
```

so effectively I can't use my wallet in the latest version of bitcoin.

cc @achow101

### Expected behaviour

I expect migra
...
💬 glozow commented on pull request "p2p: protect addnode peers during IBD":
(https://github.com/bitcoin/bitcoin/pull/32051#issuecomment-3325159459)
> Yes, I plan to update this as mentioned at the last meeting: https://www.erisian.com.au/bitcoin-core-dev/log-2025-08-07.html#l-302

@jonatack I'm going to mark this as draft since it's been a while. Please mark as ready for review whenever you get the chance to address the comments.
📝 glozow converted_to_draft a pull request: "p2p: protect addnode peers during IBD"
(https://github.com/bitcoin/bitcoin/pull/32051)
When an addnode peer is disconnected by our IBD headers/blocks download timeout or stalling logic, `ThreadOpenAddedConnections` attempts to immediately reconnect it (unless "onetry" was passed to the addnode RPC) up to the limit of 8 addnode connections that is separate from regular peer connection limits.

During IBD in a low-bandwidth environment, I see these disconnections+reconnections very frequently with high-quality addnode peers; see https://www.erisian.com.au/bitcoin-core-dev/log-2025
...
💬 trevarj commented on pull request "guix: update time-machine to 5cb84f2013c5b1e48a7d0e617032266f1e6059e2":
(https://github.com/bitcoin/bitcoin/pull/33185#issuecomment-3325186341)
Here is a time-machine commit ([1aa6da547d](https://codeberg.org/guix/guix/commit/1aa6da547dac764f72476b155b26844e3d93b632)) from yesterday, with small changes applied: https://github.com/bitcoin/bitcoin/commit/569ef2cb52ddab7253991bd622a661191a2ada3c

Only got around to building for the x86_64-linux-gnu target.

```
c6c16e7c6a99609b333bdf1ebeb2d66fe775c9e64e1808bf4d8e94d7c7d40203 dist-archive/bitcoin-569ef2cb52dd.tar.gz
58125ee3e19841480e325573fd10be009aaa0efb28afdcbbfdeeba5e03743a5d x
...
🚀 glozow merged a pull request: "test: don't throw from the destructor of DebugLogHelper"
(https://github.com/bitcoin/bitcoin/pull/33388)
💬 jb55 commented on issue "sqlite legacy descriptor wallet migration fails":
(https://github.com/bitcoin/bitcoin/issues/33468#issuecomment-3325250806)
commenting out that check didn't seem to harm anything and it migrated successfully.

```patch
diff --git a/src/wallet/wallet.cpp b/src/wallet/wallet.cpp
index 6b5d08b0a3ad..150d79749324 100644
--- a/src/wallet/wallet.cpp
+++ b/src/wallet/wallet.cpp
@@ -4230,9 +4230,9 @@ util::Result<MigrationResult> MigrateLegacyToDescriptor(std::shared_ptr<CWallet>
const std::string wallet_name = local_wallet->GetName();

// Before anything else, check if there is something to migrate.
- if (loca
...
🚀 glozow merged a pull request: "wallet: Set descriptor cache upgraded flag for migrated wallets"
(https://github.com/bitcoin/bitcoin/pull/33031)
💬 glozow commented on pull request "cli: Handle arguments that can be either JSON or string":
(https://github.com/bitcoin/bitcoin/pull/33230#issuecomment-3325276784)
Needs rebase for #33031, which was merged first per the author's request.
👋 fanquake's pull request is ready for review: "[30.0] Final changes + rc2"
(https://github.com/bitcoin/bitcoin/pull/33424)
👋 mzumsande's pull request is ready for review: "p2p: Use network-dependent timers for inbound inv scheduling"
(https://github.com/bitcoin/bitcoin/pull/33464)
🤔 glozow reviewed a pull request: "docs: Undeprecate datacarrier and datacarriersize configuration options"
(https://github.com/bitcoin/bitcoin/pull/33453#pullrequestreview-3259349531)
This is the 3rd PR since #32406's merge discussing what the config options' docs should say. Given how much collective effort this has required, I think we should be realistic about what this PR achieves.

I believe this PR tries to align the documentation with what users can expect. Usage of these options can cause the node to reject transactions that are likely to be mined, so the docs should discourage their use (to me, that means deprecated). However, it seems that removal in the near futu
...
💬 glozow commented on pull request "docs: Undeprecate datacarrier and datacarriersize configuration options":
(https://github.com/bitcoin/bitcoin/pull/33453#discussion_r2373272312)
I'd agree with this approach
👍 willcl-ark approved a pull request: "[30.0] Final changes + rc2"
(https://github.com/bitcoin/bitcoin/pull/33424#pullrequestreview-3259382528)
ACK 7ebdfa2173b90faad71057d37b6b71c462dd3ea1

Backports are clean.

None added to release notes, but I don't think any particularly need to be (#33333 could be the only potential candidate here IMO).
💬 achow101 commented on issue "sqlite legacy descriptor wallet migration fails":
(https://github.com/bitcoin/bitcoin/issues/33468#issuecomment-3325340756)
Can you be more specific as to which configuration you had? Was it bdb-descriptor or sqlite-legacy?

Either way, both of those are not supported wallet configurations and are not possible to create without modifying the software.
🚀 fanquake merged a pull request: "msvc: Update vcpkg manifest"
(https://github.com/bitcoin/bitcoin/pull/33408)
💬 achow101 commented on pull request "cli: Handle arguments that can be either JSON or string":
(https://github.com/bitcoin/bitcoin/pull/33230#issuecomment-3325352104)
Rebased