🚀 fanquake merged a pull request: "ci: disable cirrus cache in 32bit arm job"
(https://github.com/bitcoin/bitcoin/pull/33302)

💬 maflcko commented on pull request "log: reduce excessive "rolling forward" messages during block replay":
(https://github.com/bitcoin/bitcoin/pull/33443#discussion_r2372269835)
I also agree that errors and warnings should be rate limited. Errors are fatal, so should only be printed once, before the program aborts. Warnings should be rare, unless there is a coding bug, in which case the rate limiting seems useful.

The only place where side-stepping the rate limiting makes sense is the info level. If `LogEssential` is named too harmless, it could be named `LogInfoWithoutRateLimiting`, so that the slightly verbose name discourages using it in places where it is not app
...

💬 fanquake commented on pull request "ci: disable cirrus cache in 32bit arm job":
(https://github.com/bitcoin/bitcoin/pull/33302#issuecomment-3323947804)
Backported to 30.x in #33424.

👍 instagibbs approved a pull request: "net/rpc: Report inv information for debugging"
(https://github.com/bitcoin/bitcoin/pull/33448#pullrequestreview-3257937613)
ACK 2738b63e025d240618b3c72c28243c3e4d7d9c79

💬 instagibbs commented on pull request "net/rpc: Report inv information for debugging":
(https://github.com/bitcoin/bitcoin/pull/33448#discussion_r2372277388)
nit: double-checked before and after to check effects of test

```
diff --git a/test/functional/p2p_leak_tx.py b/test/functional/p2p_leak_tx.py
index 42e586fca3..d302a68ebf 100755
--- a/test/functional/p2p_leak_tx.py
+++ b/test/functional/p2p_leak_tx.py
@@ -39,4 +39,9 @@ class P2PLeakTxTest(BitcoinTestFramework):
inbound_peer.last_message.pop("inv", None)

+ assert_equal(self.gen_node.getrawmempool(False, True), {'txids': [], 'mempool_sequence': 1})
+ pi = self
...

💬 fanquake commented on pull request "doc: remove unrelated `bitcoin-wallet` binary from `libbitcoin_ipc` description":
(https://github.com/bitcoin/bitcoin/pull/33459#issuecomment-3323956409)
Assuming these docs came from #10102, which introduces a `bitcoin-wallet` process. Removing seems fine for now.

🚀 fanquake merged a pull request: "doc: remove unrelated `bitcoin-wallet` binary from `libbitcoin_ipc` description"
(https://github.com/bitcoin/bitcoin/pull/33459)

💬 sipa commented on pull request "cluster mempool: control/optimize TxGraph memory usage":
(https://github.com/bitcoin/bitcoin/pull/33157#discussion_r2372295604)
`GraphIndex` is unsigned, so that would literally always be true?

💬 instagibbs commented on pull request "cluster mempool: control/optimize TxGraph memory usage":
(https://github.com/bitcoin/bitcoin/pull/33157#discussion_r2372314425)
huh, huge reading comprehension issues. I distinctly recall checking, sad!

💬 sipa commented on pull request "cluster mempool: control/optimize TxGraph memory usage":
(https://github.com/bitcoin/bitcoin/pull/33157#discussion_r2372336256)
Done.

💬 sipa commented on pull request "cluster mempool: control/optimize TxGraph memory usage":
(https://github.com/bitcoin/bitcoin/pull/33157#discussion_r2372336983)
Done something like this.

💬 sipa commented on pull request "cluster mempool: control/optimize TxGraph memory usage":
(https://github.com/bitcoin/bitcoin/pull/33157#discussion_r2372342553)
Added a comment that `BlockBuilder`s are excluded from the memory usage.

Agreed w.r.t `ordered_set`, but will leave for a follow-up.

💬 vasild commented on pull request "net: support overriding the proxy selection in ConnectNode()":
(https://github.com/bitcoin/bitcoin/pull/33454#issuecomment-3324028544)
`48c5939cf4...ec7c215345`: do https://github.com/bitcoin/bitcoin/pull/33454#discussion_r2372128145

💬 sipa commented on pull request "cluster mempool: control/optimize TxGraph memory usage":
(https://github.com/bitcoin/bitcoin/pull/33157#discussion_r2372343531)
Added an `Assume(graph_idx != GraphIndex(-1));` here for extra safety.

💬 vasild commented on pull request "net: support overriding the proxy selection in ConnectNode()":
(https://github.com/bitcoin/bitcoin/pull/33454#discussion_r2372343874)
Right, done!

💬 sipa commented on pull request "cluster mempool: control/optimize TxGraph memory usage":
(https://github.com/bitcoin/bitcoin/pull/33157#discussion_r2372343983)
Done.

✅ fanquake closed an issue: "oss-fuzz: build failing"
(https://github.com/bitcoin/bitcoin/issues/33366)

💬 Kruwed commented on pull request "docs: Undeprecate datacarrier and datacarriersize configuration options":
(https://github.com/bitcoin/bitcoin/pull/33453#issuecomment-3324053860)
>There are more people who want to set it to non-default value today than ever before.

This is a justification for why the deprecated options should be removed as quickly as possible, not a justification for making a footgun available to these people.

🚀 fanquake merged a pull request: "rpc: Always return per-wtxid entries in submitpackage tx-results"
(https://github.com/bitcoin/bitcoin/pull/33427)

💬 moonsettler commented on pull request "docs: Undeprecate datacarrier and datacarriersize configuration options":
(https://github.com/bitcoin/bitcoin/pull/33453#issuecomment-3324066344)
> This is a justification for why the deprecated options should be removed as quickly as possible, not a justification for making a footgun available to these people.

It's not any more a "footgun" than `blocksonly`. Which is not deprecated. That word should be reserved for situations that can result in loss of funds.