💬 sipa commented on pull request "Exponentially-decaying tx inventory queue":
(https://github.com/bitcoin/bitcoin/pull/33449#issuecomment-3318182715)
Needs more though, closing for now.

💬 sdaftuar commented on pull request "Cluster mempool implementation":
(https://github.com/bitcoin/bitcoin/pull/28676#discussion_r2367627572)
I added a commit to the end of this PR that should fix this issue. As I was working on this, I was thinking about your comment above about reworking the TRUC checks to just grab the clusters it needs directly from txgraph. The issue with that in the way our code works right now is that we can't fully realize our staging clusters until we've added all the transactions, applied dependencies, and staged all the RBF removals.

If we went ahead and imposed a topology requirement on transaction pa
...

🤔 BrandonOdiwuor reviewed a pull request: "depends: Switch from multilib to platform-specific toolchains"
(https://github.com/bitcoin/bitcoin/pull/32162#pullrequestreview-3251938458)
Approach ACK 5f061f5abdee3b1bf83844d72d821f031d2583cc

Tested Linux `ARM64` to `x86_64` cross-compilation in Docker on MacOS 26.0 host. Builds succeeded without `multilib`

**Building on Ubuntu 22.04 `arm64`**

```bash
$ sudo apt install g++-x86-64-linux-gnu binutils-x86-64-linux-gnu
$ export HOST=x86_64-linux-gnu
$ gmake -C depends -j $(nproc)
$ cmake -B build-${HOST} --toolchain depends/${HOST}/toolchain.cmake
$ cmake --build build-${HOST} -j $(nproc)
```

<img width="1512" heigh
...

💬 jlopp commented on pull request "datacarrier: Undeprecate configuration option":
(https://github.com/bitcoin/bitcoin/pull/33453#issuecomment-3318248192)
Concept ACK.

1. Defaults are strong; we should expect relatively few users will change this setting.
2. We understand that transaction propagation requires relatively few nodes with loose policy rules.
3. I think it's minimal impact and gives users more freedom to operate their node as they wish.

💬 delta1 commented on pull request "datacarrier: Undeprecate configuration option":
(https://github.com/bitcoin/bitcoin/pull/33453#issuecomment-3318248443)
Concept ACK

💬 portlandhodl commented on pull request "datacarrier: Undeprecate configuration option":
(https://github.com/bitcoin/bitcoin/pull/33453#issuecomment-3318298854)
Concept Ack assuming a long window before revaluation to deprecate

- The value to the reduced social DoS would be higher than the cost of keeping the deprecation.
- Not that it's needed but further proof that deprecation doesn't always lead to deprecation ultimately which is a good thing.
- Would give devs more time to understand the core users of this option after removal of previous limits.

Concern: That if decided to be deprecated in the future this could lead to campaigns by other
...

🤔 moonsettler reviewed a pull request: "datacarrier: Undeprecate configuration option"
(https://github.com/bitcoin/bitcoin/pull/33453#pullrequestreview-3252007580)
ACK

The arguments about the burden to further maintain the option are way overstated and therefore incredibly weak.

💬 hebasto commented on pull request "Modernize use of UTF-8 in Windows code":
(https://github.com/bitcoin/bitcoin/pull/32380#discussion_r2367755093)
Thanks! Fixed.

💬 hebasto commented on pull request "Modernize use of UTF-8 in Windows code":
(https://github.com/bitcoin/bitcoin/pull/32380#issuecomment-3318353570)
The [feedback](https://github.com/bitcoin/bitcoin/pull/32380#discussion_r2367130713) from @hodlinator has been addressed.

💬 CodeShark commented on pull request "datacarrier: Undeprecate configuration option":
(https://github.com/bitcoin/bitcoin/pull/33453#issuecomment-3318364747)
Concept ACK

Some users clearly still want this option and keeping this option in doesn't negatively impact any other users nor make the code harder to maintain than having the option marked as deprecated. It's a really bad idea to alienate users over this.

I also suggest making it clear to endusers as well as packagers and node-in-a-box vendors that this option is still around and to make it easy for them to use it. Regardless of whether we think using this option has the purported effects
...

💬 kevkevinpal commented on pull request "datacarrier: Undeprecate configuration option":
(https://github.com/bitcoin/bitcoin/pull/33453#issuecomment-3318400618)
Concept ACK

I agree that removing the deprecation does not have a major effect on users, and it also gives users who want to use this flag a signal that it will not be removed in a future release. I see no issue in offering flexibility for node runners.

Is this able to be added to the v30 milestone? https://github.com/bitcoin/bitcoin/milestone/72

💬 reardencode commented on pull request "datacarrier: Undeprecate configuration option":
(https://github.com/bitcoin/bitcoin/pull/33453#issuecomment-3318413226)
Concept NACK

* bitcoin core is not here to be everyone's everything implementation. It's here to be the best software for operating the network.
* Adding, or in this case not removing, code with only negative effects on the actual operation of users' nodes is not responsible stewardship of bitcoin.
* Bowing to demands from people who do not understand what they are asking for (as repeatedly demonstrated in online argumentation) is not how any successful project can operate.

These issues
...

💬 hebasto commented on pull request "depends: Switch from multilib to platform-specific toolchains":
(https://github.com/bitcoin/bitcoin/pull/32162#issuecomment-3318413899)
Rebased to resolve a conflict with the merged https://github.com/bitcoin/bitcoin/pull/31802.

💬 0xB10C commented on pull request "datacarrier: Undeprecate configuration option":
(https://github.com/bitcoin/bitcoin/pull/33453#issuecomment-3318432100)
fwiw: If/when this is merged, the [draft release notes](https://github.com/bitcoin-core/bitcoin-devwiki/wiki/v30.0-Release-Notes-Draft#policy) should be updated. They mention: `Both -datacarrier and -datacarriersize options have been marked as deprecated and are expected to be removed in a future release.`

💬 RandyMcMillan commented on pull request "datacarrier: Undeprecate configuration option":
(https://github.com/bitcoin/bitcoin/pull/33453#issuecomment-3318573615)
Concept ACK

🤔 Eunovo reviewed a pull request: "log: always print initial script verification state"
(https://github.com/bitcoin/bitcoin/pull/33336#pullrequestreview-3252294836)
Left a few comments

💬 Eunovo commented on pull request "log: always print initial script verification state":
(https://github.com/bitcoin/bitcoin/pull/33336#discussion_r2367994445)
https://github.com/bitcoin/bitcoin/pull/33336/commits/c99fde2c0ac181da656e8c942fa6fea93713de75: wouldn't it be better to just do `std::optional<std::string> script_check_reason`?

💬 Eunovo commented on pull request "log: always print initial script verification state":
(https://github.com/bitcoin/bitcoin/pull/33336#discussion_r2367997436)
https://github.com/bitcoin/bitcoin/pull/33336/commits/c99fde2c0ac181da656e8c942fa6fea93713de75: I think this was better as `std::optional<bool>`

💬 vasild commented on pull request "test: don't throw from the destructor of DebugLogHelper":
(https://github.com/bitcoin/bitcoin/pull/33388#discussion_r2368062584)
Will do if I retouch. Change applied locally.

💬 RandyMcMillan commented on pull request "datacarrier: Undeprecate configuration option":
(https://github.com/bitcoin/bitcoin/pull/33453#issuecomment-3318711118)
you should probably revert

https://github.com/bitcoin/bitcoin/pull/32406/commits/63091b79e70b8e230a122fa6fb3dac91c80638e7

as well