💬 vasild commented on pull request "system: improve handling around GetTotalRAM()":
(https://github.com/bitcoin/bitcoin/pull/33435#issuecomment-3318101491)
`8fcf71ca00...56791b5829`: take suggestions

💬 vasild commented on pull request "system: improve handling around GetTotalRAM()":
(https://github.com/bitcoin/bitcoin/pull/33435#discussion_r2367509262)
Done.

💬 vasild commented on pull request "system: improve handling around GetTotalRAM()":
(https://github.com/bitcoin/bitcoin/pull/33435#discussion_r2367509839)
Done.

💬 sdaftuar commented on pull request "Cluster mempool implementation":
(https://github.com/bitcoin/bitcoin/pull/28676#discussion_r2367523246)
Did the latter, thanks.

👍 hebasto approved a pull request: "system: improve handling around GetTotalRAM()"
(https://github.com/bitcoin/bitcoin/pull/33435#pullrequestreview-3251759768)
ACK 56791b582958e905e5ba5cbf172a8ea7dad1a8b0.

💬 sdaftuar commented on pull request "Cluster mempool implementation":
(https://github.com/bitcoin/bitcoin/pull/28676#discussion_r2367557960)
Done in 7cebfec8a6197a260e8c21f4637fad5d60163cfa

💬 sdaftuar commented on pull request "Cluster mempool implementation":
(https://github.com/bitcoin/bitcoin/pull/28676#discussion_r2367560636)
Fixed.

💬 sdaftuar commented on pull request "Cluster mempool implementation":
(https://github.com/bitcoin/bitcoin/pull/28676#discussion_r2367572401)
Should be better now

📝 bitschmidty opened a pull request: "datacarrier: Undeprecate configuration option"
(https://github.com/bitcoin/bitcoin/pull/33453)
Removes the deprecation for the `datacarrier` and `datacarriersize` options by reverting commit 0b4048c73385166144d0b3e76beb9a2ac4cc1eca from https://github.com/bitcoin/bitcoin/pull/32406

**Many current Bitcoin Core users want to continue using this option**
This statement is based on public postings from many Bitcoin Core users and not a formal survey. AJ Towns’ observation from [#32406](https://github.com/bitcoin/bitcoin/pull/32406/commits/0b4048c73385166144d0b3e76beb9a2ac4cc1eca#r20840248
...

💬 sdaftuar commented on pull request "Cluster mempool implementation":
(https://github.com/bitcoin/bitcoin/pull/28676#discussion_r2367581993)
Fixed now.

💬 bitschmidty commented on pull request "datacarrier: Undeprecate configuration option":
(https://github.com/bitcoin/bitcoin/pull/33453#issuecomment-3318166185)
I open this PR with the goal of having the deprecation removed for the upcoming v30 release, in order to minimize any additional confusion around this option.

I ask that any Bitcoin Core users that want to indicate support or opposition to this PR without providing technical feedback use the 👍 or 👎 reactions rather than an ACK/NACK in hopes of keeping this PR easy and expeditious to review.

_Disclaimer: I am the executive director of Brink, an organization that funds some Bitcoin Core de
...

💬 sdaftuar commented on pull request "Cluster mempool implementation":
(https://github.com/bitcoin/bitcoin/pull/28676#discussion_r2367587173)
Done.

✅ sipa closed a pull request: "Exponentially-decaying tx inventory queue"
(https://github.com/bitcoin/bitcoin/pull/33449)

💬 sipa commented on pull request "Exponentially-decaying tx inventory queue":
(https://github.com/bitcoin/bitcoin/pull/33449#issuecomment-3318182715)
Needs more though, closing for now.

💬 sdaftuar commented on pull request "Cluster mempool implementation":
(https://github.com/bitcoin/bitcoin/pull/28676#discussion_r2367627572)
I added a commit to the end of this PR that should fix this issue. As I was working on this, I was thinking about your comment above about reworking the TRUC checks to just grab the clusters it needs directly from txgraph. The issue with that in the way our code works right now is that we can't fully realize our staging clusters until we've added all the transactions, applied dependencies, and staged all the RBF removals.

If we went ahead and imposed a topology requirement on transaction pa
...

🤔 BrandonOdiwuor reviewed a pull request: "depends: Switch from multilib to platform-specific toolchains"
(https://github.com/bitcoin/bitcoin/pull/32162#pullrequestreview-3251938458)
Approach ACK 5f061f5abdee3b1bf83844d72d821f031d2583cc

Tested Linux `ARM64` to `x86_64` cross-compilation in Docker on MacOS 26.0 host. Builds succeeded without `multilib`

**Building on Ubuntu 22.04 `arm64`**

```bash
$ sudo apt install g++-x86-64-linux-gnu binutils-x86-64-linux-gnu
$ export HOST=x86_64-linux-gnu
$ gmake -C depends -j $(nproc)
$ cmake -B build-${HOST} --toolchain depends/${HOST}/toolchain.cmake
$ cmake --build build-${HOST} -j $(nproc)
```

<img width="1512" heigh
...

💬 jlopp commented on pull request "datacarrier: Undeprecate configuration option":
(https://github.com/bitcoin/bitcoin/pull/33453#issuecomment-3318248192)
Concept ACK.

1. Defaults are strong; we should expect relatively few users will change this setting.
2. We understand that transaction propagation requires relatively few nodes with loose policy rules.
3. I think it's minimal impact and gives users more freedom to operate their node as they wish.

💬 delta1 commented on pull request "datacarrier: Undeprecate configuration option":
(https://github.com/bitcoin/bitcoin/pull/33453#issuecomment-3318248443)
Concept ACK

💬 portlandhodl commented on pull request "datacarrier: Undeprecate configuration option":
(https://github.com/bitcoin/bitcoin/pull/33453#issuecomment-3318298854)
Concept Ack assuming a long window before revaluation to deprecate

- The value to the reduced social DoS would be higher than the cost of keeping the deprecation.
- Not that it's needed but further proof that deprecation doesn't always lead to deprecation ultimately which is a good thing.
- Would give devs more time to understand the core users of this option after removal of previous limits.

Concern: That if decided to be deprecated in the future this could lead to campaigns by other
...

🤔 moonsettler reviewed a pull request: "datacarrier: Undeprecate configuration option"
(https://github.com/bitcoin/bitcoin/pull/33453#pullrequestreview-3252007580)
ACK

The arguments about the burden to further maintain the option are way overstated and therefore incredibly weak.