💬 fanquake commented on pull request "ci: re-add Valgrind job to the CI":
(https://github.com/bitcoin/bitcoin/pull/33411#issuecomment-3306492286)
Adjusted to remove the conflict with #31425 and add context to the final commit.

💬 fanquake commented on pull request "test: Avoid interface_ipc.py Duplicate ID errors":
(https://github.com/bitcoin/bitcoin/pull/33420#issuecomment-3306564783)
I also haven't reproduced the issue, using the steps provided. i.e installing libmulitprocess system-wide in a new VM, and then building Core & running `interface_ipc.py`. Can someone list the steps to reach the failure, using a clean VM.

📝 fanquake opened a pull request: "[30.0] Final changes + rc2"
(https://github.com/bitcoin/bitcoin/pull/33424)
Backports:
*

Finalise `v30.0rc2`

💬 zaidmstrr commented on pull request "test: Avoid interface_ipc.py Duplicate ID errors":
(https://github.com/bitcoin/bitcoin/pull/33420#issuecomment-3306614491)
Here are the steps to reproduce the error in Ubuntu based systems:
1) Install `libmultiprocess` library system using `sudo make install`
2) Then install `capnp` system-wide. You can refer [this](https://capnproto.org/install.html) for the installation. After succesfully downloading the `capnp` library you can check using the `which capnp` command, which outputs the default location of the installed binary. In most of the cases the location was `/usr/local/bin/capnp`.
3) Now run the `interface
...

💬 fanquake commented on pull request "test: Avoid interface_ipc.py Duplicate ID errors":
(https://github.com/bitcoin/bitcoin/pull/33420#issuecomment-3306666201)
Thanks, repro'd:
```bash
Remaining jobs: [interface_ipc.py]
1/1 - interface_ipc.py failed, Duration: 1 s

stdout:
2025-09-18T10:18:46.257357Z TestFramework (INFO): PRNG seed is: 5267162394658679552
2025-09-18T10:18:46.257836Z TestFramework (INFO): Initializing test directory /tmp/test_runner_₿_🏃_20250918_101846/interface_ipc_0


stderr:
terminate called after throwing an instance of 'kj::ExceptionImpl'
what(): mp/proxy.capnp:0: failed: Duplicate ID @0xcc316e3f71a040fb.



TES
...

💬 zaidmstrr commented on pull request "rpc: Handle -named argument parsing where '=' character is used":
(https://github.com/bitcoin/bitcoin/pull/32821#discussion_r2358417517)
Thanks, fixed.

💬 zaidmstrr commented on pull request "rpc: Handle -named argument parsing where '=' character is used":
(https://github.com/bitcoin/bitcoin/pull/32821#discussion_r2358418317)
Fixed.

💬 zaidmstrr commented on pull request "rpc: Handle -named argument parsing where '=' character is used":
(https://github.com/bitcoin/bitcoin/pull/32821#discussion_r2358419428)
Fixed.

🚀 fanquake merged a pull request: "test: Avoid interface_ipc.py Duplicate ID errors"
(https://github.com/bitcoin/bitcoin/pull/33420)

💬 fanquake commented on pull request "test: Avoid interface_ipc.py Duplicate ID errors":
(https://github.com/bitcoin/bitcoin/pull/33420#issuecomment-3306737091)
Backported to 30.x in #33424.

💬 HowHsu commented on pull request "index: Fix missing case in the comment in NextSyncBlock()":
(https://github.com/bitcoin/bitcoin/pull/32875#issuecomment-3306769093)
> ```c++
> CBlockIndex* NextInclRewind(const CBlockIndex* pindex) const
> {
> if (!Contains(Assert(pindex))) {
> pindex = Assert(FindFork(pindex));
> }
> return (*this)[pindex->nHeight + 1];
> }
> ```

Hi Luke,
If I'm getting you wrong, `NextInclRewind()` will be a method member of CChain, but from my perspective, this function seems
tailored to a very specific scenario. To keep the class more general and lightweight, it might be better
...

💬 ryanofsky commented on pull request "test: Avoid interface_ipc.py Duplicate ID errors":
(https://github.com/bitcoin/bitcoin/pull/33420#issuecomment-3306783651)
> I also haven't reproduced the issue, using the steps provided. i.e installing libmulitprocess system-wide in a new VM, and then building Core & running `interface_ipc.py`.

Yeah, an additional requirement for the bug to happen is that cap'nproto and libmultiprocess need to be installed in the same prefix. If you are using a system provided cap'n proto installed in `/usr` and a locally build libmultiprocess installed in `/usr/local` the bug won't happen. They both need to be installed in `/us
...

💬 HowHsu commented on pull request "checkqueue: implement a new scriptcheck worker pool with atomic variables":
(https://github.com/bitcoin/bitcoin/pull/32791#issuecomment-3306849241)
> > hmmm...Ok, I realized that this may only be suitable for when all the preout Coin are in CCoinsViewCache, otherwise the `Add()` is not fast due to I/O there.
>
> With #31132 , this one makes sense again, need to test them together in all-cache-miss case

Tested this one and [](https://github.com/bitcoin/bitcoin/pull/31132) combined with about 100+ contiguous real blocks in mainnet from height 840000, by the method I mentioned in [](https://github.com/bitcoin/bitcoin/issues/33375#issueco
...

📝 fanquake opened a pull request: "ci: run native_fuzz_with_msan"
(https://github.com/bitcoin/bitcoin/pull/33425)
How fast does this run (minus the Clang build)?

⚠️ janb84 opened an issue: "Guix: build riscv64 master / v30rc1 fails"
(https://github.com/bitcoin/bitcoin/issues/33426)
### Is there an existing issue for this?

- [x] I have searched the existing issues

### Current behaviour

While building a guix-build of v30rc1 or main for `riscv64-linux-gnu` architecture fails with :

```console
[100%] Linking CXX executable ../../bin/test_bitcoin
riscv64-linux-gnu-ld: CMakeFiles test_bitcoin.dir/main.cpp.o: in function "boost::fpe::disable(unsigned int)':
bitcoin depends/riscv64-linux-gnu/include/boost/test/impl/execution_monitor.ipp:1538: warning: fedisableexcept is not i
...

👋 fanquake's pull request is ready for review: "ci: run native_fuzz_with_msan"
(https://github.com/bitcoin/bitcoin/pull/33425)

📝 fanquake converted_to_draft a pull request: "ci: run native_fuzz_with_msan"
(https://github.com/bitcoin/bitcoin/pull/33425)
How fast does this run (minus the Clang build)?

💬 janb84 commented on issue "v30.0 Testing":
(https://github.com/bitcoin/bitcoin/issues/33368#issuecomment-3306961384)
Linking to https://github.com/bitcoin/bitcoin/issues/33426 (semi related to this testing)
Guix build for riscv64 fails on master & 30.0rc1

💬 fanquake commented on issue "Guix: build riscv64 master / v30rc1 fails":
(https://github.com/bitcoin/bitcoin/issues/33426#issuecomment-3306969096)
Can you provide more info. These warnings have existed for years (i.e are in the 29.x branch that builds for you), and build warnings shouldn't cause guix build failures.

💬 janb84 commented on issue "Guix: build riscv64 master / v30rc1 fails":
(https://github.com/bitcoin/bitcoin/issues/33426#issuecomment-3307000340)
going to hunt down some more information.

The difference between 29.x and master / v30.0.rc1 on line 146 of the make file is IPC:

line 146:
```cmake
if(ENABLE_IPC AND WITH_EXTERNAL_LIBMULTIPROCESS)
find_package(Libmultiprocess REQUIRED COMPONENTS Lib)
find_package(LibmultiprocessNative REQUIRED COMPONENTS Bin
NAMES Libmultiprocess
)
endif()
```