💬 enirox001 commented on pull request "Split `CWallet::Create()` into `CreateNew` and `LoadExisting`":
(https://github.com/bitcoin/bitcoin/pull/32636#discussion_r2356299627)
In 8b6a8a0 it seems the `WriteVersion` method uses `CLIENT_VERSION` instead of the `client_version` parameter

💬 hodlinator commented on pull request "build: Remove bitness suffix from Windows installer":
(https://github.com/bitcoin/bitcoin/pull/32132#issuecomment-3304068622)
> When upgrading to v30.0, it appears necessary to uninstall first in order to remove the "... (64-bit)" Start Menu entries. Otherwise, they remain lingering.

Can confirm, I ended up having to remove the "... (64-bit)"-entry in the list of installed programs manually through Regedit - not ideal. :\

💬 achow101 commented on pull request "[28.x] More backports":
(https://github.com/bitcoin/bitcoin/pull/33415#issuecomment-3304092285)
Should we also backport #33106 if we're going to be doing a 28.3 anyways?

💬 m3dwards commented on pull request "ci: Skip Centos job on GHA runners":
(https://github.com/bitcoin/bitcoin/pull/33365#issuecomment-3304121898)
Looks fine. I don't have strong feelings, and wouldn't NACK this, but my preference leans more towards having things still run on forks on GHA runners as it does for the main org albeit slower. Also has the benefit of having a bit less vendor lock in.

💬 l0rinc commented on pull request "coins: warn on oversized `-dbcache`":
(https://github.com/bitcoin/bitcoin/pull/33333#discussion_r2356399465)
Added comment and updated commit message

💬 l0rinc commented on pull request "coins: warn on oversized `-dbcache`":
(https://github.com/bitcoin/bitcoin/pull/33333#discussion_r2356399704)
Done

💬 achow101 commented on pull request "wallet: reduce unconditional logging during load":
(https://github.com/bitcoin/bitcoin/pull/33299#discussion_r2356408987)
There's already a similar `count == 1` check above for first time initialization that this log line can be moved into.

📝 ismaelsadeeq opened a pull request: "node: add `BlockTemplateCache` "
(https://github.com/bitcoin/bitcoin/pull/33421)
This PR implements the first step of #33389.

Main motivation and design rationale are discussed in #33389.

It introduces a `BlockTemplateCache` exposed via the node interfaces.

Block template requests from other node components should go through the cache. Each request specifies the **maximum age** of the template in seconds. If a cached template exists with matching configuration and is still fresh, it is returned; otherwise, a new template with the requested configuration is generated
...

💬 ismaelsadeeq commented on pull request "cluster mempool: control/optimize TxGraph memory usage":
(https://github.com/bitcoin/bitcoin/pull/33157#discussion_r2356456729)
Thanks for the context.
For anyone that wants to dig in, the `testmempoolaccept` third level was discussed here https://github.com/bitcoin/bitcoin/issues/32160

💬 m3dwards commented on pull request "ci: disable cirrus cache in 32bit arm job":
(https://github.com/bitcoin/bitcoin/pull/33302#issuecomment-3304201962)
ACK 00c253d494176b31dc4aaba24dc7e61aecb20be2

💬 mzumsande commented on pull request "wallet: reduce unconditional logging during load":
(https://github.com/bitcoin/bitcoin/pull/33299#discussion_r2356471364)
I did that at first but changed it on purpose - in case the result of `SQLiteDatabaseVersion()` depended on `sqlite3_initialize` (which it doesn't currently, but doesn't seem completely unreasonable) we'd log the correct thing here too.

💬 TheCharlatan commented on pull request "kernel: Flush in ChainstateManager destructor":
(https://github.com/bitcoin/bitcoin/pull/31382#issuecomment-3304242647)
Rebased 8512349ccd73c7acd8ccd6d4c2708459bdce3301 -> 6137cecfd3a448c2befe043849fce0b4ea2cd1fe ([chainman_flush_destructor_6](https://github.com/TheCharlatan/bitcoin/tree/chainman_flush_destructor_6) -> [chainman_flush_destructor_7](https://github.com/TheCharlatan/bitcoin/tree/chainman_flush_destructor_7), [compare](https://github.com/TheCharlatan/bitcoin/compare/chainman_flush_destructor_6..chainman_flush_destructor_7))

💬 achow101 commented on pull request "wallet: reduce unconditional logging during load":
(https://github.com/bitcoin/bitcoin/pull/33299#issuecomment-3304378366)
ACK 862faf3fa7a42238017f8d673b0c656531c688dc

💬 achow101 commented on pull request "coins: warn on oversized `-dbcache`":
(https://github.com/bitcoin/bitcoin/pull/33333#issuecomment-3304387000)
ACK 168360f4ae47cbfdb30a2cc4704435bc67e12f16

🤔 w0xlt reviewed a pull request: "coins: warn on oversized `-dbcache`"
(https://github.com/bitcoin/bitcoin/pull/33333#pullrequestreview-3236080193)
reACK https://github.com/bitcoin/bitcoin/pull/33333/commits/168360f4ae47cbfdb30a2cc4704435bc67e12f16

👍 hodlinator approved a pull request: "coins: warn on oversized `-dbcache`"
(https://github.com/bitcoin/bitcoin/pull/33333#pullrequestreview-3236121502)
re-ACK 168360f4ae47cbfdb30a2cc4704435bc67e12f16

💬 achow101 commented on pull request "wallet: warn against accidental unsafe older() import":
(https://github.com/bitcoin/bitcoin/pull/33135#discussion_r2356702196)
In 5e9737ff493a96566f4fc11b1733b4b5a5393f6b "wallet: warn against accidental unsafe older() import"

This warning is basically incomprehensible. It would be better to actually write out what it means, i.e. "time based relative locktime > 65535 is unsafe"

💬 davidgumberg commented on pull request "ci: remove 3rd party js from windows dll gha job":
(https://github.com/bitcoin/bitcoin/pull/32513#discussion_r2356706408)
```suggestion
shell: pwsh -Command "$PSVersionTable; $PSNativeCommandUseErrorActionPreference = $true; $ErrorActionPreference = 'Stop'; & '{0}'"
```

🤔 davidgumberg reviewed a pull request: "ci: remove 3rd party js from windows dll gha job"
(https://github.com/bitcoin/bitcoin/pull/32513#pullrequestreview-3236170764)
Nice! Looks good, there are still two places where `shell: pwsh` is used without your ` -Command "$PSVersionTable; $PSNativeCommandUseErrorActionPreference = $true; $ErrorActionPreference = 'Stop'; & '{0}'"` suffix:


https://github.com/bitcoin/bitcoin/blob/c44fb4facfd3a5db8aa1bd2c7f5506a1477b0d2b/.github/workflows/ci.yml#L225

and

Not a big deal for this since it's only using powershell cmdlets now, but for the sake of consistency
https://github.com/bitcoin/bitcoin/blob/c44fb4facfd3a5d
...

💬 andrewtoth commented on pull request "validation: fetch block inputs on parallel threads 10% faster IBD":
(https://github.com/bitcoin/bitcoin/pull/31132#issuecomment-3304494917)
> Looks like the CI started failing, due to too many threads being launched in the functional tests with that parallelism? As the threads may open files, this could be hitting the max open files limit? Or maybe it is a different limit hit?

Thanks, I added `-par=1` to all nodes spawned in `features_proxy.py` in 6980852416040bdddf111df3cea3ec50639f010a. That test spawns lots of nodes and block validation is not relevant to it.

> What's the status here?

Rebased to fix silent conflicts and
...