📝 fanquake opened a pull request: "[27.x] Backports"
(https://github.com/bitcoin/bitcoin/pull/33416)
Backports:
* #30198 (partial)
(https://github.com/bitcoin/bitcoin/pull/33416)
Backports:
* #30198 (partial)
⚠️ zaidmstrr opened an issue: "Test interface_ipc.py fails with Duplicate ID error when libmultiprocess is installed system-wide"
(https://github.com/bitcoin/bitcoin/issues/33417)
When I tried to run the `interface_ipc.py` functional test it failed with the error:
```
2025-09-17T08:33:50.642653Z TestFramework (INFO): PRNG seed is: 5837581670543711780
2025-09-17T08:33:50.643144Z TestFramework (INFO): Initializing test directory /tmp/bitcoin_func_test_qg32uhlp
terminate called after throwing an instance of 'kj::ExceptionImpl'
what(): mp/proxy.capnp:0: failed: Duplicate ID @0xcc316e3f71a040fb.
Aborted (core dumped)
```
After further investigating the issue I found that wh
...
(https://github.com/bitcoin/bitcoin/issues/33417)
When I tried to run the `interface_ipc.py` functional test it failed with the error:
```
2025-09-17T08:33:50.642653Z TestFramework (INFO): PRNG seed is: 5837581670543711780
2025-09-17T08:33:50.643144Z TestFramework (INFO): Initializing test directory /tmp/bitcoin_func_test_qg32uhlp
terminate called after throwing an instance of 'kj::ExceptionImpl'
what(): mp/proxy.capnp:0: failed: Duplicate ID @0xcc316e3f71a040fb.
Aborted (core dumped)
```
After further investigating the issue I found that wh
...
👍 willcl-ark approved a pull request: "[28.x] More backports"
(https://github.com/bitcoin/bitcoin/pull/33415#pullrequestreview-3234820180)
ACK 7575828dd2ea539e103067cd35e31333797d22e3
Backports look good. Release notes contain all commits and authors.
(https://github.com/bitcoin/bitcoin/pull/33415#pullrequestreview-3234820180)
ACK 7575828dd2ea539e103067cd35e31333797d22e3
Backports look good. Release notes contain all commits and authors.
💬 fanquake commented on issue "Test interface_ipc.py fails with Duplicate ID error when libmultiprocess is installed system-wide":
(https://github.com/bitcoin/bitcoin/issues/33417#issuecomment-3303331647)
cc @Sjors @ryanofsky
(https://github.com/bitcoin/bitcoin/issues/33417#issuecomment-3303331647)
cc @Sjors @ryanofsky
⚠️ hebasto opened an issue: "`bitcoin.exe` is not included in Windows installer"
(https://github.com/bitcoin/bitcoin/issues/33418)
`bitcoin.exe` does not appear to be included in the Windows installer. Was this intended?
(https://github.com/bitcoin/bitcoin/issues/33418)
`bitcoin.exe` does not appear to be included in the Windows installer. Was this intended?
💬 hebasto commented on issue "`bitcoin.exe` is not included in Windows installer":
(https://github.com/bitcoin/bitcoin/issues/33418#issuecomment-3303372538)
cc @ryanofsky
(https://github.com/bitcoin/bitcoin/issues/33418#issuecomment-3303372538)
cc @ryanofsky
💬 prokillmoon7 commented on issue "`bitcoin.exe` is not included in Windows installer":
(https://github.com/bitcoin/bitcoin/issues/33418#issuecomment-3303375347)
Download and test this.
[9b80fc5ca322.zip](https://github.com/user-attachments/files/22388301/9b80fc5ca322.zip)
(https://github.com/bitcoin/bitcoin/issues/33418#issuecomment-3303375347)
Download and test this.
[9b80fc5ca322.zip](https://github.com/user-attachments/files/22388301/9b80fc5ca322.zip)
💬 Eunovo commented on pull request "wallet/rpc: fix listdescriptors RPC fails to return descriptors with private key information when wallet contains descriptors missing any key":
(https://github.com/bitcoin/bitcoin/pull/32471#issuecomment-3303403421)
Rebased on master @https://github.com/bitcoin/bitcoin/commit/2d6a0c4649 and refactored the based on suggestions from @achow101
(https://github.com/bitcoin/bitcoin/pull/32471#issuecomment-3303403421)
Rebased on master @https://github.com/bitcoin/bitcoin/commit/2d6a0c4649 and refactored the based on suggestions from @achow101
💬 sipa commented on pull request "cluster mempool: control/optimize TxGraph memory usage":
(https://github.com/bitcoin/bitcoin/pull/33157#discussion_r2355828081)
Done. I've also refactored these asserts a bit, moving some of them from `*ClusterImpl::SanityCheck` to `TxGraphImpl::SanityCheck`, so duplication across the two implementations can be avoided.
(https://github.com/bitcoin/bitcoin/pull/33157#discussion_r2355828081)
Done. I've also refactored these asserts a bit, moving some of them from `*ClusterImpl::SanityCheck` to `TxGraphImpl::SanityCheck`, so duplication across the two implementations can be avoided.
✅ hebasto closed an issue: "`bitcoin.exe` is not included in Windows installer"
(https://github.com/bitcoin/bitcoin/issues/33418)
(https://github.com/bitcoin/bitcoin/issues/33418)
💬 hebasto commented on issue "`bitcoin.exe` is not included in Windows installer":
(https://github.com/bitcoin/bitcoin/issues/33418#issuecomment-3303414350)
nm
(https://github.com/bitcoin/bitcoin/issues/33418#issuecomment-3303414350)
nm
💬 sipa commented on pull request "txgraph: randomize order of same-feerate distinct-cluster transactions":
(https://github.com/bitcoin/bitcoin/pull/33335#issuecomment-3303438667)
Rebased on top of #33157, as there are some conflicts, and I expect the other one will go in first.
(https://github.com/bitcoin/bitcoin/pull/33335#issuecomment-3303438667)
Rebased on top of #33157, as there are some conflicts, and I expect the other one will go in first.
💬 hebasto commented on pull request "build: Remove bitness suffix from Windows installer":
(https://github.com/bitcoin/bitcoin/pull/32132#issuecomment-3303467007)
This needs to be elaborated in Release Notes.
When upgrading to v30.0, it appears necessary to uninstall first in order to remove the "... (64-bit)" Start Menu entries. Otherwise, they remain lingering.
(https://github.com/bitcoin/bitcoin/pull/32132#issuecomment-3303467007)
This needs to be elaborated in Release Notes.
When upgrading to v30.0, it appears necessary to uninstall first in order to remove the "... (64-bit)" Start Menu entries. Otherwise, they remain lingering.
💬 ryanofsky commented on issue "Test interface_ipc.py fails with Duplicate ID error when libmultiprocess is installed system-wide":
(https://github.com/bitcoin/bitcoin/issues/33417#issuecomment-3303596365)
I wonder if changing order of import directories to put the local include path first would fix this:
```diff
- imports = [str(capnp_dir), str(src_dir), str(mp_dir)]
+ imports = [str(mp_dir), str(capnp_dir), str(src_dir)]
```
So far I'm not able to reproduce it on nixos since there's no global include directory. But I think the problem might be the line [`capnp.load(str(mp_dir / "mp" / "proxy.capnp"), imports=imports)`](https://github.com/bitcoin/bitcoin/blob/1444ed855f438f1270104
...
(https://github.com/bitcoin/bitcoin/issues/33417#issuecomment-3303596365)
I wonder if changing order of import directories to put the local include path first would fix this:
```diff
- imports = [str(capnp_dir), str(src_dir), str(mp_dir)]
+ imports = [str(mp_dir), str(capnp_dir), str(src_dir)]
```
So far I'm not able to reproduce it on nixos since there's no global include directory. But I think the problem might be the line [`capnp.load(str(mp_dir / "mp" / "proxy.capnp"), imports=imports)`](https://github.com/bitcoin/bitcoin/blob/1444ed855f438f1270104
...
💬 00w1 commented on pull request "policy: lower the default blockmintxfee, incrementalrelayfee, minrelaytxfee":
(https://github.com/bitcoin/bitcoin/pull/33106#issuecomment-3303649039)
> As far as I can tell, around 10% of nodes that report a minfeefilter are already using 0.1 sats/vB or less at this point, so it should improve rapidly.
96% nodes are using 1sat/vB: https://delvingbitcoin.org/t/measuring-minrelaytxfee-across-the-bitcoin-network/
Mining pools that are **not** using 0.1 sat/vB for `blockcmintxfee`: ViaBTC, F2Pool, MARA, Ocean and SBI Crypto
(https://github.com/bitcoin/bitcoin/pull/33106#issuecomment-3303649039)
> As far as I can tell, around 10% of nodes that report a minfeefilter are already using 0.1 sats/vB or less at this point, so it should improve rapidly.
96% nodes are using 1sat/vB: https://delvingbitcoin.org/t/measuring-minrelaytxfee-across-the-bitcoin-network/
Mining pools that are **not** using 0.1 sat/vB for `blockcmintxfee`: ViaBTC, F2Pool, MARA, Ocean and SBI Crypto
💬 Sjors commented on pull request "Silent Payments: Receiving":
(https://github.com/bitcoin/bitcoin/pull/32966#issuecomment-3303689146)
Lightly tested cc0b97b7879a73b9341bf88391312799be91439a by creating a fresh wallet in the GUI, importing my earlier silent payment descriptor and rescanning to find my funds. I managed to send some coin and checked that the change went back to the descriptor (there are no other descriptors in the wallet).
When I tried to import it into a fresh watch-only wallet I got:
> Cannot import silent payment descriptor into a wallet with silent-payments disabled
It would be nicer if it just toggl
...
(https://github.com/bitcoin/bitcoin/pull/32966#issuecomment-3303689146)
Lightly tested cc0b97b7879a73b9341bf88391312799be91439a by creating a fresh wallet in the GUI, importing my earlier silent payment descriptor and rescanning to find my funds. I managed to send some coin and checked that the change went back to the descriptor (there are no other descriptors in the wallet).
When I tried to import it into a fresh watch-only wallet I got:
> Cannot import silent payment descriptor into a wallet with silent-payments disabled
It would be nicer if it just toggl
...
💬 l0rinc commented on pull request "coins: warn on oversized `-dbcache`":
(https://github.com/bitcoin/bitcoin/pull/33333#discussion_r2356043011)
that's what the previous check does on line 23, this validates that it's in a reasonable range, e.g. we're not returning number of bits or something
(https://github.com/bitcoin/bitcoin/pull/33333#discussion_r2356043011)
that's what the previous check does on line 23, this validates that it's in a reasonable range, e.g. we're not returning number of bits or something
💬 Sjors commented on pull request "multiprocess: Don't require bitcoin -m argument when IPC options are used":
(https://github.com/bitcoin/bitcoin/pull/33229#issuecomment-3303715446)
re-ACK 453b0fa286e5dce0af682b7b73684dd6415a50de
Just a rebase. Briefly retested on macOS that `build/bin/bitcoin node -ipcbind=unix` launches `bitcoin-node`.
(https://github.com/bitcoin/bitcoin/pull/33229#issuecomment-3303715446)
re-ACK 453b0fa286e5dce0af682b7b73684dd6415a50de
Just a rebase. Briefly retested on macOS that `build/bin/bitcoin node -ipcbind=unix` launches `bitcoin-node`.
💬 l0rinc commented on pull request "coinstats: avoid unnecessary Coin copy in ApplyHash":
(https://github.com/bitcoin/bitcoin/pull/33410#discussion_r2356055506)
given the above warning, can you create a godbolt reproducer to check if the compiler can already deduce this or not?
(https://github.com/bitcoin/bitcoin/pull/33410#discussion_r2356055506)
given the above warning, can you create a godbolt reproducer to check if the compiler can already deduce this or not?
⚠️ yancyribbens opened an issue: "coin-grinder missing test for TOTAL_TRIES"
(https://github.com/bitcoin/bitcoin/issues/33419)
The following (mutation) code can be remove from coin-grinder [here](https://github.com/bitcoin/bitcoin/blob/1444ed855f438f1270104fca259ce61b99ed5cdb/src/wallet/coinselection.cpp#L466) without encountering a test failure
```
if (curr_try >= TOTAL_TRIES) {
// Solution is not guaranteed to be optimal if `curr_try` hit TOTAL_TRIES
result.SetAlgoCompleted(false);
break;
}
```
This ought to be a similar test to [Test BnB attempt limit (`TOTAL_TRIES`)](https://github.com/bitcoin/bitcoin/b
...
(https://github.com/bitcoin/bitcoin/issues/33419)
The following (mutation) code can be remove from coin-grinder [here](https://github.com/bitcoin/bitcoin/blob/1444ed855f438f1270104fca259ce61b99ed5cdb/src/wallet/coinselection.cpp#L466) without encountering a test failure
```
if (curr_try >= TOTAL_TRIES) {
// Solution is not guaranteed to be optimal if `curr_try` hit TOTAL_TRIES
result.SetAlgoCompleted(false);
break;
}
```
This ought to be a similar test to [Test BnB attempt limit (`TOTAL_TRIES`)](https://github.com/bitcoin/bitcoin/b
...