👍 hodlinator approved a pull request: "Remove unnecessary casts when calling socket operations"
(https://github.com/bitcoin/bitcoin/pull/33378#pullrequestreview-3229478311)
ACK 67f632b6deb8b4aa190c458b71d2bc8c793626d5
(PR description still ends with "Opening as a draft for now to test CI on supported platforms.")
(https://github.com/bitcoin/bitcoin/pull/33378#pullrequestreview-3229478311)
ACK 67f632b6deb8b4aa190c458b71d2bc8c793626d5
(PR description still ends with "Opening as a draft for now to test CI on supported platforms.")
📝 willcl-ark opened a pull request: "WIP: Backport Cirrus runners to 29.x"
(https://github.com/bitcoin/bitcoin/pull/33403)
Backports #32989 to the 29.x branch
(https://github.com/bitcoin/bitcoin/pull/33403)
Backports #32989 to the 29.x branch
💬 hodlinator commented on pull request "coins: warn on oversized `-dbcache`":
(https://github.com/bitcoin/bitcoin/pull/33333#discussion_r2352176441)
Yeah, now that you use `InitWarning()` adjacently, it's clearer why we would expect true.
(https://github.com/bitcoin/bitcoin/pull/33333#discussion_r2352176441)
Yeah, now that you use `InitWarning()` adjacently, it's clearer why we would expect true.
👍 hodlinator approved a pull request: "coins: warn on oversized `-dbcache`"
(https://github.com/bitcoin/bitcoin/pull/33333#pullrequestreview-3229526417)
ACK 13fa0d0a433722f294854001b0561c079db12dbc
Very helpful to warn users against unintentionally making their system start swapping insanely.
(https://github.com/bitcoin/bitcoin/pull/33333#pullrequestreview-3229526417)
ACK 13fa0d0a433722f294854001b0561c079db12dbc
Very helpful to warn users against unintentionally making their system start swapping insanely.
💬 fanquake commented on issue "Default ASmap file path is not used unless -asmap is set":
(https://github.com/bitcoin/bitcoin/issues/33386#issuecomment-3298250998)
@fjahr
(https://github.com/bitcoin/bitcoin/issues/33386#issuecomment-3298250998)
@fjahr
⚠️ mstampfer opened an issue: "Add zsh completion scripts for Bitcoin Core command-line tools"
(https://github.com/bitcoin/bitcoin/issues/33404)
### Please describe the feature you'd like to see added.
Bitcoin Core currently provides bash completion scripts for `bitcoin-cli`, `bitcoin-tx`, and `bitcoind` in `contrib/completions/bash/`, and similarly, fish completion scripts are available in `contrib/completions/fish/`, but there are no equivalent completion scripts for zsh users. Many developers and users have adopted zsh as their default shell (especially Mac OSX users and with tools like Oh My Zsh), and they cannot benefit from tab co
...
(https://github.com/bitcoin/bitcoin/issues/33404)
### Please describe the feature you'd like to see added.
Bitcoin Core currently provides bash completion scripts for `bitcoin-cli`, `bitcoin-tx`, and `bitcoind` in `contrib/completions/bash/`, and similarly, fish completion scripts are available in `contrib/completions/fish/`, but there are no equivalent completion scripts for zsh users. Many developers and users have adopted zsh as their default shell (especially Mac OSX users and with tools like Oh My Zsh), and they cannot benefit from tab co
...
⚠️ deyvid61 opened an issue: "Gj"
(https://github.com/bitcoin/bitcoin/issues/33405)
../ test.rc1/ 28-Jul-2025 19:01 - test.rc2/ 28-Aug-2025 17:38 - SHA256SUMS 04-Sep-2025 17:36 2956 SHA256SUMS.asc 04-Sep-2025 17:36 9968 SHA256SUMS.ots 04-Sep-2025 17:37 422 bitcoin-29.1-aarch64-linux-gnu-debug.tar.gz 04-Sep-2025 17:36 464841495 bitcoin-29.1-aarch64-linux-gnu.tar.gz 04-Sep-2025 17:36 47955246 bitcoin-29.1-arm-linux-gnueabihf-debug.tar.gz 04-Sep-2025 17:36 467016379 bitcoin-29.1-arm-linux-gnueabihf.tar.gz 04-Sep-2025 17:36 44510860 bitcoin-29.1-arm64-apple-darwin-codesigning.tar.
...
(https://github.com/bitcoin/bitcoin/issues/33405)
../ test.rc1/ 28-Jul-2025 19:01 - test.rc2/ 28-Aug-2025 17:38 - SHA256SUMS 04-Sep-2025 17:36 2956 SHA256SUMS.asc 04-Sep-2025 17:36 9968 SHA256SUMS.ots 04-Sep-2025 17:37 422 bitcoin-29.1-aarch64-linux-gnu-debug.tar.gz 04-Sep-2025 17:36 464841495 bitcoin-29.1-aarch64-linux-gnu.tar.gz 04-Sep-2025 17:36 47955246 bitcoin-29.1-arm-linux-gnueabihf-debug.tar.gz 04-Sep-2025 17:36 467016379 bitcoin-29.1-arm-linux-gnueabihf.tar.gz 04-Sep-2025 17:36 44510860 bitcoin-29.1-arm64-apple-darwin-codesigning.tar.
...
💬 deyvid61 commented on issue "Gj":
(https://github.com/bitcoin/bitcoin/issues/33405#issuecomment-3298347665)
Deyvid61
(https://github.com/bitcoin/bitcoin/issues/33405#issuecomment-3298347665)
Deyvid61
✅ deyvid61 closed an issue: "Gj"
(https://github.com/bitcoin/bitcoin/issues/33405)
(https://github.com/bitcoin/bitcoin/issues/33405)
⚠️ deyvid61 reopened an issue: "Gj"
(https://github.com/bitcoin/bitcoin/issues/33405)
../ test.rc1/ 28-Jul-2025 19:01 - test.rc2/ 28-Aug-2025 17:38 - SHA256SUMS 04-Sep-2025 17:36 2956 SHA256SUMS.asc 04-Sep-2025 17:36 9968 SHA256SUMS.ots 04-Sep-2025 17:37 422 bitcoin-29.1-aarch64-linux-gnu-debug.tar.gz 04-Sep-2025 17:36 464841495 bitcoin-29.1-aarch64-linux-gnu.tar.gz 04-Sep-2025 17:36 47955246 bitcoin-29.1-arm-linux-gnueabihf-debug.tar.gz 04-Sep-2025 17:36 467016379 bitcoin-29.1-arm-linux-gnueabihf.tar.gz 04-Sep-2025 17:36 44510860 bitcoin-29.1-arm64-apple-darwin-codesigning.tar.
...
(https://github.com/bitcoin/bitcoin/issues/33405)
../ test.rc1/ 28-Jul-2025 19:01 - test.rc2/ 28-Aug-2025 17:38 - SHA256SUMS 04-Sep-2025 17:36 2956 SHA256SUMS.asc 04-Sep-2025 17:36 9968 SHA256SUMS.ots 04-Sep-2025 17:37 422 bitcoin-29.1-aarch64-linux-gnu-debug.tar.gz 04-Sep-2025 17:36 464841495 bitcoin-29.1-aarch64-linux-gnu.tar.gz 04-Sep-2025 17:36 47955246 bitcoin-29.1-arm-linux-gnueabihf-debug.tar.gz 04-Sep-2025 17:36 467016379 bitcoin-29.1-arm-linux-gnueabihf.tar.gz 04-Sep-2025 17:36 44510860 bitcoin-29.1-arm64-apple-darwin-codesigning.tar.
...
✅ pinheadmz closed an issue: "Gj"
(https://github.com/bitcoin/bitcoin/issues/33405)
(https://github.com/bitcoin/bitcoin/issues/33405)
💬 martinatime commented on issue "bitcoind 29.0 much slower than 28.0 on my system: cause found":
(https://github.com/bitcoin/bitcoin/issues/32455#issuecomment-3298613116)
Another update. I decided to run a test by using the same setup as I mentioned above but a new (yet slower) USB SSD connected to my RPi via a powered USB hub and I redid the IBD. This time it took approximately six days. The OS was run off of the initial USB SSD which was directly attached to the RPI. So maybe the issue is I/O contention either at the USB Bus level or within the OS (RaspOS/Debian Bookworm). At this time I'm going to stop looking into this. Cheers all!
(https://github.com/bitcoin/bitcoin/issues/32455#issuecomment-3298613116)
Another update. I decided to run a test by using the same setup as I mentioned above but a new (yet slower) USB SSD connected to my RPi via a powered USB hub and I redid the IBD. This time it took approximately six days. The OS was run off of the initial USB SSD which was directly attached to the RPI. So maybe the issue is I/O contention either at the USB Bus level or within the OS (RaspOS/Debian Bookworm). At this time I'm going to stop looking into this. Cheers all!
💬 pinheadmz commented on pull request "Remove unnecessary casts when calling socket operations":
(https://github.com/bitcoin/bitcoin/pull/33378#issuecomment-3298628111)
Thanks for the edit @fanquake 🥰
(https://github.com/bitcoin/bitcoin/pull/33378#issuecomment-3298628111)
Thanks for the edit @fanquake 🥰
👍 vasild approved a pull request: "Remove unnecessary casts when calling socket operations"
(https://github.com/bitcoin/bitcoin/pull/33378#pullrequestreview-3229896344)
ACK 67f632b6deb8b4aa190c458b71d2bc8c793626d5
(https://github.com/bitcoin/bitcoin/pull/33378#pullrequestreview-3229896344)
ACK 67f632b6deb8b4aa190c458b71d2bc8c793626d5
📝 willcl-ark opened a pull request: "WIP: Backport Cirrus runners to 28.x"
(https://github.com/bitcoin/bitcoin/pull/33406)
Backports https://github.com/bitcoin/bitcoin/pull/32989 to the 28.x branch
(https://github.com/bitcoin/bitcoin/pull/33406)
Backports https://github.com/bitcoin/bitcoin/pull/32989 to the 28.x branch
💬 HowHsu commented on pull request "help: enrich help text for `-loadblock`":
(https://github.com/bitcoin/bitcoin/pull/33343#issuecomment-3298744240)
> @HowHsu Did you try `contrib/linearize` yourself to export the `.blk` files for `-loadblock`? Did it solve your issue? I have suggested a simpler documentation, do you think that help others to use the linearize tool when they're in your situation?
I didn't, but I read the code of them (files under `contrib/linearize`), it is not for arbitrary blocks, it only accepts a list of blocks with contiguous heights. So I just add `for clues of deobfuscation and reobfuscation`. For my scenario, I'v
...
(https://github.com/bitcoin/bitcoin/pull/33343#issuecomment-3298744240)
> @HowHsu Did you try `contrib/linearize` yourself to export the `.blk` files for `-loadblock`? Did it solve your issue? I have suggested a simpler documentation, do you think that help others to use the linearize tool when they're in your situation?
I didn't, but I read the code of them (files under `contrib/linearize`), it is not for arbitrary blocks, it only accepts a list of blocks with contiguous heights. So I just add `for clues of deobfuscation and reobfuscation`. For my scenario, I'v
...
📝 hebasto opened a pull request: "cmake: Install `bitcoin` manpage"
(https://github.com/bitcoin/bitcoin/pull/33407)
This PR is an amendment to https://github.com/bitcoin/bitcoin/pull/33348.
(https://github.com/bitcoin/bitcoin/pull/33407)
This PR is an amendment to https://github.com/bitcoin/bitcoin/pull/33348.
💬 fjahr commented on issue "Default ASmap file path is not used unless -asmap is set":
(https://github.com/bitcoin/bitcoin/issues/33386#issuecomment-3298756998)
I agree that this whole default location thing is a bit odd and it's not something I think we necessarily need but it was already there when I started to get more involved in ASmap and I didn't find it so harmful that it needed to be removed. It can be easily ignored by just not putting a file there after all, so if you don't like it just don't use it, I guess.
> The -asmap option supposedly has a default value ip_asn.map (as defined by DEFAULT_ASMAP_FILENAME). However, when I tried to put a fi
...
(https://github.com/bitcoin/bitcoin/issues/33386#issuecomment-3298756998)
I agree that this whole default location thing is a bit odd and it's not something I think we necessarily need but it was already there when I started to get more involved in ASmap and I didn't find it so harmful that it needed to be removed. It can be easily ignored by just not putting a file there after all, so if you don't like it just don't use it, I guess.
> The -asmap option supposedly has a default value ip_asn.map (as defined by DEFAULT_ASMAP_FILENAME). However, when I tried to put a fi
...
💬 fanquake commented on pull request "cmake: Install `bitcoin` manpage":
(https://github.com/bitcoin/bitcoin/pull/33407#issuecomment-3298757665)
> This PR is an amendment to https://github.com/bitcoin/bitcoin/pull/33348.
Not sure this is related to #33348. It should have been part of #31375?
(https://github.com/bitcoin/bitcoin/pull/33407#issuecomment-3298757665)
> This PR is an amendment to https://github.com/bitcoin/bitcoin/pull/33348.
Not sure this is related to #33348. It should have been part of #31375?
💬 hebasto commented on pull request "cmake: Install `bitcoin` manpage":
(https://github.com/bitcoin/bitcoin/pull/33407#issuecomment-3298763878)
> > This PR is an amendment to #33348.
>
> Not sure this is related to #33348. It should have been part of #31375?
The PR description has been updated.
(https://github.com/bitcoin/bitcoin/pull/33407#issuecomment-3298763878)
> > This PR is an amendment to #33348.
>
> Not sure this is related to #33348. It should have been part of #31375?
The PR description has been updated.